Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big breaking change :) See description #338

Merged
merged 41 commits into from Jan 18, 2018
Merged

Big breaking change :) See description #338

merged 41 commits into from Jan 18, 2018

Conversation

snoyberg
Copy link
Owner

@snoyberg snoyberg commented Dec 20, 2017 •
edited

  • Finally moves ahead with the deprecations described in RFC: Stop using the type synonyms in library type signatures #283
  • Renames ConduitM to ConduitT
  • Drops usage of monad-control wherever possible, instead favoring unliftio
  • Still maintains dependencies on exceptions due to usage of MonadThrow, but that's up for discussion
  • Drop support for GHC < 8
  • TO BE FIXED: Due to dropping the mmorph dep, Data.Conduit.Lift no longer compiles. That will probably go in its own package, but not sure

This PR is not ready for merge, I suspect there will be feedback as well as some more cleanups to throw into the mix.

@snoyberg
Switch conduit-extra over to unliftio
f13e51c
@snoyberg
Drop a bunch of deps
2752383
@snoyberg
Deprecate old names (fixes #283)
70db998 
Switches from ConduitM to ConduitT, adds `type ConduitM = ConduitT` for
backwards compat, and deprecates Source, Sink, Conduit, Producer,
Consumer, $$, $=, =$, and =$=. Still should do renamings to get rid of
all the deprecation warnings.
@snoyberg
Remove unneeded dep
90c14ae
@snoyberg
Drop monad-control from network-conduit-tls
33d702f
@snoyberg
Clean up warnings, not complete. Drop older GHC support
7f0f564
@snoyberg
Switch back to conduitGet
97f33e3
@snoyberg
No warnings, tests pass
cc946ab
@snoyberg
Got Data.Conduit.Lift working again
716b509
@snoyberg
Merge remote-tracking branch 'origin/master' into just-unliftio
78f174c
@snoyberg
Add PrimMonad instance for ResourceT
629911c
@snoyberg
Add back runCatchC
6f19c8d
@snoyberg
Mention rio import
c419822
@snoyberg
Initial "drop finalizer" research
e7f0cb7
@snoyberg
Merge remote-tracking branch 'origin/master' into just-unliftio
09d8b19
@snoyberg
It all compiles again
bf6fd2a
@snoyberg
Merge remote-tracking branch 'origin/master' into just-unliftio
578c9e0
@snoyberg
runResourceT is now the same as runResourceTChecked
6bde6e2 
CC @nh2
@snoyberg
Move Data.Conduit.Combinators into conduit
e6e37f7
@snoyberg
Combine test suites; subdir
cce8b4d
@snoyberg
Add some benchmarks from conduit-combinators
ec21762
@snoyberg
Add builder stuff to Data.Conduit.Combinators
dac3537
@snoyberg
Drop blaze-builder, use upstram functionality
9a4755b
@snoyberg
Further code cleanups
8c8927d
@snoyberg
Drop ResumableSource/ResumableConduit, now have SealedConduitT
19ee942
@snoyberg
Correct the @SInCE comments
c9c0e6b
@snoyberg
Add comment on out-of-date tutorial
adccacd
@snoyberg
Get a benchmark to compile again
887fb50
@snoyberg
Switch to gauge
2306cb6
@snoyberg
Clean up warnings
d4f7105
@snoyberg snoyberg mentioned this pull request Jan 17, 2018
Closed
@snoyberg
Non-quadratic lines (fixes #341)
ffe6d58 
Nice catch @nh2. I'd rather use a difference list than lazy Text, as the
latter will still have some quadratic complexity. Does this address the
case you were concerned with?
@snoyberg
Uncomment some tests
efafd9b
This was referenced Jan 17, 2018
Closed
Closed
@snoyberg snoyberg merged commit 7f75bfc into master Jan 18, 2018
@snoyberg snoyberg deleted the just-unliftio branch January 18, 2018 07:26
@Ericson2314
Copy link

I was hoping there'd still be a monomorphic way to hoist a ResourceT after this, but that does not appear to be the case?

@snoyberg
Copy link
Owner Author

I believe transPipe (https://www.stackage.org/haddock/lts-12.0/conduit-1.3.0.3/Data-Conduit.html#v:transPipe) should fulfill that role.

@Ericson2314
Copy link

Thank you. Indeed transPipe and transResourceT do just that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snoyberg @Ericson2314