Slightly faster Binary.lines #47

Merged
merged 2 commits into from Apr 22, 2012

Conversation

Projects
None yet
2 participants
@luispedro
Contributor

luispedro commented Apr 20, 2012

Slightly faster than using stateConduit (0.50s vs 0.60s before the change in a simple count the lines benchmark [5M lines]), with -O2.

This is similar to a recent blog post in Yesod blog.

luispedro added some commits Apr 20, 2012

ENH Code `lines` directly
Slightly faster than using stateConduit (0.50s vs 0.60s before the
change in a simple count the lines benchmark [5M lines]), with -O2.
BUG Match previous interface wrt. leftover bytes
It is likely to be a more correct interface in any case

@snoyberg snoyberg merged commit e7b3a89 into snoyberg:master Apr 22, 2012

@snoyberg

This comment has been minimized.

Show comment Hide comment
@snoyberg

snoyberg Apr 22, 2012

Owner

Thanks!

Owner

snoyberg commented Apr 22, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment