Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix buggy finalization behavior #57
Finalizers are forgotten under certain circumstances, and pipes with finalizers are not associative. I've provided a solution that solves both of these issues by adding a finalizer to the
I've included a file with simple test cases; the current implementation fails two of the three, while the proposed change passes all three.
For reference, here's the
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Based on a blog post by @Gabriel439, it seems like this is an inherent contradiction. I still believe that prompt finalization is more important than ordering of finalization calls, and the library never made any claims of associativity, so I don't consider this a bug, only an enhancement.
To clarify: this only refers to the ordering of finalizer calls, the dropped finalizers issue is a bug that was fixed a while ago.