New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NO_PROXY environment variable #140

Closed
hgiddens opened this Issue Jul 27, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@hgiddens
Contributor

hgiddens commented Jul 27, 2015

As @mmaz mentioned in #127, NO_PROXY is supported by various tools to avoid involving the proxy for a selection of hosts. For example, in the environment I'm using http-client in, external services are only accessible via the proxy, whereas internal services are only accessible directly. Currently I'm working around this explicitly, but direct support for the NO_PROXY environment variable would mean that everything Just Works™.

Other tools that support the variable include:

Other systems typically support the same functionality, although not necessarily via environment variables or with the same syntax. For example, Java sports a http.nonProxyHosts system property.

If you're ok with the idea I'll have a go at an implementation.

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Jul 27, 2015

Owner

I am not familiar with the environment variable, but have no objection.
Pull request certainly welcome. Please try to include a link to relevant
specs in the comments.

On Sun, Jul 26, 2015, 7:44 PM Huw notifications@github.com wrote:

As @mmaz https://github.com/mmaz mentioned in #127
#127, NO_PROXY is
supported by various tools to avoid involving the proxy for a selection of
hosts. For example, in the environment I'm using http-client in, external
services are only accessible via the proxy, whereas internal services are
only accessible directly. Currently I'm working around this explicitly, but
direct support for the NO_PROXY environment variable would mean that
everything Just Works™.

Other tools that support the variable include:

Other systems typically support the same functionality, although not
necessarily via environment variables or with the same syntax. For example, Java
sports a http.nonProxyHosts system property
https://docs.oracle.com/javase/8/docs/api/java/net/doc-files/net-properties.html
.

If you're ok with the idea I'll have a go at an implementation.


Reply to this email directly or view it on GitHub
#140.

Owner

snoyberg commented Jul 27, 2015

I am not familiar with the environment variable, but have no objection.
Pull request certainly welcome. Please try to include a link to relevant
specs in the comments.

On Sun, Jul 26, 2015, 7:44 PM Huw notifications@github.com wrote:

As @mmaz https://github.com/mmaz mentioned in #127
#127, NO_PROXY is
supported by various tools to avoid involving the proxy for a selection of
hosts. For example, in the environment I'm using http-client in, external
services are only accessible via the proxy, whereas internal services are
only accessible directly. Currently I'm working around this explicitly, but
direct support for the NO_PROXY environment variable would mean that
everything Just Works™.

Other tools that support the variable include:

Other systems typically support the same functionality, although not
necessarily via environment variables or with the same syntax. For example, Java
sports a http.nonProxyHosts system property
https://docs.oracle.com/javase/8/docs/api/java/net/doc-files/net-properties.html
.

If you're ok with the idea I'll have a go at an implementation.


Reply to this email directly or view it on GitHub
#140.

hgiddens added a commit to hgiddens/http-client that referenced this issue Aug 7, 2015

snoyberg added a commit that referenced this issue Aug 28, 2015

Merge pull request #145 from hgiddens/no_proxy
Support no_proxy environment variable. #140
@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Aug 28, 2015

Owner

Merged in #145, closing. Thanks!

Owner

snoyberg commented Aug 28, 2015

Merged in #145, closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment