New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newTlsManager with provided settings #278

Closed
ivan-m opened this Issue May 22, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@ivan-m
Contributor

ivan-m commented May 22, 2017

It would be nice to have a variant of newTlsManager that uses a provided ManagerSettings as a base rather than the default one so that things like timeouts can be configured.

I can provide a PR if you prefer.

ivan-m added a commit to ivan-m/http-client that referenced this issue May 22, 2017

Allow creating a TLS-based Manager using specified settings
For example, to allow for a different timeout.

Closes snoyberg#278
@ivan-m

This comment has been minimized.

Show comment
Hide comment
@ivan-m

ivan-m May 22, 2017

Contributor

Created a pull request anyway as I couldn't just create the function in my own code myself.

Contributor

ivan-m commented May 22, 2017

Created a pull request anyway as I couldn't just create the function in my own code myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment