Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build with GHC 8.4.1 #320

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Fix the build with GHC 8.4.1 #320

merged 1 commit into from
Jan 24, 2018

Conversation

RyanGlScott
Copy link
Contributor

http-client currently fails to build on GHC 8.4.1 due to missing Semigroup instances to go along with their Monoid counterparts, which this patch adds.

@RyanGlScott RyanGlScott mentioned this pull request Jan 24, 2018
Merged
snoyberg
snoyberg approved these changes Jan 24, 2018
View reviewed changes
Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for this, and your many other such patches :)

@snoyberg snoyberg merged commit c7cc51d into snoyberg:master Jan 24, 2018
snoyberg added a commit that referenced this pull request Jan 24, 2018
@snoyberg
Version bump for #320
37103f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RyanGlScott @snoyberg