New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tests not requiring internet access. #93

Merged
merged 1 commit into from Dec 15, 2014

Conversation

Projects
None yet
2 participants
@orlitzky
Contributor

orlitzky commented Dec 14, 2014

Most of the tests in the existing test suite do not require internet
access. However a few of them do make requests to external hosts --
this causes the test suite to fail when the user's network connection
is down or otherwise unavailable.

This commit separates the existing "spec" test suite into "spec" and
"spec-nonet" components, the latter being the subset of tests that
work when the network connection is down. A separate "test-nonet"
directory is added to preserve the existing hspec autodiscovery magic.

Some redundant imports were removed after the restructuring, and a few
occurrences of unused variables were changed to "_".

Separate tests not requiring internet access.
Most of the tests in the existing test suite do not require internet
access. However a few of them do make requests to external hosts --
this causes the test suite to fail when the user's network connection
is down or otherwise unavailable.

This commit separates the existing "spec" test suite into "spec" and
"spec-nonet" components, the latter being the subset of tests that
work when the network connection is down. A separate "test-nonet"
directory is added to preserve the existing hspec autodiscovery magic.

Some redundant imports were removed after the restructuring, and a few
occurrences of unused variables were changed to "_".

@snoyberg snoyberg merged commit ecf409e into snoyberg:master Dec 15, 2014

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Dec 15, 2014

Owner

Thanks, released to Hackage as 0.4.6.1.

Owner

snoyberg commented Dec 15, 2014

Thanks, released to Hackage as 0.4.6.1.

@orlitzky

This comment has been minimized.

Show comment
Hide comment
@orlitzky

orlitzky Dec 15, 2014

Contributor

Awesome, thank you.

Contributor

orlitzky commented Dec 15, 2014

Awesome, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment