Skip to content
This repository

Fix defaultCheckCerts. #6

Closed
wants to merge 2 commits into from

2 participants

Felipe Lessa Michael Snoyman
Felipe Lessa

IMHO, this warrants a heads-up at least on web-devel since there may be someone relying on http-conduit to check the certificates.

Also, is http-enumerator still maintained? This fix definitely needs to be backported.

Felipe Lessa

Regarding http-enumerator, done here: snoyberg/http-enumerator#54.

Michael Snoyman
Owner

I applied your fix to an older commit, released, and then merged. Thanks!

Michael Snoyman snoyberg closed this January 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
2  Network/HTTP/Conduit/Request.hs
@@ -165,7 +165,7 @@ defaultCheckCerts :: W.Ascii -> [X509] -> IO TLSCertificateUsage
165 165
 defaultCheckCerts host' certs =
166 166
     case certificateVerifyDomain (S8.unpack host') certs of
167 167
         CertificateUsageAccept -> certificateVerifyChain certs
168  
-        _                          -> return CertificateUsageAccept
  168
+        rejected               -> return rejected
169 169
 
170 170
 instance Default (Request m) where
171 171
     def = Request
2  http-conduit.cabal
... ...
@@ -1,5 +1,5 @@
1 1
 name:            http-conduit
2  
-version:         1.1.2.1
  2
+version:         1.1.2
3 3
 license:         BSD3
4 4
 license-file:    LICENSE
5 5
 author:          Michael Snoyman <michael@snoyman.com>
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.