Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues decoding leading escaped spaces when using Text.XML.Stream.Parse #74

Closed
alexkalderimis opened this Issue Feb 3, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@alexkalderimis
Copy link
Contributor

alexkalderimis commented Feb 3, 2016

content and maybeContent both skip over leading escaped whitespace.

A minimal example is:

<term name="foo">&#160;&#39;&#160;</term>

where the content parses as: "'\160", rather than "\160'\160".

Note that trailing characters are treated correctly.

@alexkalderimis

This comment has been minimized.

Copy link
Contributor Author

alexkalderimis commented Feb 3, 2016

Note that I am having issues replicating this. I will report back here with any resolution.

@alexkalderimis

This comment has been minimized.

Copy link
Contributor Author

alexkalderimis commented Feb 3, 2016

Please see the attached PR: (#75) this is an issue with back-tracking. When choosing between an element or bare-content, the first character is stripped when it is encoded whitespace.

The fix for this is to use the appropriate white-space test.

I fear that there may be more work to do here, since this indicates that in some circumstances &#32; (space) will be treated the same as a real space, and skipped.

Still, this fixes one set of errors.

@snoyberg

This comment has been minimized.

Copy link
Owner

snoyberg commented Feb 15, 2016

I've just pushed a commit to the whitespace branch which includes your test cases, which all now pass. Can you test this out before I merge/release?

@snoyberg snoyberg closed this in 330cb0c Mar 2, 2016

@alexkalderimis

This comment has been minimized.

Copy link
Contributor Author

alexkalderimis commented Mar 2, 2016

Sorry, I somehow missed your message from the 15th of Feb. My apologies.

On 2 March 2016 at 09:10, Michael Snoyman notifications@github.com wrote:

Closed #74 #74 via 330cb0c
330cb0c
.


Reply to this email directly or view it on GitHub
#74 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.