Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'parseText' becomes 'parseText'/'parseTextPos', depending on the output type #47

Merged
merged 1 commit into from Apr 22, 2015

Conversation

Projects
None yet
2 participants
@k0ral
Copy link
Collaborator

k0ral commented Apr 22, 2015

This is consistent with the existing parseBytes/parseBytesPos.
However, this is a backward-incompatible change...

@snoyberg

This comment has been minimized.

Copy link
Owner

snoyberg commented Apr 22, 2015

Despite the current API inconsistency, I'd rather not break the API. How about:

  • Add parseTextPos as you have
  • Add parseText' with the type of parseText in your PR
  • Deprecate parseText referencing these other two functions

@k0ral k0ral force-pushed the k0ral:master branch from c17a26d to 752f597 Apr 22, 2015

@k0ral

This comment has been minimized.

Copy link
Collaborator Author

k0ral commented Apr 22, 2015

I've fixed the PR according to your comments.

snoyberg added a commit that referenced this pull request Apr 22, 2015

Merge pull request #47 from k0ral/master
'parseText' becomes 'parseText'/'parseTextPos', depending on the output type

@snoyberg snoyberg merged commit 5d68265 into snoyberg:master Apr 22, 2015

@snoyberg

This comment has been minimized.

Copy link
Owner

snoyberg commented Apr 22, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.