Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse 'MonadThrow' and 'force' for 'AttrParser' #52

Merged
merged 1 commit into from May 9, 2015

Conversation

Projects
None yet
2 participants
@k0ral
Copy link
Collaborator

k0ral commented May 8, 2015

A MonadThrow instance for AttrParser makes it possible to:

  • add custom requirements on an attribute value (e.g. parse as URI);
  • replace optionalAttr/requireAttr with attr/force, which is simpler and consistent with the rest of the API.

I made sure changes are backward-compatible.

snoyberg added a commit that referenced this pull request May 9, 2015

Merge pull request #52 from k0ral/master
Reuse 'MonadThrow' and 'force' for 'AttrParser'

@snoyberg snoyberg merged commit dd3765d into snoyberg:master May 9, 2015

@snoyberg

This comment has been minimized.

Copy link
Owner

snoyberg commented May 9, 2015

Thanks! You're definitely taking a lot of interest in this library, and contributing good stuff. Would you be interested in becoming a comaintainer of it?

@k0ral

This comment has been minimized.

Copy link
Collaborator Author

k0ral commented May 11, 2015

I would be glad to help maintaining xml-conduit, if you feel it is needed.

@snoyberg

This comment has been minimized.

Copy link
Owner

snoyberg commented May 11, 2015

I mostly just don't want to become a roadblock to you making improvements to this library :) If you tell me your Hackage username, I'll add you to the maintainer group.

@k0ral

This comment has been minimized.

Copy link
Collaborator Author

k0ral commented May 11, 2015

My Hackage username is koral. Thank you :)

@snoyberg

This comment has been minimized.

Copy link
Owner

snoyberg commented May 11, 2015

Cool, done.

On Mon, May 11, 2015 at 1:36 PM k0ral notifications@github.com wrote:

My Hackage username is koral. Thank you :)


Reply to this email directly or view it on GitHub
#52 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.