New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AngularJS example to work with Yesod 1.2. #2

Merged
merged 1 commit into from Jun 24, 2014

Conversation

Projects
None yet
2 participants
@creichert
Contributor

creichert commented Jun 23, 2014

Hi Michael,

This example has been incredibly helpful while integrating Yesod and Angular. Because this example is a bit outdated, I decided to have a go at updating the modules. There are still a few minor issues but this could really help anyone who lands here from (or anywhere else): http://www.yesodweb.com/blog/2012/10/yesod-fay-js.

Notes:

  • I added the cabal file because I did not have time to update the parent.
  • Using runhaskell or adding explicit bounds to the transformers package results in a "no instance for MonadTrans" error regarding the lift function being used on AngularT (WriterT). This error goes away with an unbounded dependency on transformers in the cabal file. I'm looking further into this issue, any ideas?
  • Hardcoding of the angular-route.min.js remote script. Looking for a way to handle this in urlAngularJs_.

Nonetheless, I think an update could be very useful for those trying to use Angular with Yesod.

Thanks for all your work!

snoyberg added a commit that referenced this pull request Jun 24, 2014

Merge pull request #2 from creichert/master
Update AngularJS example to work with Yesod 1.2.

@snoyberg snoyberg merged commit 939d980 into snoyberg:master Jun 24, 2014

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Jun 24, 2014

Owner

Thanks!

Owner

snoyberg commented Jun 24, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment