From ab97981c2ae1184d881ab18bcaa8a56990b7ca72 Mon Sep 17 00:00:00 2001
From: Nathan Moinvaziri <nathan@nathanm.com>
Date: Fri, 29 Dec 2023 09:37:39 -0800
Subject: [PATCH] Fixed MinidumpTest.TestMinidumpFromStream opening minidump on
 Windows.

Minidump file needs to be opened as binary.
---
 src/processor/minidump_unittest.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/processor/minidump_unittest.cc b/src/processor/minidump_unittest.cc
index 719adf78a..c34ccd4d8 100644
--- a/src/processor/minidump_unittest.cc
+++ b/src/processor/minidump_unittest.cc
@@ -111,7 +111,7 @@ TEST_F(MinidumpTest, TestMinidumpFromFile) {
 
 TEST_F(MinidumpTest, TestMinidumpFromStream) {
   // read minidump contents into memory, construct a stringstream around them
-  ifstream file_stream(minidump_file_.c_str(), std::ios::in);
+  ifstream file_stream(minidump_file_.c_str(), std::ios::in | std::ios::binary);
   ASSERT_TRUE(file_stream.good());
   vector<char> bytes;
   file_stream.seekg(0, std::ios_base::end);