Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: travis: bionic #13

Open
wants to merge 1 commit into
base: master
from

Conversation

@FauxFaux
Copy link
Contributor

commented Oct 3, 2019

Upgrade to a newer Travis base image.

@FauxFaux FauxFaux requested a review from snyk/comet as a code owner Oct 3, 2019
@pavel-github

This comment has been minimized.

Copy link
Collaborator

commented Oct 3, 2019

@FauxFaux, travis java switcher doesn't work on new ubuntu images (that's why we use trusty). https://travis-ci.community/t/install-of-oracle-jdk-8-failing/3038/9

And this is the line from our build: https://travis-ci.com/snyk/artifactory-snyk-security-plugin/builds/130251979#L170

@pavel-github pavel-github self-assigned this Oct 3, 2019
@FauxFaux

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

I fixed this in java-runtime-agent by using the packaged version of Java, which does just work:
snyk/java-runtime-agent@f3ae174#diff-354f30a63fb0907d4ad57269548329e3

It's complicated there because of deploys.

@FauxFaux FauxFaux force-pushed the chore/travis-tweaks branch from f752137 to 20fb1c6 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.