Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What does this PR do?
Introduces support for
$SOURCE_DATE_EPOCHto make the timestamps contained in the signal-desktop package distributed by Arch Linux deterministic, resolves #1536.Where should the reviewer start?
Ensure
src/lib/protect/datetime.jslooks reasonable, afterwards verify the changes insrc/lib/protect/patch.jsandsrc/lib/protect/write-patch-flag.jsthat simply swapnew Date()withdatetime().How should this be manually tested?
export SOURCE_DATE_EPOCH=0and verify thesnyk-*.flagfiles generated by snyk protect contain a datetime in1970-01-01instead of the current date. Afterwardsunset SOURCE_DATE_EPOCH, deletenode_modules/and ensure the regular behavior didn't change.Any background context you want to provide?
Further reading (if necessary):
https://reproducible-builds.org/docs/source-date-epoch/
https://reproducible-builds.org/docs/timestamps/
https://github.com/bmwiedemann/theunreproduciblepackage/tree/master/timestamp
What are the relevant tickets?
#1536