Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support SOURCE_DATE_EPOCH #1537

Closed
wants to merge 1 commit into from
Closed

Conversation

kpcyrd
Copy link

@kpcyrd kpcyrd commented Nov 20, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Introduces support for $SOURCE_DATE_EPOCH to make the timestamps contained in the signal-desktop package distributed by Arch Linux deterministic, resolves #1536.

Where should the reviewer start?

Ensure src/lib/protect/datetime.js looks reasonable, afterwards verify the changes in src/lib/protect/patch.js and src/lib/protect/write-patch-flag.js that simply swap new Date() with datetime().

How should this be manually tested?

export SOURCE_DATE_EPOCH=0 and verify the snyk-*.flag files generated by snyk protect contain a datetime in 1970-01-01 instead of the current date. Afterwards unset SOURCE_DATE_EPOCH, delete node_modules/ and ensure the regular behavior didn't change.

Any background context you want to provide?

Further reading (if necessary):
https://reproducible-builds.org/docs/source-date-epoch/
https://reproducible-builds.org/docs/timestamps/
https://github.com/bmwiedemann/theunreproduciblepackage/tree/master/timestamp

What are the relevant tickets?

#1536

@kpcyrd kpcyrd requested review from a team as code owners November 20, 2020 18:37
@ghost ghost requested review from admons and ekbsnyk November 20, 2020 18:37
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kpcyrd
Copy link
Author

kpcyrd commented Dec 13, 2020

hey! anything I can do here?

@admons admons removed their request for review April 28, 2021 06:20
@aviadhahami aviadhahami removed the request for review from a team June 14, 2021 10:54
@ghost
Copy link

ghost commented Apr 11, 2022

Looks like this is no longer an issue for Signal Desktop as they've removed snyk protect from their build process. I'll close this PR. Feel free to report any new issues to https://support.snyk.io.

@ghost ghost closed this Apr 11, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] Reproducible builds issues due to .snyk-npm-debug-20170905.flag
2 participants