Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove reachability from plugins #4116

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

magdziarek
Copy link

What does this PR do?

Bumps versions of snyk-gradle-plugin and snyk-mvn-plugin

Snyk CLI has removed --reachable. See #3588
so we are removing reachability and call-graph code in plugins. Relevant PRs:
snyk/snyk-mvn-plugin#138
snyk/snyk-gradle-plugin#236

@github-actions
Copy link
Contributor

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/cli/args.ts
  • webpack.common.ts
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against cdebec7

Copy link
Contributor

@e102 e102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from an @snyk/apollo perspective assuming these plugins aren't used elsewhere

@magdziarek magdziarek merged commit bf1d59d into master Oct 10, 2022
@magdziarek magdziarek deleted the fix/remove-reachability branch October 10, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants