Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate support of NODE_EXTRA_CA_CERTS #4249

merged 1 commit into from Dec 20, 2022


Copy link

@PeterSchafer PeterSchafer commented Dec 15, 2022

What does this PR do?

If a user specifies additional root CAs via the environment variable NODE_EXTRA_CA_CERTS, they get added to the internal Certificate Pool and forwarded to child processes.

Also Golang is updated to 1.19.4 for building and throughout the CI pipeline.

Where should the reviewer start?

  • main.go
  • proxy.go

How should this be manually tested?

Run and look at "test/jest/acceptance/extra-certs.spec.ts"

Any background context you want to provide?

The Golang CLI uses NODE_EXTRA_CA_CERTS itself to set temporary certificates for child processes. If there are user defined certificates they need to be merged.

@PeterSchafer PeterSchafer requested a review from a team as a code owner December 15, 2022 18:49
@PeterSchafer PeterSchafer force-pushed the fix/HMMR-610_extra_cert branch 3 times, most recently from ed40344 to 792999c Compare December 15, 2022 19:47
@PeterSchafer PeterSchafer requested a review from a team as a code owner December 15, 2022 19:47
@PeterSchafer PeterSchafer force-pushed the fix/HMMR-610_extra_cert branch 9 times, most recently from 704e06a to e5c3640 Compare December 16, 2022 11:39
cliv2/cmd/cliv2/main.go Outdated Show resolved Hide resolved
* forwarding externally defined NODE_EXTRA_CA_CERTS
* internally using NODE_EXTRA_CA_CERTS

Signed-off-by: Peter Schäfer <>
@PeterSchafer PeterSchafer merged commit 6846be1 into master Dec 20, 2022
12 checks passed
@PeterSchafer PeterSchafer deleted the fix/HMMR-610_extra_cert branch December 20, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants