Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge internal and external (user defined) no_proxy #4263

Merged
merged 1 commit into from Dec 29, 2022

Conversation

PeterSchafer
Copy link
Contributor

What does this PR do?

  • merging internal and external defined no_proxy environment variables ensures that externally specified settings are preserved internally.
  • Update snyk-docker-plugin that supports restoring system proxy settings

Where should the reviewer start?

internal/cliv2/cliv2.go

How should this be manually tested?

  • Specify NO_PROXY=localhost,googleapis.com,somethingelse
  • Run the clli with -d, check the new logging that should contain the user defined as well as internal no_proxy settings
    2022/12/28 15:52:31.349900 legacycli:1 - NO_PROXY = localhost,127.0.0.1,::1,googleapis.com,somethingelse

Any background context you want to provide?

For example when running remote docker in circleci, the external NO_PROXY configuration ensures that no traffic is being routed through any proxy.

@PeterSchafer PeterSchafer requested a review from a team as a code owner December 28, 2022 19:00
* improve logging
* cleanup unused utils
* update application framework
* update snyk-docker-plugin
@PeterSchafer PeterSchafer force-pushed the fix/HMMR-627_restore_system_proxy branch from 6d15163 to e92b1ae Compare December 29, 2022 12:29
@PeterSchafer PeterSchafer merged commit e929b03 into master Dec 29, 2022
12 checks passed
@PeterSchafer PeterSchafer deleted the fix/HMMR-627_restore_system_proxy branch December 29, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants