Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codeowners -> boost #10

Open
wants to merge 1 commit into
base: master
from

Conversation

@FauxFaux
Copy link

commented Oct 2, 2019

Ecosystem file parsers are all owned by Boost.

@FauxFaux FauxFaux requested a review from snyk/boost Oct 2, 2019
@pull-assigner pull-assigner bot requested review from gitphill and orsagie Oct 2, 2019
@lili2311

This comment has been minimized.

Copy link

commented Oct 2, 2019

@FauxFaux please sign CLA and whats up with the tests?

@FauxFaux

This comment has been minimized.

Copy link
Author

commented Oct 2, 2019

Prodding CLA, not sure what it's angry about.

@FauxFaux FauxFaux closed this Oct 2, 2019
@FauxFaux FauxFaux reopened this Oct 2, 2019
@CLAassistant

This comment has been minimized.

Copy link

commented Oct 2, 2019

CLA assistant check
All committers have signed the CLA.

@FauxFaux

This comment has been minimized.

Copy link
Author

commented Oct 2, 2019

The tests look to be hanging on node 6, on both platforms, and/or triggering a node internal assert.

We still need to support node 6 for this, right?

I guess one of the test dependencies is weird, maybe sync-request. I'll see if I can reproduce it locally.

@FauxFaux

This comment has been minimized.

Copy link
Author

commented Oct 2, 2019

The tests should be resolved by: #11

@lwywoo
lwywoo approved these changes Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.