Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: eliminate sync-request, which is node >=8 #11

Open
wants to merge 1 commit into
base: master
from

Conversation

@FauxFaux
Copy link

commented Oct 2, 2019

What does this PR do?

Eliminate sync-request, which is documented to not work on node below 8 (for us it hangs, or crashes), by replacing it with node-fetch. This fixes the tests on node 6.

@FauxFaux FauxFaux requested a review from snyk/boost Oct 2, 2019
@pull-assigner pull-assigner bot requested review from gitphill and lwywoo Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.