Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add debug logging around child process #125

Merged
merged 1 commit into from
May 5, 2022

Conversation

Jdunsby
Copy link
Contributor

@Jdunsby Jdunsby commented May 5, 2022

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Adds debug logging for error and exit events emitted by the sub-process

Any background context you want to provide?

This will hopefully help with support tickets

What are the relevant tickets?

TARDIS-808

@Jdunsby Jdunsby requested a review from a team as a code owner May 5, 2022 10:52
@Jdunsby Jdunsby requested review from jk05 and mika-bar May 5, 2022 10:52
@gitphill
Copy link
Contributor

gitphill commented May 5, 2022

looks like we have some tests to update

@Jdunsby Jdunsby force-pushed the feat/additional-debug-logging branch from a1c86b5 to 7d4e7d2 Compare May 5, 2022 12:49
@Jdunsby Jdunsby force-pushed the feat/additional-debug-logging branch from 7d4e7d2 to 351d0bb Compare May 5, 2022 13:00
@Jdunsby Jdunsby merged commit f2c9569 into master May 5, 2022
@Jdunsby Jdunsby deleted the feat/additional-debug-logging branch May 5, 2022 13:29
@snyksec
Copy link

snyksec commented May 5, 2022

🎉 This PR is included in version 2.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants