feat: init support mvn -D verbose support #164
Conversation
anthogez
force-pushed
the
tests/introducing-jest-suite
branch
from
8d27ac6
to
0809635
Compare
anthogez
changed the title
anthogez
force-pushed
the
tests/introducing-jest-suite
branch
6 times, most recently
from
8ad43b0
to
bcbf2d4
Compare
orsagie
force-pushed
the
tests/introducing-jest-suite
branch
2 times, most recently
from
c390e5f
to
e7accac
Compare
anthogez
force-pushed
the
tests/introducing-jest-suite
branch
from
830c4c4
to
cae7438
Compare
anthogez
force-pushed
the
tests/introducing-jest-suite
branch
2 times, most recently
from
181c0c2
to
4cf2286
Compare
anthogez
force-pushed
the
tests/introducing-jest-suite
branch
4 times, most recently
from
9644170
to
5c1858a
Compare
anthogez
force-pushed
the
tests/introducing-jest-suite
branch
from
5c1858a
to
289b5f0
Compare
lib/index.ts
Outdated
| @@ -179,7 +179,10 @@ export async function inspect( | |||
| cwd: mvnWorkingDirectory, | |||
| }, | |||
| ); | |||
| const parseResult = parse(result, options.dev); | |||
|
|
|||
| const includesVerboseFlag = mvnArgs.includes('-Dverbose'); | |||
There was a problem hiding this comment.
not very likely, but what if the command is -Dverbose=false, which is a user trying to disable verbose
There was a problem hiding this comment.
this is a good one, we will make sure of double check that -Dverbose will be false 👍
There was a problem hiding this comment.
I wasn't expecting us to reimplement so much. Can we not use -Dverbose with -DoutputType=dot?
There was a problem hiding this comment.
Not in all versions of the plugin, for this reason we have introduced this change, even though our preference is always -DoutputType=dot
| return parseDependency(line); | ||
| } | ||
|
|
||
| private computeDepth(line: string): number { |
There was a problem hiding this comment.
is this reliable? i think it may break depending what terminal you're running - it's the reason we use dot output
There was a problem hiding this comment.
we have overly stressed this, as I said it's an incremental change for cases where mvn plugin does not support -Doutputype=dot with -DVerbose
| return { | ||
| plugin: { | ||
| name: 'bundled:maven', | ||
| runtime: 'unknown', | ||
| meta: { | ||
| versionBuildInfo: { | ||
| metaBuildVersion: { | ||
| mavenVersion, | ||
| mavenFullVersion, |
There was a problem hiding this comment.
change to mavenVersion: mavenFullVersion
Co-authored-by: Or Sagie or@snyk.io With this pull request if an user asks for -Dverbose arg that invalidates -DoutputType=dot We will still digest the mvn cli output despite no longer having a digraph DOT format but a mvn tree. We generate depGraph/s for single and/or aggregate projects.
orsagie
force-pushed
the
tests/introducing-jest-suite
branch
from
9372b43
to
ee6264d
Compare
Co-authored-by: Or Sagie or@snyk.io
With this pull request if an user asks for -Dverbose arg that invalidates -DoutputType=dot
We will still digest the mvn cli output despite no longer having a digraph DOT format but a mvn tree.
We generate depGraph/s for single and/or aggregate projects.