Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make generic Maven error message more useful #88

Closed
wants to merge 1 commit into from

Conversation

darscan
Copy link
Contributor

@darscan darscan commented Sep 11, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • Specifying the minimum Maven Dependency Plugin version was confusing and not very useful, so
  • Specify the minimum Maven version instead

Additional info

Maven 3.0.4, are you sure?

No. I did my best using:

- Specifying the minimum Maven Dependency Plugin version was confusing
  and not very useful, so
- Specify the minimum Maven version instead
@darscan darscan requested a review from a team as a code owner September 11, 2020 19:11
@ghost ghost requested review from anthogez and orsagie September 11, 2020 19:11
Copy link
Contributor

@aviadhahami aviadhahami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@anthogez
Copy link
Member

cc @snyk/tardis merging/closing this one?

@darscan
Copy link
Contributor Author

darscan commented Jul 15, 2021

Not accepted, so closing. Feel free to revive/take over

@darscan darscan closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants