feat: support arr unmanaged file #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
aviadhahami
reviewed
Sep 14, 2020
| @@ -103,7 +103,7 @@ export async function createPomForJars(root: string): Promise<string> { | |||
| } | |||
|
|
|||
| export function isJar(file: string): boolean { | |||
| return !!file.match(/\.(([jw]ar)|(zip))$/); | |||
| return !!file.match(/\.(([jwa]ar)|(zip))$/); | |||
There was a problem hiding this comment.
we should start splitting this to isValidFile or so
aviadhahami
approved these changes
Sep 14, 2020
orsagie
force-pushed
the
spike/support-arr-files
branch
from
54078d3
to
cb427d4
Compare
orsagie
force-pushed
the
spike/support-arr-files
branch
from
cb427d4
to
42de521
Compare
|
🎉 This PR is included in version 2.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for .aar files.