Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple "package file" types in a single run #142

Closed
jessehouwing opened this issue Mar 30, 2018 · 27 comments
Closed

Support multiple "package file" types in a single run #142

jessehouwing opened this issue Mar 30, 2018 · 27 comments

Comments

@jessehouwing
Copy link
Contributor

@jessehouwing jessehouwing commented Mar 30, 2018

In .NET projects it's common to have both a packages.config and a project.json. It would be nice if we could specify multiple "files to scan" when running snyk or snyk automatically detecting all applicable files in the current directory.

These two dependency files are generally used to:

  • Bring in front-end javascript dependencies through npm
  • Bring in back-end and rendering extensions to ASP.NET MVC through NuGet
@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Mar 30, 2018

I'd love to be able to pass Snyk a (list of) project files using a glob. Or even a list of full paths and then I can do the globbing myself. Being able to pass in a Visual Studio Solution file would also work ;).

Then have them all be tested, monitored in a single run. That way I can test a complete Visual Studio solution, which, in the end, delivers a single packaged application.

It makes more sense to be able to monitor the whole, instead of each individual sub-project.

@adrukh
Copy link
Member

@adrukh adrukh commented Mar 30, 2018

@jessehouwing 👋

With our .NET support released in December 2017 we made some decisions and improvements on our CLI. Namely:

  • Solution scanning & snapshotting is available with snyk test --file=Solution.sln or snyk monitor --file=Solution.sln. This runs a separate test for each project path mentioned in the solution file.
  • Better support for multiple paths scanning in one go: snyk test path1 path2 path3, where pathN is a path to a project folder (not a manifest file). Each path's manifest file will be auto-detected (doesn't have to be the same across all paths).
  • To force the CLI to a specific manifest file in all paths: snyk test --file=packages.config path1 path2 path3
  • What we still don't have is the ability to test explicit different manifest files in a single command. Not seeing a reason not to support this, but cannot promise a specific timeline yet.

Hope this helps, let me know how you get along!

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Mar 30, 2018

@adrukh
Copy link
Member

@adrukh adrukh commented Mar 30, 2018

I'd be forever grateful if you could suggest a PR to our CLI help - https://github.com/snyk/snyk/tree/master/help

🙏

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented May 6, 2019

I've built this functionality for the azure pipeline task: https://github.com/jessehouwing/azure-pipelines-snyk-task/tree/features/multi

@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 7, 2020

@jessehouwing we have just released in Beta 🎏 a new feature that allows to auto detect and scan multiple project & project types, it is available from version 1.275.0 and help text can be found here: https://github.com/snyk/snyk/pull/945/files.

It at the moment support npm, yarn, rubygems, maven and .Net is being released next. Please give it a try and share any feedback you may have. snyk test --all-projects --detection-level=2 for example to look 2 directories deep (current and 1 more). Both test & monitor are supported.

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 7, 2020

Does that auto-exclude node_modules folders and such? Otherwise the average .NET solution is probably going to cause issues when I need to set the detection-level too deep... For me only npm|yarn+.NET is something I'd be able to test. I'll keep an eye out on the upcoming support.

@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 8, 2020

It auto excludes node_modules indeed, what other folders do you think we should auto exclude? We will also shortly be releasing an options to allow users to provide an exclusion list on top of the auto excluded ones.

@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 14, 2020

@jessehouwing .Net support v1 is now out too https://github.com/snyk/snyk/releases/tag/v1.278.0 please give this a try and share any feedback you have :)

@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 14, 2020

@jessehouwing please confirm if this issue can now be closed and the feature above meets your needs?

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 14, 2020

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 15, 2020

I tried and ran into a few issues.

Due to the project structure, I need to set the depth quite deep to have it detect everything from the project root. Our project creates a dist folder in a weird place and copies the lock files along, this seems to cause issues:

C:\Users\JesseHouwing\source\repos\PartsUnlimited>snyk test --all-projects --detection-depth=5
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyz

Removing our dist and bower_components folders fixes the issues. It seems that bower_components might be a candidate for a default exclude. The ability to exclude from the snyk policy file may make sense here. Some sort of snykIgnore ;).

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 15, 2020

It looks like --file=path\to\solution.sln won't pick up the Dotnet Core dependecies nor issue a warning in this case either.

@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 17, 2020

@jessehouwing could you please share an example of the manifest with declared dependencies for Dotnet Core?

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 17, 2020

If you need a higher fidelity way to chat, I'm available on Teams, Slack, Skype, Zoom, Hangouts, you name it.

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 17, 2020

The solution has 2 custom nuget packages, added those too should you need them.

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 19, 2020

PS: It would be handy if this error would tell which directory it was expecting packages to be restored in.

Error: Missing node_modules folder: we can't test without dependencies.
@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 22, 2020

👋 @jessehouwing ignores has now been also released https://github.com/snyk/snyk/releases/tag/v1.279.0

Missing node_modules folder is an error but it should not stop the test from continuing, you can use the new ignore param to skip some problematic folders.

Would love to arrange a chat with you regarding the .Net support for .Net core, please could you ping your email to support@snyk.io and mention this issue and myself and I will be in touch :)

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 22, 2020

Woot. Will have a go. Teaching the rest of next week, to it may take a little to truly play with it.

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 23, 2020

This seems to work! We need to exclude bower_components to get rid of all the log spam:

C:\Users\JesseHouwing\source\repos\PartsUnlimited>snyk test --all-projects --detection-depth=5 --exclude=bower_components
C:\Users\JesseHouwing\source\repos\PartsUnlimited>snyk test --all-projects --detection-depth=5
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
Error: Missing node_modules folder: we can't test without dependencies.
Please run 'npm install' first.
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\npm-modules-parser.ts:22:11)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:4:12)
    at Object.parse (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\npm-modules-parser.js:18:12)
    at Object.<anonymous> (C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\src\lib\plugins\nodejs-plugin\index.ts:22:27)
    at Generator.next (<anonymous>)
    at C:\Users\JesseHouwing\AppData\Roaming\npm\node_modules\snyk\dist\lib\plugins\nodejs-plugin\index.js:8:71
    at new Promise (<anonymous>)
- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc| Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc/ Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc- Analyzing npm dependencies for C:\Users\JesseHouwing\source\repos\PartsUnlimited\src\PartsUnlimitedWebsite\package-loc\ Analyzing npm dependencies for C:\Users\JesseHouwing\sourc
@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 24, 2020

Thanks @jessehouwing for testing this, can I close this issue now?

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 24, 2020

Should I file a new issue for the logspam?

@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 31, 2020

@jessehouwing what is your expected behaviour here if some projects fail? (New ticket is good yep :))

@jessehouwing
Copy link
Contributor Author

@jessehouwing jessehouwing commented Jan 31, 2020

Fail = Fail. Haven't looked at a parsable return value, but streaming json to the output stream would make it easier to act in whichever way we want.

@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 31, 2020

@jessehouwing you can pass --json to get a nicer output here. Do you mean the resulting exit code is not what you expect?

@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Feb 10, 2020

Closing this, thanks I saw the new issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants