New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust charsets when shelling out #20

Merged
merged 2 commits into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@alexarchambault
Contributor

alexarchambault commented Nov 29, 2018

This PR makes the powershell command emit utf-8 on Windows. This fixes #19 in my tests.

This also makes explicit the use of the default charset when reading the output of the xdg-user-dir command (not sure how to force it to emit utf-8…)

@alexarchambault alexarchambault force-pushed the alexarchambault:topic/tweak-powershell-encoding branch from a266ab0 to 7b3678a Nov 29, 2018

alexarchambault added a commit to coursier/coursier that referenced this pull request Nov 30, 2018

alexarchambault added a commit to coursier/coursier that referenced this pull request Nov 30, 2018

Update src/main/java/io/github/soc/directories/Util.java
Co-Authored-By: alexarchambault <alexarchambault@users.noreply.github.com>
@alexarchambault

This comment has been minimized.

Contributor

alexarchambault commented Dec 6, 2018

Fixed… FYI, I know require Java >= 8 from coursier (in the 1.1.x versions). So it's even for me if directories-jvm drops Java 6 support.

@soc

soc approved these changes Dec 6, 2018

@soc soc merged commit b6468f3 into soc:master Dec 6, 2018

@alexarchambault alexarchambault deleted the alexarchambault:topic/tweak-powershell-encoding branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment