Test support on Scala.js #21

Closed
soc opened this Issue May 3, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@soc
Owner

soc commented May 3, 2016

Tests currently depend the TestNG testing framework, which doesn't exist on Scala.js.

Either replace it with something supported on Scala.js or implement enough parts of TestNG in Scala to be able to run the tests on Scala.js.

@soc

This comment has been minimized.

Show comment
Hide comment
@soc

soc Jul 9, 2016

Owner

Replacing TestNG tests with e. g. JUnit tests is pretty straight forward and has low overhead, but TestNG's @DataProvider annotation is a real pain as no other Scala.js-supported testing framework has remotely the same API.

I see roughly two options:

  • Create an extension for Junit (or some other Scala.js-supported testing framework) that understands these TestNG annotations
  • Rewrite all usages of TestNG's @DataProvider
Owner

soc commented Jul 9, 2016

Replacing TestNG tests with e. g. JUnit tests is pretty straight forward and has low overhead, but TestNG's @DataProvider annotation is a real pain as no other Scala.js-supported testing framework has remotely the same API.

I see roughly two options:

  • Create an extension for Junit (or some other Scala.js-supported testing framework) that understands these TestNG annotations
  • Rewrite all usages of TestNG's @DataProvider
@soc

This comment has been minimized.

Show comment
Hide comment
@soc

soc Jul 18, 2016

Owner

I decided to implement a ScalaJSTestNGPlugin instead: scala-js/scala-js#2535

Owner

soc commented Jul 18, 2016

I decided to implement a ScalaJSTestNGPlugin instead: scala-js/scala-js#2535

@soc

This comment has been minimized.

Show comment
Hide comment
@soc

soc Jul 19, 2016

Owner

After the TestNG plugin is available, we can have a look at adapting the build system and changing the tests to drop the TestNGSuite dependency on ScalaTest again: https://github.com/soc/scala-java-time/tree/topic/testng-conversion

Owner

soc commented Jul 19, 2016

After the TestNG plugin is available, we can have a look at adapting the build system and changing the tests to drop the TestNGSuite dependency on ScalaTest again: https://github.com/soc/scala-java-time/tree/topic/testng-conversion

@antonkulaga

This comment has been minimized.

Show comment
Hide comment
@antonkulaga

antonkulaga Aug 26, 2016

What I can say right now it that it crashes on Scalajs even with simple LocalDateTime.now

What I can say right now it that it crashes on Scalajs even with simple LocalDateTime.now

@soc

This comment has been minimized.

Show comment
Hide comment
@soc

soc Aug 26, 2016

Owner

What crashes?

Owner

soc commented Aug 26, 2016

What crashes?

@antonkulaga

This comment has been minimized.

Show comment
Hide comment
@antonkulaga

antonkulaga Aug 26, 2016

My scalajs app whenever I have simple LocalDateTime.now call there. Somethins is wrong with org.threeten.bp.ZoneId$.systemDefault there but I have not idea what exactly

antonkulaga commented Aug 26, 2016

My scalajs app whenever I have simple LocalDateTime.now call there. Somethins is wrong with org.threeten.bp.ZoneId$.systemDefault there but I have not idea what exactly

@soc

This comment has been minimized.

Show comment
Hide comment
@soc

soc Aug 28, 2016

Owner

Well, yes. As mentioned in the readme timezone support hasn't been implemented yet.

Owner

soc commented Aug 28, 2016

Well, yes. As mentioned in the readme timezone support hasn't been implemented yet.

@soc

This comment has been minimized.

Show comment
Hide comment
@soc

soc Jul 30, 2017

Owner

This project is discontinued.

Owner

soc commented Jul 30, 2017

This project is discontinued.

@soc soc closed this Jul 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment