Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add implementation of Anssi Nurminen's table detection algorithm #206

Merged
merged 13 commits into from Nov 23, 2018

Conversation

Projects
None yet
2 participants
@vinayak-mehta
Copy link
Collaborator

commented Nov 22, 2018

Closes #102.

  • Add implementation
  • Update tests
  • Fix comments
  • Add docstrings
  • Update docs

Paper: http://dspace.cc.tut.fi/dpub/bitstream/handle/123456789/21520/Nurminen.pdf?sequence=3

@vinayak-mehta vinayak-mehta changed the title Add an implementation of Anssi Nurminen's table detection algorithm [WIP] Add an implementation of Anssi Nurminen's table detection algorithm Nov 22, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Nov 22, 2018

Codecov Report

Merging #206 into master will increase coverage by 0.58%.
The diff coverage is 92.74%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #206      +/-   ##
=========================================
+ Coverage   87.32%   87.9%   +0.58%     
=========================================
  Files          13      13              
  Lines        1254    1372     +118     
  Branches      297     324      +27     
=========================================
+ Hits         1095    1206     +111     
- Misses        109     113       +4     
- Partials       50      53       +3
Impacted Files Coverage Δ
camelot/__version__.py 76.47% <63.63%> (-23.53%) ⬇️
camelot/parsers/stream.py 91.97% <75%> (-0.6%) ⬇️
camelot/core.py 93.65% <98.96%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3aa38...23ec6b5. Read the comment docs.

vinayak-mehta added some commits Nov 22, 2018

@vinayak-mehta vinayak-mehta changed the title [WIP] Add an implementation of Anssi Nurminen's table detection algorithm [WIP] Add implementation of Anssi Nurminen's table detection algorithm Nov 22, 2018

@vinayak-mehta vinayak-mehta changed the title [WIP] Add implementation of Anssi Nurminen's table detection algorithm [MRG] Add implementation of Anssi Nurminen's table detection algorithm Nov 23, 2018

@vinayak-mehta vinayak-mehta merged commit e7835ca into master Nov 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@vinayak-mehta vinayak-mehta deleted the stream-nurminen-detection branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.