Build fragment without args #32

Closed
bryant1410 opened this Issue Sep 16, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@bryant1410
Contributor

bryant1410 commented Sep 16, 2015

In order to build all the fragments in the same way, I think it would be nice if they can be built when they have no arguments, which I see is not working. The workaround I find is to use @FragmentArgsInherited, but the name is not the best. Maybe call it @FragmentArgs, with an optional boolean attribute inhereted

@sockeqwe

This comment has been minimized.

Show comment
Hide comment
@sockeqwe

sockeqwe Sep 16, 2015

Owner

whats the benefit of having a builder without arguments at all? why not simply use new MyFragment() directly instead of new MyFragmentBuilder().build()

Owner

sockeqwe commented Sep 16, 2015

whats the benefit of having a builder without arguments at all? why not simply use new MyFragment() directly instead of new MyFragmentBuilder().build()

@bryant1410

This comment has been minimized.

Show comment
Hide comment
@bryant1410

bryant1410 Sep 16, 2015

Contributor

As I said, to treat all the fragments the same way. So, if there is a change, the impact is minimum

Contributor

bryant1410 commented Sep 16, 2015

As I said, to treat all the fragments the same way. So, if there is a change, the impact is minimum

@sockeqwe

This comment has been minimized.

Show comment
Hide comment
@sockeqwe

sockeqwe Sep 17, 2015

Owner

Agree, it wouldn't hurt to add this with the next release (first week of october)

Owner

sockeqwe commented Sep 17, 2015

Agree, it wouldn't hurt to add this with the next release (first week of october)

@sockeqwe sockeqwe self-assigned this Sep 17, 2015

@bryant1410

This comment has been minimized.

Show comment
Hide comment
@bryant1410

bryant1410 Sep 17, 2015

Contributor

👍 😃

Contributor

bryant1410 commented Sep 17, 2015

👍 😃

@bryant1410

This comment has been minimized.

Show comment
Hide comment
@bryant1410

bryant1410 Sep 17, 2015

Contributor

As I originally said, IMO the best way would be to rename FragmentArgsInherited to FragmentArgs and add the optional boolean flag inherit. However, it would obviously break compatibility.

Contributor

bryant1410 commented Sep 17, 2015

As I originally said, IMO the best way would be to rename FragmentArgsInherited to FragmentArgs and add the optional boolean flag inherit. However, it would obviously break compatibility.

@sockeqwe

This comment has been minimized.

Show comment
Hide comment
@sockeqwe

sockeqwe Sep 17, 2015

Owner

yes, I will mark @FragmentArgsInherited as deprecated and will introduce a new one @FragmentArgs. By keeping both I should be able to keep backward compatibility

Owner

sockeqwe commented Sep 17, 2015

yes, I will mark @FragmentArgsInherited as deprecated and will introduce a new one @FragmentArgs. By keeping both I should be able to keep backward compatibility

@bryant1410

This comment has been minimized.

Show comment
Hide comment
@bryant1410

bryant1410 Sep 17, 2015

Contributor

Sounds good

Contributor

bryant1410 commented Sep 17, 2015

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment