Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for flashsocket #232

Closed
rauchg opened this issue Jan 17, 2014 · 8 comments
Closed

Add test for flashsocket #232

rauchg opened this issue Jan 17, 2014 · 8 comments

Comments

@rauchg
Copy link
Contributor

@rauchg rauchg commented Jan 17, 2014

No description provided.

@defunctzombie
Copy link
Contributor

@defunctzombie defunctzombie commented Feb 8, 2014

Correction.. make flashsocket work /cc @nullbox

@defunctzombie
Copy link
Contributor

@defunctzombie defunctzombie commented Feb 9, 2014

http://www.lightsphere.com/dev/articles/flash_socket_policy.html

All socket requests MUST have an xmlsocket server serve the policy file. This will present issues when the engine.io server is behind a firewall or other proxy server because the xmlsocket requests are NOT http requests and thus will be dropped.

@mokesmokes
Copy link
Contributor

@mokesmokes mokesmokes commented Feb 15, 2014

As a side note: do people really want to use flashsockets?

@rauchg
Copy link
Contributor Author

@rauchg rauchg commented Feb 15, 2014

IE6-9 are in aggregate a sizable % of share. So yes.

Also judging by the number of filed issues we get relating to them.

@rauchg
Copy link
Contributor Author

@rauchg rauchg commented Feb 15, 2014

But I think we should move it into a plugin engine.io-flash that way we support less and keep file size down

@mokesmokes
Copy link
Contributor

@mokesmokes mokesmokes commented Feb 15, 2014

Re IE6-9: just my thinking is that if Angular.js is dropping IE8 support (http://blog.angularjs.org/2013/12/angularjs-13-new-release-approaches.html), Google Apps discontinuing IE9 (http://thenextweb.com/google/2013/11/05/google-drops-internet-explorer-9-support-google-apps-less-three-weeks-ie11s-release/#!vRW1Y) then I'm not sure that engine.io should be optimizing performance for these old browsers. Just my 2 cents :)

@defunctzombie
Copy link
Contributor

@defunctzombie defunctzombie commented Apr 30, 2014

@nullbox did you get anywhere with this?

@rase-
Copy link
Contributor

@rase- rase- commented May 24, 2014

If we are moving flashsockets to the user land, we could close this.

@rauchg rauchg closed this May 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants