Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Polling transport makes aggressive abort() calls in Node #318

Closed
samcday opened this Issue · 1 comment

2 participants

@samcday

Line 267 of latest engine.io-client polling-xhr.js does this in cleanup:

  try {
    this.xhr.abort();
  } catch(e) {}

Calling XMLHttpRequest.abort delegates to ClientRequest.abort in Node environments, which results in the connection being forcibly closed. That would make sense in an error scenario perhaps, but cleanup() is also called even after a successful polling request.

This means that using engine.io-client in Node environments results in every polling request closing the connection, regardless of whether the connection was keep-alive or not.

@rase-
Collaborator

#319 merged

@rase- rase- closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.