Don't check against the window to detect node.js, wrap code in a try cat... #148

Merged
merged 1 commit into from Mar 27, 2013

Conversation

Projects
None yet
2 participants
Contributor

3rd-Eden commented Mar 26, 2013

Don't check against the window to detect node.js, wrap code in a try catch statement and have it degrade gracefully like the rest of the code.

Fixes #147

Don't check against the window to detect node.js, wrap code in a try …
…catch statement

and have it degrade gracefully.

Fixes #147
Contributor

rauchg commented Mar 27, 2013

Excellent. Do we have other instances where it would make sense to have a similar approach?

rauchg added a commit that referenced this pull request Mar 27, 2013

Merge pull request #148 from 3rd-Eden/better-node-xhr
Don't check against the window to detect node.js, wrap code in a try cat...

@rauchg rauchg merged commit b5c982c into socketio:master Mar 27, 2013

@3rd-Eden 3rd-Eden deleted the 3rd-Eden:better-node-xhr branch Mar 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment