Only call xhr.abort() on error cases in polling-xhr.js #319

Merged
merged 1 commit into from Dec 2, 2014

Conversation

Projects
None yet
2 participants
Contributor

samcday commented Jul 6, 2014

How about this as a fix for #318?

Contributor

rauchg commented Nov 15, 2014

@samcday interesting. Can we get a test for this?

Contributor

rauchg commented Nov 15, 2014

Thanks!

Contributor

samcday commented Dec 2, 2014

@guille If you deem this not mergeable because of the lack of a test, then please go ahead and close the PR. Realistically I'm not gonna have time to sit down and re-acquaint myself with the changes I made here and the test runner for engine.io-client in the near term.

Contributor

rauchg commented Dec 2, 2014

We'll take care of it then!

rauchg added a commit that referenced this pull request Dec 2, 2014

Merge pull request #319 from samcday/no-abort-on-success
Only call xhr.abort() on error cases in polling-xhr.js

@rauchg rauchg merged commit 61648de into socketio:master Dec 2, 2014

Contributor

samcday commented Dec 2, 2014

Awesome, thanks mate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment