Leverage native pings implementations when possible #110

Closed
3rd-Eden opened this Issue Nov 1, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@3rd-Eden
Contributor

3rd-Eden commented Nov 1, 2012

The WebSockets have a special PING/PONG opcode that should be used for ping/pong between server and client.

See http://tools.ietf.org/html/rfc6455#page-37 for the related information. As far as I know, the ws module implements a ping method, so it shouldn't be that hard to implement.

@rauchg

This comment has been minimized.

Show comment Hide comment
@rauchg

rauchg Nov 1, 2012

Contributor

I wanted to do this a while ago, but I think Einar said it was a good idea to keep engine.io pings. I don't remember why, however.

I'm interested in revisiting this.

Contributor

rauchg commented Nov 1, 2012

I wanted to do this a while ago, but I think Einar said it was a good idea to keep engine.io pings. I don't remember why, however.

I'm interested in revisiting this.

@3rd-Eden

This comment has been minimized.

Show comment Hide comment
@3rd-Eden

3rd-Eden Nov 1, 2012

Contributor

I think that we should seize every oppertunity to optimize heartbeats as we send them so frequently

On Nov 1, 2012, at 5:30 PM, Guillermo Rauch notifications@github.com wrote:

I wanted to do this a while ago, but I think Einar said it was a good idea to keep engine.io pings. I don't remember why, however.

I'm interested in revisiting this.


Reply to this email directly or view it on GitHub.

Contributor

3rd-Eden commented Nov 1, 2012

I think that we should seize every oppertunity to optimize heartbeats as we send them so frequently

On Nov 1, 2012, at 5:30 PM, Guillermo Rauch notifications@github.com wrote:

I wanted to do this a while ago, but I think Einar said it was a good idea to keep engine.io pings. I don't remember why, however.

I'm interested in revisiting this.


Reply to this email directly or view it on GitHub.

@rauchg rauchg closed this Feb 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment