Cache remote address in handshake since it might be lost later. #270

Merged
merged 1 commit into from Jul 19, 2014

Conversation

Projects
None yet
2 participants
Contributor

rase- commented Jul 19, 2014

For the Socket.IO handshake address property.

Contributor

rauchg commented Jul 19, 2014

I think the Socket constructor could do this itself, since it receives the req parameter.

Contributor

rase- commented Jul 19, 2014

True. Will move it.

Contributor

rase- commented Jul 19, 2014

Moved.

rauchg added a commit that referenced this pull request Jul 19, 2014

Merge pull request #270 from rase-/cache-ip-in-handshake
Cache remote address in handshake since it might be lost later.

@rauchg rauchg merged commit f00ef8b into socketio:master Jul 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment