From 99b718ca2a9bcf2a0538b3c35a9f1664a0a5d53d Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Mon, 14 Mar 2016 12:22:14 +0800
Subject: [PATCH 01/11] Minor refactoring

- change var to const in gulpfile
- indentation fix
---
 gulpfile.js | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gulpfile.js b/gulpfile.js
index 06ccc6a95..0671fdbb5 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -1,14 +1,15 @@
-var gulp = require('gulp');
-var mocha = require('gulp-mocha');
-var babel = require("gulp-babel");
+const gulp = require('gulp');
+const mocha = require('gulp-mocha');
+const babel = require("gulp-babel");
+const eslint = require('gulp-eslint');
 
-var TESTS = 'test/*.js';
-var REPORTER = 'dot';
+const TESTS = 'test/*.js';
+const REPORTER = 'dot';
 
 gulp.task("default", ["transpile"]);
 
 gulp.task('test', function(){
-    return gulp.src(TESTS, {read: false})
+  return gulp.src(TESTS, {read: false})
     .pipe(mocha({
       slow: 500,
       reporter: REPORTER,

From 671063f3542b2c5fd7156aa2511f4b6d0a01a3eb Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Mon, 14 Mar 2016 12:34:55 +0800
Subject: [PATCH 02/11] Add eslint

- Add dependencies
- Add root eslintrc
- Add gulp lint task
---
 .eslintrc.json | 10 ++++++++++
 gulpfile.js    | 11 +++++++++++
 package.json   |  4 ++++
 3 files changed, 25 insertions(+)
 create mode 100644 .eslintrc.json

diff --git a/.eslintrc.json b/.eslintrc.json
new file mode 100644
index 000000000..6d3c020b6
--- /dev/null
+++ b/.eslintrc.json
@@ -0,0 +1,10 @@
+{
+  "extends": "standard",
+  "parser": "babel-eslint",
+  "rules": {
+    "yoda": 0,
+    "semi": [2, "always"],
+    "no-extra-semi": 2,
+    "semi-spacing": [2, { "before": false, "after": true }]
+  }
+}
diff --git a/gulpfile.js b/gulpfile.js
index 0671fdbb5..850b1db00 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -23,6 +23,17 @@ gulp.task('test', function(){
     });
 });
 
+gulp.task('lint', function () {
+  return gulp.src([
+    '**/*.js',
+    '!node_modules/**',
+    '!coverage/**'
+  ])
+    .pipe(eslint())
+    .pipe(eslint.format())
+    .pipe(eslint.failAfterError());
+});
+
 // By default, individual js files are transformed by babel and exported to /dist
 gulp.task("transpile", function(){
     return gulp.src(["lib/*.js","lib/transports/*.js"], { base: 'lib' })
diff --git a/package.json b/package.json
index 7d13c915b..ba548f64f 100644
--- a/package.json
+++ b/package.json
@@ -32,11 +32,15 @@
     "accepts": "1.1.4"
   },
   "devDependencies": {
+    "babel-eslint": "5.0.0",
     "babel-preset-es2015": "6.3.13",
     "engine.io-client": "1.6.8",
+    "eslint-config-standard": "4.4.0",
+    "eslint-plugin-standard": "1.3.2",
     "expect.js": "0.2.0",
     "gulp": "3.9.0",
     "gulp-babel": "6.1.1",
+    "gulp-eslint": "1.1.1",
     "gulp-mocha": "2.2.0",
     "mocha": "2.3.4",
     "s": "0.1.1",

From 37ef38a0c29d9b70f0ab06e00feac1d0df94e258 Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Mon, 14 Mar 2016 12:36:09 +0800
Subject: [PATCH 03/11] ESLint: Add mocha env to test/ dir

---
 test/.eslintrc.json | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 test/.eslintrc.json

diff --git a/test/.eslintrc.json b/test/.eslintrc.json
new file mode 100644
index 000000000..7eeefc33b
--- /dev/null
+++ b/test/.eslintrc.json
@@ -0,0 +1,5 @@
+{
+  "env": {
+    "mocha": true
+  }
+}

From fccc50ede26125e150cc3119778ed1de7e320d0f Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Mon, 14 Mar 2016 12:41:33 +0800
Subject: [PATCH 04/11] Modify glob for transpile

---
 gulpfile.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gulpfile.js b/gulpfile.js
index 850b1db00..0a2be8490 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -36,7 +36,7 @@ gulp.task('lint', function () {
 
 // By default, individual js files are transformed by babel and exported to /dist
 gulp.task("transpile", function(){
-    return gulp.src(["lib/*.js","lib/transports/*.js"], { base: 'lib' })
+    return gulp.src(["lib/**/*.js"], { base: 'lib' })
         .pipe(babel({ "presets": ["es2015"] }))
         .pipe(gulp.dest("dist"));
 });

From 2a596d3b2942140381391aebcf0d259f3aef5c80 Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Thu, 17 Mar 2016 13:05:33 +0800
Subject: [PATCH 05/11] Fix ESLint compile error: use hex instead of octal
 string

---
 examples/latency/index.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/latency/index.js b/examples/latency/index.js
index bcaae7146..092e49380 100644
--- a/examples/latency/index.js
+++ b/examples/latency/index.js
@@ -26,5 +26,5 @@ io.on('connection', function(socket){
 
 var port = process.env.PORT || 3000;
 server.listen(port, function(){
-  console.log('\033[96mlistening on localhost:' + port + ' \033[39m');
+  console.log('\x1B[96mlistening on localhost:' + port + ' \x1B[39m');
 });

From 6035a9d460a823c02dc9bf11a12c873f0a479b27 Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Mon, 14 Mar 2016 15:22:20 +0800
Subject: [PATCH 06/11] ESLint autofix

---
 examples/latency/index.js               |   8 +-
 examples/latency/public/index.js        |  18 +-
 gulpfile.js                             |  18 +-
 lib/engine.io.js                        |  12 +-
 lib/server.js                           |  86 +++---
 lib/socket.js                           |  60 ++--
 lib/transport.js                        |   2 +-
 lib/transports/index.js                 |   2 +-
 lib/transports/polling-jsonp.js         |   6 +-
 lib/transports/polling-xhr.js           |   6 +-
 lib/transports/polling.js               |  32 +-
 lib/transports/websocket.js             |  14 +-
 test/common.js                          |   2 +-
 test/engine.io.js                       |  24 +-
 test/fixtures/server-close-upgraded.js  |   2 +-
 test/fixtures/server-close-upgrading.js |   2 +-
 test/fixtures/server-close.js           |   2 +-
 test/jsonp.js                           |  48 +--
 test/server.js                          | 386 ++++++++++++------------
 19 files changed, 365 insertions(+), 365 deletions(-)

diff --git a/examples/latency/index.js b/examples/latency/index.js
index 092e49380..cae791c3b 100644
--- a/examples/latency/index.js
+++ b/examples/latency/index.js
@@ -14,17 +14,17 @@ app.use(enchilada({
   debug: true
 }));
 app.use(express.static(__dirname + '/public'));
-app.get('/', function(req, res, next){
+app.get('/', function (req, res, next) {
   res.sendfile('index.html');
 });
 
-io.on('connection', function(socket){
-  socket.on('message', function(v){
+io.on('connection', function (socket) {
+  socket.on('message', function (v) {
     socket.send('pong');
   });
 });
 
 var port = process.env.PORT || 3000;
-server.listen(port, function(){
+server.listen(port, function () {
   console.log('\x1B[96mlistening on localhost:' + port + ' \x1B[39m');
 });
diff --git a/examples/latency/public/index.js b/examples/latency/public/index.js
index 525121894..b89ba222d 100644
--- a/examples/latency/public/index.js
+++ b/examples/latency/public/index.js
@@ -3,21 +3,21 @@
  * Module dependencies.
  */
 
-var SmoothieChart = require("smoothie").SmoothieChart
-  , TimeSeries = require("smoothie").TimeSeries
-  , eio = require("engine.io-client");
+var SmoothieChart = require('smoothie').SmoothieChart
+  , TimeSeries = require('smoothie').TimeSeries
+  , eio = require('engine.io-client');
 
 
 // helper
 
-function $(id){ return document.getElementById(id); }
+function $ (id) { return document.getElementById(id); }
 
 // chart
 
 var smoothie;
 var time;
 
-function render(){
+function render () {
   if (smoothie) smoothie.stop();
   $('chart').width = document.body.clientWidth;
   smoothie = new SmoothieChart();
@@ -33,23 +33,23 @@ function render(){
 // socket
 var socket = new eio.Socket();
 var last;
-function send(){
+function send () {
   last = new Date;
   socket.send('ping');
   $('transport').innerHTML = socket.transport.name;
 }
-socket.on('open', function(){
+socket.on('open', function () {
   if ($('chart').getContext) {
     render();
     window.onresize = render;
   }
   send();
 });
-socket.on('close', function(){
+socket.on('close', function () {
   if (smoothie) smoothie.stop();
   $('transport').innerHTML = '(disconnected)';
 });
-socket.on('message', function(){
+socket.on('message', function () {
   var latency = new Date - last;
   $('latency').innerHTML = latency + 'ms';
   if (time) time.append(+new Date, latency);
diff --git a/gulpfile.js b/gulpfile.js
index 0a2be8490..d6af33022 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -1,24 +1,24 @@
 const gulp = require('gulp');
 const mocha = require('gulp-mocha');
-const babel = require("gulp-babel");
+const babel = require('gulp-babel');
 const eslint = require('gulp-eslint');
 
 const TESTS = 'test/*.js';
 const REPORTER = 'dot';
 
-gulp.task("default", ["transpile"]);
+gulp.task('default', ['transpile']);
 
-gulp.task('test', function(){
+gulp.task('test', function () {
   return gulp.src(TESTS, {read: false})
     .pipe(mocha({
       slow: 500,
       reporter: REPORTER,
       bail: true
     }))
-    .once('error', function(){
+    .once('error', function () {
       process.exit(1);
     })
-    .once('end', function(){
+    .once('end', function () {
       process.exit();
     });
 });
@@ -35,8 +35,8 @@ gulp.task('lint', function () {
 });
 
 // By default, individual js files are transformed by babel and exported to /dist
-gulp.task("transpile", function(){
-    return gulp.src(["lib/**/*.js"], { base: 'lib' })
-        .pipe(babel({ "presets": ["es2015"] }))
-        .pipe(gulp.dest("dist"));
+gulp.task('transpile', function () {
+  return gulp.src(['lib/**/*.js'], { base: 'lib' })
+        .pipe(babel({ 'presets': ['es2015'] }))
+        .pipe(gulp.dest('dist'));
 });
diff --git a/lib/engine.io.js b/lib/engine.io.js
index dbec1de06..c97edd615 100644
--- a/lib/engine.io.js
+++ b/lib/engine.io.js
@@ -17,7 +17,7 @@ var http = require('http');
  * @api public
  */
 
-exports = module.exports = function() {
+exports = module.exports = function () {
   // backwards compatible use as `.attach`
   // if first argument is an http server
   if (arguments.length && arguments[0] instanceof http.Server) {
@@ -88,8 +88,8 @@ exports.parser = require('engine.io-parser');
 
 exports.listen = listen;
 
-function listen(port, options, fn) {
-  if ('function' == typeof options) {
+function listen (port, options, fn) {
+  if ('function' === typeof options) {
     fn = options;
     options = {};
   }
@@ -106,7 +106,7 @@ function listen(port, options, fn) {
   engine.httpServer = server;
 
   return engine;
-};
+}
 
 /**
  * Captures upgrade requests for a http.Server.
@@ -119,8 +119,8 @@ function listen(port, options, fn) {
 
 exports.attach = attach;
 
-function attach(server, options) {
+function attach (server, options) {
   var engine = new exports.Server(options);
   engine.attach(server, options);
   return engine;
-};
+}
diff --git a/lib/server.js b/lib/server.js
index a9b43b9ec..dd727662f 100644
--- a/lib/server.js
+++ b/lib/server.js
@@ -27,7 +27,7 @@ module.exports = Server;
  * @api public
  */
 
-function Server(opts){
+function Server (opts) {
   if (!(this instanceof Server)) {
     return new Server(opts);
   }
@@ -59,7 +59,7 @@ function Server(opts){
   }
 
   // initialize compression options
-  ['perMessageDeflate', 'httpCompression'].forEach(function(type) {
+  ['perMessageDeflate', 'httpCompression'].forEach(function (type) {
     var compression = self[type];
     if (true === compression) self[type] = compression = {};
     if (compression && null == compression.threshold) {
@@ -116,7 +116,7 @@ Server.prototype.clients;
  * @api public
  */
 
-Server.prototype.upgrades = function(transport){
+Server.prototype.upgrades = function (transport) {
   if (!this.allowUpgrades) return [];
   return transports[transport].upgradesTo || [];
 };
@@ -129,7 +129,7 @@ Server.prototype.upgrades = function(transport){
  * @api private
  */
 
-Server.prototype.verify = function(req, upgrade, fn){
+Server.prototype.verify = function (req, upgrade, fn) {
   // transport check
   var transport = req._query.transport;
   if (!~this.transports.indexOf(transport)) {
@@ -148,7 +148,7 @@ Server.prototype.verify = function(req, upgrade, fn){
     }
   } else {
     // handshake is GET only
-    if ('GET' != req.method) return fn(Server.errors.BAD_HANDSHAKE_METHOD, false);
+    if ('GET' !== req.method) return fn(Server.errors.BAD_HANDSHAKE_METHOD, false);
     if (!this.allowRequest) return fn(null, true);
     return this.allowRequest(req, fn);
   }
@@ -162,7 +162,7 @@ Server.prototype.verify = function(req, upgrade, fn){
  * @api private
  */
 
-Server.prototype.prepare = function(req){
+Server.prototype.prepare = function (req) {
   // try to leverage pre-existing `req._query` (e.g: from connect)
   if (!req._query) {
     req._query = ~req.url.indexOf('?') ? qs.parse(parse(req.url).query) : {};
@@ -175,7 +175,7 @@ Server.prototype.prepare = function(req){
  * @api public
  */
 
-Server.prototype.close = function(){
+Server.prototype.close = function () {
   debug('closing all open clients');
   for (var i in this.clients) {
     if (this.clients.hasOwnProperty(i)) {
@@ -193,13 +193,13 @@ Server.prototype.close = function(){
  * @api public
  */
 
-Server.prototype.handleRequest = function(req, res){
+Server.prototype.handleRequest = function (req, res) {
   debug('handling "%s" http request "%s"', req.method, req.url);
   this.prepare(req);
   req.res = res;
 
   var self = this;
-  this.verify(req, false, function(err, success) {
+  this.verify(req, false, function (err, success) {
     if (!success) {
       sendErrorMessage(req, res, err);
       return;
@@ -222,21 +222,21 @@ Server.prototype.handleRequest = function(req, res){
  * @api private
  */
 
- function sendErrorMessage(req, res, code) {
-    var headers = { 'Content-Type': 'application/json' };
+function sendErrorMessage (req, res, code) {
+  var headers = { 'Content-Type': 'application/json' };
 
-    if (req.headers.origin) {
-      headers['Access-Control-Allow-Credentials'] = 'true';
-      headers['Access-Control-Allow-Origin'] = req.headers.origin;
-    } else {
-      headers['Access-Control-Allow-Origin'] = '*';
-    }
-    res.writeHead(400, headers);
-    res.end(JSON.stringify({
-      code: code,
-      message: Server.errorMessages[code]
-    }));
- }
+  if (req.headers.origin) {
+    headers['Access-Control-Allow-Credentials'] = 'true';
+    headers['Access-Control-Allow-Origin'] = req.headers.origin;
+  } else {
+    headers['Access-Control-Allow-Origin'] = '*';
+  }
+  res.writeHead(400, headers);
+  res.end(JSON.stringify({
+    code: code,
+    message: Server.errorMessages[code]
+  }));
+}
 
 /**
  * generate a socket id.
@@ -246,7 +246,7 @@ Server.prototype.handleRequest = function(req, res){
  * @api public
  */
 
-Server.prototype.generateId = function(req){
+Server.prototype.generateId = function (req) {
   return base64id.generateId();
 };
 
@@ -258,17 +258,17 @@ Server.prototype.generateId = function(req){
  * @api private
  */
 
-Server.prototype.handshake = function(transportName, req){
+Server.prototype.handshake = function (transportName, req) {
   var id = this.generateId(req);
 
   debug('handshaking client "%s"', id);
 
   try {
     var transport = new transports[transportName](req);
-    if ('polling' == transportName) {
+    if ('polling' === transportName) {
       transport.maxHttpBufferSize = this.maxHttpBufferSize;
       transport.httpCompression = this.httpCompression;
-    } else if ('websocket' == transportName) {
+    } else if ('websocket' === transportName) {
       transport.perMessageDeflate = this.perMessageDeflate;
     }
 
@@ -286,9 +286,9 @@ Server.prototype.handshake = function(transportName, req){
   var self = this;
 
   if (false !== this.cookie) {
-    transport.on('headers', function(headers){
+    transport.on('headers', function (headers) {
       var cookie = self.cookie + '=' + id;
-      if(false !== self.cookiePath) {
+      if (false !== self.cookiePath) {
         cookie += '; path=' + self.cookiePath;
       }
       headers['Set-Cookie'] = cookie;
@@ -300,7 +300,7 @@ Server.prototype.handshake = function(transportName, req){
   this.clients[id] = socket;
   this.clientsCount++;
 
-  socket.once('close', function(){
+  socket.once('close', function () {
     delete self.clients[id];
     self.clientsCount--;
   });
@@ -314,11 +314,11 @@ Server.prototype.handshake = function(transportName, req){
  * @api public
  */
 
-Server.prototype.handleUpgrade = function(req, socket, upgradeHead){
+Server.prototype.handleUpgrade = function (req, socket, upgradeHead) {
   this.prepare(req);
 
   var self = this;
-  this.verify(req, true, function(err, success) {
+  this.verify(req, true, function (err, success) {
     if (!success) {
       socket.end();
       return;
@@ -329,7 +329,7 @@ Server.prototype.handleUpgrade = function(req, socket, upgradeHead){
     upgradeHead = null;
 
     // delegate to ws
-    self.ws.handleUpgrade(req, socket, head, function(conn){
+    self.ws.handleUpgrade(req, socket, head, function (conn) {
       self.onWebSocket(req, conn);
     });
   });
@@ -342,7 +342,7 @@ Server.prototype.handleUpgrade = function(req, socket, upgradeHead){
  * @api private
  */
 
-Server.prototype.onWebSocket = function(req, socket){
+Server.prototype.onWebSocket = function (req, socket) {
   socket.on('error', onUpgradeError);
 
   if (!transports[req._query.transport].prototype.handlesUpgrades) {
@@ -390,7 +390,7 @@ Server.prototype.onWebSocket = function(req, socket){
     this.handshake(req._query.transport, req);
   }
 
-  function onUpgradeError(){
+  function onUpgradeError () {
     debug('websocket error before upgrade');
     // socket.close() not needed
   }
@@ -404,7 +404,7 @@ Server.prototype.onWebSocket = function(req, socket){
  * @api public
  */
 
-Server.prototype.attach = function(server, options){
+Server.prototype.attach = function (server, options) {
   var self = this;
   var options = options || {};
   var path = (options.path || '/engine.io').replace(/\/$/, '');
@@ -416,7 +416,7 @@ Server.prototype.attach = function(server, options){
   path += '/';
 
   function check (req) {
-    return path == req.url.substr(0, path.length);
+    return path === req.url.substr(0, path.length);
   }
 
   // cache and clean up listeners
@@ -425,7 +425,7 @@ Server.prototype.attach = function(server, options){
   server.on('close', self.close.bind(self));
 
   // add request handler
-  server.on('request', function(req, res){
+  server.on('request', function (req, res) {
     if (check(req)) {
       debug('intercepting request for path "%s"', path);
       self.handleRequest(req, res);
@@ -436,7 +436,7 @@ Server.prototype.attach = function(server, options){
     }
   });
 
-  if(~self.transports.indexOf('websocket')) {
+  if (~self.transports.indexOf('websocket')) {
     server.on('upgrade', function (req, socket, head) {
       if (check(req)) {
         self.handleUpgrade(req, socket, head);
@@ -445,10 +445,10 @@ Server.prototype.attach = function(server, options){
         // but by adding a handler, we prevent that
         // and if no eio thing handles the upgrade
         // then the socket needs to die!
-        setTimeout(function() {
-           if (socket.writable && socket.bytesWritten <= 0) {
-             return socket.end();
-           }
+        setTimeout(function () {
+          if (socket.writable && socket.bytesWritten <= 0) {
+            return socket.end();
+          }
         }, options.destroyUpgradeTimeout);
       }
     });
diff --git a/lib/socket.js b/lib/socket.js
index 57838f615..cc6bc0204 100644
--- a/lib/socket.js
+++ b/lib/socket.js
@@ -58,7 +58,7 @@ Socket.prototype.onOpen = function () {
   // sends an `open` packet
   this.transport.sid = this.id;
   this.sendPacket('open', JSON.stringify({
-      sid: this.id
+    sid: this.id
     , upgrades: this.getAvailableUpgrades()
     , pingInterval: this.server.pingInterval
     , pingTimeout: this.server.pingTimeout
@@ -76,7 +76,7 @@ Socket.prototype.onOpen = function () {
  */
 
 Socket.prototype.onPacket = function (packet) {
-  if ('open' == this.readyState) {
+  if ('open' === this.readyState) {
     // export packet event
     debug('packet');
     this.emit('packet', packet);
@@ -154,7 +154,7 @@ Socket.prototype.setTransport = function (transport) {
   //this function will manage packet events (also message callbacks)
   this.setupSendCallback();
 
-  this.cleanupFn.push(function() {
+  this.cleanupFn.push(function () {
     transport.removeListener('error', onError);
     transport.removeListener('packet', onPacket);
     transport.removeListener('drain', flush);
@@ -181,18 +181,18 @@ Socket.prototype.maybeUpgrade = function (transport) {
   self.upgradeTimeoutTimer = setTimeout(function () {
     debug('client did not complete upgrade - closing transport');
     cleanup();
-    if ('open' == transport.readyState) {
+    if ('open' === transport.readyState) {
       transport.close();
     }
   }, this.server.upgradeTimeout);
 
-  function onPacket(packet){
-    if ('ping' == packet.type && 'probe' == packet.data) {
+  function onPacket (packet) {
+    if ('ping' === packet.type && 'probe' === packet.data) {
       transport.send([{ type: 'pong', data: 'probe' }]);
       self.emit('upgrading', transport);
       clearInterval(self.checkIntervalTimer);
       self.checkIntervalTimer = setInterval(check, 100);
-    } else if ('upgrade' == packet.type && self.readyState != 'closed') {
+    } else if ('upgrade' === packet.type && self.readyState !== 'closed') {
       debug('got upgrade packet - upgrading');
       cleanup();
       self.transport.discard();
@@ -202,7 +202,7 @@ Socket.prototype.maybeUpgrade = function (transport) {
       self.emit('upgrade', transport);
       self.setPingTimeout();
       self.flush();
-      if (self.readyState == 'closing') {
+      if (self.readyState === 'closing') {
         transport.close(function () {
           self.onClose('forced close');
         });
@@ -214,14 +214,14 @@ Socket.prototype.maybeUpgrade = function (transport) {
   }
 
   // we force a polling cycle to ensure a fast upgrade
-  function check(){
-    if ('polling' == self.transport.name && self.transport.writable) {
+  function check () {
+    if ('polling' === self.transport.name && self.transport.writable) {
       debug('writing a noop packet to polling for fast upgrade');
       self.transport.send([{ type: 'noop' }]);
     }
   }
 
-  function cleanup() {
+  function cleanup () {
     self.upgrading = false;
 
     clearInterval(self.checkIntervalTimer);
@@ -236,19 +236,19 @@ Socket.prototype.maybeUpgrade = function (transport) {
     self.removeListener('close', onClose);
   }
 
-  function onError(err) {
+  function onError (err) {
     debug('client did not complete upgrade - %s', err);
     cleanup();
     transport.close();
     transport = null;
   }
 
-  function onTransportClose(){
-    onError("transport closed");
+  function onTransportClose () {
+    onError('transport closed');
   }
 
-  function onClose() {
-    onError("socket closed");
+  function onClose () {
+    onError('socket closed');
   }
 
   transport.on('packet', onPacket);
@@ -269,7 +269,7 @@ Socket.prototype.clearTransport = function () {
   while (cleanup = this.cleanupFn.shift()) cleanup();
 
   // silence further transport errors and prevent uncaught exceptions
-  this.transport.on('error', function(){
+  this.transport.on('error', function () {
     debug('error triggered by discarded transport');
   });
 
@@ -286,7 +286,7 @@ Socket.prototype.clearTransport = function () {
  */
 
 Socket.prototype.onClose = function (reason, description) {
-  if ('closed' != this.readyState) {
+  if ('closed' !== this.readyState) {
     this.readyState = 'closed';
     clearTimeout(this.pingTimeoutTimer);
     clearInterval(this.checkIntervalTimer);
@@ -295,7 +295,7 @@ Socket.prototype.onClose = function (reason, description) {
     var self = this;
     // clean writeBuffer in next tick, so developers can still
     // grab the writeBuffer on 'close' event
-    process.nextTick(function() {
+    process.nextTick(function () {
       self.writeBuffer = [];
     });
     this.packetsFn = [];
@@ -315,21 +315,21 @@ Socket.prototype.setupSendCallback = function () {
   var self = this;
   this.transport.on('drain', onDrain);
 
-  this.cleanupFn.push(function() {
+  this.cleanupFn.push(function () {
     self.transport.removeListener('drain', onDrain);
   });
 
   //the message was sent successfully, execute the callback
-  function onDrain() {
+  function onDrain () {
     if (self.sentCallbackFn.length > 0) {
-      var seqFn = self.sentCallbackFn.splice(0,1)[0];
-      if ('function' == typeof seqFn) {
+      var seqFn = self.sentCallbackFn.splice(0, 1)[0];
+      if ('function' === typeof seqFn) {
         debug('executing send callback');
         seqFn(self.transport);
       } else if (Array.isArray(seqFn)) {
         debug('executing batch send callback');
         for (var l = seqFn.length, i = 0; i < l; i++) {
-          if ('function' == typeof seqFn[i]) {
+          if ('function' === typeof seqFn[i]) {
             seqFn[i](self.transport);
           }
         }
@@ -349,7 +349,7 @@ Socket.prototype.setupSendCallback = function () {
  */
 
 Socket.prototype.send =
-Socket.prototype.write = function(data, options, callback){
+Socket.prototype.write = function (data, options, callback) {
   this.sendPacket('message', data, options, callback);
   return this;
 };
@@ -364,7 +364,7 @@ Socket.prototype.write = function(data, options, callback){
  */
 
 Socket.prototype.sendPacket = function (type, data, options, callback) {
-  if ('function' == typeof options) {
+  if ('function' === typeof options) {
     callback = options;
     options = null;
   }
@@ -372,7 +372,7 @@ Socket.prototype.sendPacket = function (type, data, options, callback) {
   options = options || {};
   options.compress = false !== options.compress;
 
-  if ('closing' != this.readyState) {
+  if ('closing' !== this.readyState) {
     debug('sending packet "%s" (%s)', type, data);
 
     var packet = {
@@ -400,7 +400,7 @@ Socket.prototype.sendPacket = function (type, data, options, callback) {
  */
 
 Socket.prototype.flush = function () {
-  if ('closed' != this.readyState && this.transport.writable
+  if ('closed' !== this.readyState && this.transport.writable
     && this.writeBuffer.length) {
     debug('flushing buffer to transport');
     this.emit('flush', this.writeBuffer);
@@ -430,7 +430,7 @@ Socket.prototype.getAvailableUpgrades = function () {
   var allUpgrades = this.server.upgrades(this.transport.name);
   for (var i = 0, l = allUpgrades.length; i < l; ++i) {
     var upg = allUpgrades[i];
-    if (this.server.transports.indexOf(upg) != -1) {
+    if (this.server.transports.indexOf(upg) !== -1) {
       availableUpgrades.push(upg);
     }
   }
@@ -446,7 +446,7 @@ Socket.prototype.getAvailableUpgrades = function () {
  */
 
 Socket.prototype.close = function (discard) {
-  if ('open' != this.readyState) return;
+  if ('open' !== this.readyState) return;
 
   this.readyState = 'closing';
 
diff --git a/lib/transport.js b/lib/transport.js
index fdd65db70..28848b59c 100644
--- a/lib/transport.js
+++ b/lib/transport.js
@@ -68,7 +68,7 @@ Transport.prototype.onRequest = function (req) {
  */
 
 Transport.prototype.close = function (fn) {
-  if ('closed' == this.readyState || 'closing' == this.readyState) return;
+  if ('closed' === this.readyState || 'closing' === this.readyState) return;
 
   this.readyState = 'closing';
   this.doClose(fn || noop);
diff --git a/lib/transports/index.js b/lib/transports/index.js
index ecedb58c2..22a86eba3 100644
--- a/lib/transports/index.js
+++ b/lib/transports/index.js
@@ -28,7 +28,7 @@ exports.polling.upgradesTo = ['websocket'];
  */
 
 function polling (req) {
-  if ('string' == typeof req._query.j) {
+  if ('string' === typeof req._query.j) {
     return new JSONP(req);
   } else {
     return new XHR(req);
diff --git a/lib/transports/polling-jsonp.js b/lib/transports/polling-jsonp.js
index fe9fae61f..f8cc2bba1 100644
--- a/lib/transports/polling-jsonp.js
+++ b/lib/transports/polling-jsonp.js
@@ -25,7 +25,7 @@ function JSONP (req) {
 
   this.head = '___eio[' + (req._query.j || '').replace(/[^0-9]/g, '') + '](';
   this.foot = ');';
-};
+}
 
 /**
  * Inherits from Polling.
@@ -44,10 +44,10 @@ JSONP.prototype.onData = function (data) {
   // we leverage the qs module so that we get built-in DoS protection
   // and the fast alternative to decodeURIComponent
   data = qs.parse(data).d;
-  if ('string' == typeof data) {
+  if ('string' === typeof data) {
     //client will send already escaped newlines as \\\\n and newlines as \\n
     // \\n must be replaced with \n and \\\\n with \\n
-    data = data.replace(rSlashes, function(match, slashes) {
+    data = data.replace(rSlashes, function (match, slashes) {
       return slashes ? match : '\n';
     });
     Polling.prototype.onData.call(this, data.replace(rDoubleSlashes, '\\n'));
diff --git a/lib/transports/polling-xhr.js b/lib/transports/polling-xhr.js
index d2f213603..4038280f2 100644
--- a/lib/transports/polling-xhr.js
+++ b/lib/transports/polling-xhr.js
@@ -19,7 +19,7 @@ module.exports = XHR;
  * @api public
  */
 
-function XHR(req){
+function XHR (req) {
   Polling.call(this, req);
 }
 
@@ -37,7 +37,7 @@ XHR.prototype.__proto__ = Polling.prototype;
  */
 
 XHR.prototype.onRequest = function (req) {
-  if ('OPTIONS' == req.method) {
+  if ('OPTIONS' === req.method) {
     var res = req.res;
     var headers = this.headers(req);
     headers['Access-Control-Allow-Headers'] = 'Content-Type';
@@ -56,7 +56,7 @@ XHR.prototype.onRequest = function (req) {
  * @api private
  */
 
-XHR.prototype.headers = function(req, headers){
+XHR.prototype.headers = function (req, headers) {
   headers = headers || {};
 
   if (req.headers.origin) {
diff --git a/lib/transports/polling.js b/lib/transports/polling.js
index 36b9222e6..26f67257d 100644
--- a/lib/transports/polling.js
+++ b/lib/transports/polling.js
@@ -60,9 +60,9 @@ Polling.prototype.name = 'polling';
 Polling.prototype.onRequest = function (req) {
   var res = req.res;
 
-  if ('GET' == req.method) {
+  if ('GET' === req.method) {
     this.onPollRequest(req, res);
-  } else if ('POST' == req.method) {
+  } else if ('POST' === req.method) {
     this.onDataRequest(req, res);
   } else {
     res.writeHead(500);
@@ -130,7 +130,7 @@ Polling.prototype.onDataRequest = function (req, res) {
     return;
   }
 
-  var isBinary = 'application/octet-stream' == req.headers['content-type'];
+  var isBinary = 'application/octet-stream' === req.headers['content-type'];
 
   this.dataReq = req;
   this.dataRes = res;
@@ -153,7 +153,7 @@ Polling.prototype.onDataRequest = function (req, res) {
 
   function onData (data) {
     var contentLength;
-    if (typeof data == 'string') {
+    if (typeof data === 'string') {
       chunks += data;
       contentLength = Buffer.byteLength(chunks);
     } else {
@@ -198,8 +198,8 @@ Polling.prototype.onDataRequest = function (req, res) {
 Polling.prototype.onData = function (data) {
   debug('received "%s"', data);
   var self = this;
-  var callback = function(packet) {
-    if ('close' == packet.type) {
+  var callback = function (packet) {
+    if ('close' === packet.type) {
       debug('got xhr close packet');
       self.onClose();
       return false;
@@ -243,8 +243,8 @@ Polling.prototype.send = function (packets) {
   }
 
   var self = this;
-  parser.encodePayload(packets, this.supportsBinary, function(data) {
-    var compress = packets.some(function(packet) {
+  parser.encodePayload(packets, this.supportsBinary, function (data) {
+    var compress = packets.some(function (packet) {
       return packet.options && packet.options.compress;
     });
     self.write(data, { compress: compress });
@@ -262,7 +262,7 @@ Polling.prototype.send = function (packets) {
 Polling.prototype.write = function (data, options) {
   debug('writing "%s"', data);
   var self = this;
-  this.doWrite(data, options, function() {
+  this.doWrite(data, options, function () {
     self.req.cleanup();
   });
 };
@@ -277,7 +277,7 @@ Polling.prototype.doWrite = function (data, options, callback) {
   var self = this;
 
   // explicit UTF-8 is required for pages not served under utf
-  var isString = typeof data == 'string';
+  var isString = typeof data === 'string';
   var contentType = isString
     ? 'text/plain; charset=UTF-8'
     : 'application/octet-stream';
@@ -303,7 +303,7 @@ Polling.prototype.doWrite = function (data, options, callback) {
     return;
   }
 
-  this.compress(data, encoding, function(err, data) {
+  this.compress(data, encoding, function (err, data) {
     if (err) {
       self.res.writeHead(500);
       self.res.end();
@@ -315,8 +315,8 @@ Polling.prototype.doWrite = function (data, options, callback) {
     respond(data);
   });
 
-  function respond(data) {
-    headers['Content-Length'] = 'string' == typeof data ? Buffer.byteLength(data) : data.length;
+  function respond (data) {
+    headers['Content-Length'] = 'string' === typeof data ? Buffer.byteLength(data) : data.length;
     self.res.writeHead(200, self.headers(self.req, headers));
     self.res.end(data);
     callback();
@@ -337,11 +337,11 @@ Polling.prototype.compress = function (data, encoding, callback) {
 
   compressionMethods[encoding](this.httpCompression)
     .on('error', callback)
-    .on('data', function(chunk) {
+    .on('data', function (chunk) {
       buffers.push(chunk);
       nread += chunk.length;
     })
-    .on('end', function() {
+    .on('end', function () {
       callback(null, Buffer.concat(buffers, nread));
     })
     .end(data);
@@ -377,7 +377,7 @@ Polling.prototype.doClose = function (fn) {
     closeTimeoutTimer = setTimeout(onClose, this.closeTimeout);
   }
 
-  function onClose() {
+  function onClose () {
     clearTimeout(closeTimeoutTimer);
     fn();
     self.onClose();
diff --git a/lib/transports/websocket.js b/lib/transports/websocket.js
index 5a16f210c..5c1af933d 100644
--- a/lib/transports/websocket.js
+++ b/lib/transports/websocket.js
@@ -5,7 +5,7 @@
 
 var Transport = require('../transport')
   , parser = require('engine.io-parser')
-  , debug = require('debug')('engine:ws')
+  , debug = require('debug')('engine:ws');
 
 /**
  * Export the constructor.
@@ -14,7 +14,7 @@ var Transport = require('../transport')
 module.exports = WebSocket;
 
 /**
- * WebSocket transport 
+ * WebSocket transport
  *
  * @param {http.ServerRequest}
  * @api public
@@ -32,7 +32,7 @@ function WebSocket (req) {
   });
   this.writable = true;
   this.perMessageDeflate = null;
-};
+}
 
 /**
  * Inherits from Transport.
@@ -85,8 +85,8 @@ WebSocket.prototype.onData = function (data) {
 
 WebSocket.prototype.send = function (packets) {
   var self = this;
-  packets.forEach(function(packet) {
-    parser.encodePacket(packet, self.supportsBinary, function(data) {
+  packets.forEach(function (packet) {
+    parser.encodePacket(packet, self.supportsBinary, function (data) {
       debug('writing "%s"', data);
 
       // always creates a new object since ws modifies it
@@ -96,14 +96,14 @@ WebSocket.prototype.send = function (packets) {
       }
 
       if (self.perMessageDeflate) {
-        var len = 'string' == typeof data ? Buffer.byteLength(data) : data.length;
+        var len = 'string' === typeof data ? Buffer.byteLength(data) : data.length;
         if (len < self.perMessageDeflate.threshold) {
           opts.compress = false;
         }
       }
 
       self.writable = false;
-      self.socket.send(data, opts, function (err){
+      self.socket.send(data, opts, function (err) {
         if (err) return self.onError('write error', err.stack);
         self.writable = true;
         self.emit('drain');
diff --git a/test/common.js b/test/common.js
index a75430633..a26616e54 100644
--- a/test/common.js
+++ b/test/common.js
@@ -10,7 +10,7 @@ var eio = require('..');
  */
 
 exports.listen = function (opts, fn) {
-  if ('function' == typeof opts) {
+  if ('function' === typeof opts) {
     fn = opts;
     opts = {};
   }
diff --git a/test/engine.io.js b/test/engine.io.js
index c171adf34..2dd511736 100644
--- a/test/engine.io.js
+++ b/test/engine.io.js
@@ -20,7 +20,7 @@ describe('engine', function () {
     expect(eio.protocol).to.be.a('number');
   });
 
-  it('should be the same version as client', function(){
+  it('should be the same version as client', function () {
     expect(eio.protocol).to.be.a('number');
     var version = require('../package').version;
     expect(version).to.be(require('engine.io-client/package').version);
@@ -83,7 +83,7 @@ describe('engine', function () {
         var client = net.createConnection(server.address().port);
         client.setEncoding('ascii');
         client.write([
-            'GET / HTTP/1.1'
+          'GET / HTTP/1.1'
           , 'Connection: Upgrade'
           , 'Upgrade: IRC/6.9'
           , '', ''
@@ -109,7 +109,7 @@ describe('engine', function () {
         client.on('connect', function () {
           client.setEncoding('ascii');
           client.write([
-              'GET / HTTP/1.1'
+            'GET / HTTP/1.1'
             , 'Connection: Upgrade'
             , 'Upgrade: IRC/6.9'
             , '', ''
@@ -138,7 +138,7 @@ describe('engine', function () {
         client.on('connect', function () {
           client.setEncoding('ascii');
           client.write([
-              'GET / HTTP/1.1'
+            'GET / HTTP/1.1'
             , 'Connection: Upgrade'
             , 'Upgrade: IRC/6.9'
             , '', ''
@@ -147,7 +147,7 @@ describe('engine', function () {
           // send from client to server
           // tests that socket is still alive
           // this will not keep the socket open as the server does not handle it
-          setTimeout(function() {
+          setTimeout(function () {
             client.write('foo');
           }, 100);
 
@@ -165,9 +165,9 @@ describe('engine', function () {
         , engine = eio.attach(server, { destroyUpgradeTimeout: 100 });
 
       // write to the socket to keep engine.io from closing it by writing before the timeout
-      server.on('upgrade', function(req, socket) {
+      server.on('upgrade', function (req, socket) {
         socket.write('foo');
-        socket.on('data', function(chunk) {
+        socket.on('data', function (chunk) {
           expect(chunk.toString()).to.be('foo');
           socket.end();
         });
@@ -179,14 +179,14 @@ describe('engine', function () {
         client.on('connect', function () {
           client.setEncoding('ascii');
           client.write([
-              'GET / HTTP/1.1'
+            'GET / HTTP/1.1'
             , 'Connection: Upgrade'
             , 'Upgrade: IRC/6.9'
             , '', ''
           ].join('\r\n'));
 
           // test that socket is still open by writing after the timeout period
-          setTimeout(function() {
+          setTimeout(function () {
             client.write('foo');
           }, 200);
 
@@ -201,9 +201,9 @@ describe('engine', function () {
     it('should preserve original request listeners', function (done) {
       var listeners = 0
         , server = http.createServer(function (req, res) {
-            expect(req && res).to.be.ok();
-            listeners++;
-          });
+          expect(req && res).to.be.ok();
+          listeners++;
+        });
 
       server.on('request', function (req, res) {
         expect(req && res).to.be.ok();
diff --git a/test/fixtures/server-close-upgraded.js b/test/fixtures/server-close-upgraded.js
index 69ff0ee2a..dc608d30b 100644
--- a/test/fixtures/server-close-upgraded.js
+++ b/test/fixtures/server-close-upgraded.js
@@ -3,7 +3,7 @@ var listen = require('../common').listen;
 
 var engine = listen(function (port) {
   var socket = new eioc.Socket('ws://localhost:' + port);
-  socket.on('upgrade', function() {
+  socket.on('upgrade', function () {
     engine.httpServer.close();
     engine.close();
   });
diff --git a/test/fixtures/server-close-upgrading.js b/test/fixtures/server-close-upgrading.js
index 581a1ea6e..4ebfcc52b 100644
--- a/test/fixtures/server-close-upgrading.js
+++ b/test/fixtures/server-close-upgrading.js
@@ -3,7 +3,7 @@ var listen = require('../common').listen;
 
 var engine = listen(function (port) {
   var socket = new eioc.Socket('ws://localhost:' + port);
-  socket.on('upgrading', function() {
+  socket.on('upgrading', function () {
     engine.httpServer.close();
     engine.close();
   });
diff --git a/test/fixtures/server-close.js b/test/fixtures/server-close.js
index 259a3f45d..07c312094 100644
--- a/test/fixtures/server-close.js
+++ b/test/fixtures/server-close.js
@@ -3,7 +3,7 @@ var listen = require('../common').listen;
 
 var engine = listen(function (port) {
   var socket = new eioc.Socket('ws://localhost:' + port);
-  socket.on('open', function() {
+  socket.on('open', function () {
     engine.httpServer.close();
     engine.close();
   });
diff --git a/test/jsonp.js b/test/jsonp.js
index 934d1ff42..b80a5ee45 100644
--- a/test/jsonp.js
+++ b/test/jsonp.js
@@ -15,15 +15,15 @@ describe('JSONP', function () {
     // we have to override the browser's functionality for JSONP
     document = {
       body: {
-        appendChild: function(){},
-        removeChild: function(){}
+        appendChild: function () {},
+        removeChild: function () {}
       }
     };
 
     document.createElement = function (name) {
       var self = this;
 
-      if('script' == name) {
+      if ('script' === name) {
         var script = {};
 
         script.__defineGetter__('parentNode', function () {
@@ -31,29 +31,29 @@ describe('JSONP', function () {
         });
 
         script.__defineSetter__('src', function (uri) {
-          request.get(uri).end(function(res) {
+          request.get(uri).end(function (res) {
             eval(res.text);
           });
         });
         return script;
-      } else if ('form' == name) {
+      } else if ('form' === name) {
         var form = {
           style: {},
           action: '',
-          parentNode: { removeChild: function(){} },
-          removeChild: function(){},
-          setAttribute: function(){},
-          appendChild: function(){},
-          submit: function(){
+          parentNode: { removeChild: function () {} },
+          removeChild: function () {},
+          setAttribute: function () {},
+          appendChild: function () {},
+          submit: function () {
             request
             .post(this.action)
             .type('form')
             .send({ d: self.areaValue })
-            .end(function(){});
+            .end(function () {});
           }
         };
         return form;
-      } else if ('textarea' == name) {
+      } else if ('textarea' === name) {
         var textarea = {};
 
         //a hack to be able to access the area data when form is sent
@@ -63,7 +63,7 @@ describe('JSONP', function () {
         return textarea;
       } else if (~name.indexOf('iframe')) {
         var iframe = {};
-        setTimeout(function() {
+        setTimeout(function () {
           if (iframe.onload) iframe.onload();
         }, 0);
 
@@ -71,15 +71,15 @@ describe('JSONP', function () {
       } else {
         return {};
       }
-    }
+    };
 
     document.getElementsByTagName = function (name) {
       return [{
         parentNode: {
           insertBefore: function () {}
         }
-      }]
-    }
+      }];
+    };
   });
 
   after(function () {
@@ -105,7 +105,7 @@ describe('JSONP', function () {
   describe('messages', function () {
     var engine, port, socket;
 
-    beforeEach(function(done) {
+    beforeEach(function (done) {
       engine = listen( { allowUpgrades: false, transports: ['polling'] }, function (p) {
         port = p;
 
@@ -134,8 +134,8 @@ describe('JSONP', function () {
     });
 
     it('should not fail JSON.parse for stringified messages', function (done) {
-      engine.on('connection', function(conn) {
-        conn.on('message', function(message) {
+      engine.on('connection', function (conn) {
+        conn.on('message', function (message) {
           expect(JSON.parse(message)).to.be.eql({test : 'a\r\nb\n\n\n\nc'});
           done();
         });
@@ -146,8 +146,8 @@ describe('JSONP', function () {
     });
 
     it('should parse newlines in message correctly', function (done) {
-      engine.on('connection', function(conn) {
-        conn.on('message', function(message) {
+      engine.on('connection', function (conn) {
+        conn.on('message', function (message) {
           expect(message).to.be.equal('a\r\nb\n\n\n\nc');
           done();
         });
@@ -157,7 +157,7 @@ describe('JSONP', function () {
       });
     });
 
-    it('should arrive from server to client and back with binary data (pollingJSONP)', function(done) {
+    it('should arrive from server to client and back with binary data (pollingJSONP)', function (done) {
       var binaryData = new Buffer(5);
       for (var i = 0; i < 5; i++) binaryData[i] = i;
       engine.on('connection', function (conn) {
@@ -166,7 +166,7 @@ describe('JSONP', function () {
         });
       });
 
-      socket.on('open', function() {
+      socket.on('open', function () {
         socket.send(binaryData);
         socket.on('message', function (msg) {
           for (var i = 0; i < msg.length; i++) expect(msg[i]).to.be(i);
@@ -179,7 +179,7 @@ describe('JSONP', function () {
   describe('close', function () {
     it('should trigger when server closes a client', function (done) {
       var engine = listen( { allowUpgrades: false, transports: ['polling'] }, function (port) {
-          var socket = new eioc.Socket('ws://localhost:' + port
+        var socket = new eioc.Socket('ws://localhost:' + port
             , { transports: ['polling'], forceJSONP: true, upgrade: false })
             , total = 2;
 
diff --git a/test/server.js b/test/server.js
index 5340f3971..5736e4a54 100644
--- a/test/server.js
+++ b/test/server.js
@@ -144,7 +144,7 @@ describe('server', function () {
 
         var customId = 'CustomId' + Date.now();
 
-        engine.generateId = function(req) {
+        engine.generateId = function (req) {
           return customId;
         };
 
@@ -257,7 +257,7 @@ describe('server', function () {
 
         engine.on('connection', function (socket) {
           socket.on('message', function (msg) {
-            if ('echo' == msg) socket.send(msg);
+            if ('echo' === msg) socket.send(msg);
           });
         });
 
@@ -323,7 +323,7 @@ describe('server', function () {
   });
 
   describe('close', function () {
-    it('should be able to access non-empty writeBuffer at closing (server)', function(done) {
+    it('should be able to access non-empty writeBuffer at closing (server)', function (done) {
       var opts = {allowUpgrades: false};
       var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('http://localhost:%d'.s(port));
@@ -341,14 +341,14 @@ describe('server', function () {
       });
     });
 
-    it('should be able to access non-empty writeBuffer at closing (client)', function(done) {
+    it('should be able to access non-empty writeBuffer at closing (client)', function (done) {
       var opts = {allowUpgrades: false};
       var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('http://localhost:%d'.s(port));
-        socket.on('open', function() {
+        socket.on('open', function () {
           socket.on('close', function (reason) {
             expect(socket.writeBuffer.length).to.be(1);
-            setTimeout(function() {
+            setTimeout(function () {
               expect(socket.writeBuffer.length).to.be(0);
             }, 10);
             done();
@@ -363,7 +363,7 @@ describe('server', function () {
       var opts = { allowUpgrades: false, pingInterval: 5, pingTimeout: 5 };
       var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('http://localhost:%d'.s(port));
-        socket.sendPacket = function (){};
+        socket.sendPacket = function () {};
         engine.on('connection', function (conn) {
           conn.on('close', function (reason) {
             expect(reason).to.be('ping timeout');
@@ -383,7 +383,7 @@ describe('server', function () {
             done();
           });
           // client abruptly disconnects, no polling request on this tick since we've just connected
-          socket.sendPacket = socket.onPacket = function (){};
+          socket.sendPacket = socket.onPacket = function () {};
           socket.close();
           // then server app tries to close the socket, since client disappeared
           conn.close();
@@ -397,8 +397,8 @@ describe('server', function () {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         socket.on('open', function () {
           // override onPacket and Transport#onClose to simulate an inactive server after handshake
-          socket.onPacket = function(){};
-          socket.transport.onClose = function(){};
+          socket.onPacket = function () {};
+          socket.transport.onClose = function () {};
           socket.on('close', function (reason, err) {
             expect(reason).to.be('ping timeout');
             done();
@@ -424,8 +424,8 @@ describe('server', function () {
 
         socket.on('open', function () {
           // override onPacket and Transport#onClose to simulate an inactive server after handshake
-          socket.onPacket = socket.sendPacket = function(){};
-          socket.transport.onClose = function(){};
+          socket.onPacket = socket.sendPacket = function () {};
+          socket.transport.onClose = function () {};
           socket.on('close', onClose);
         });
       });
@@ -536,7 +536,7 @@ describe('server', function () {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
 
         engine.on('connection', function (conn) {
-          conn.send(null, function () {socket.close();});
+          conn.send(null, function () { socket.close(); });
           conn.send('this should not be handled');
 
           conn.on('close', function (reason) {
@@ -563,7 +563,7 @@ describe('server', function () {
         socket.on('open', function () {
           socket.close();
           // we wait until complete to see if we get an uncaught EPIPE
-          setTimeout(function(){
+          setTimeout(function () {
             done();
           }, 100);
         });
@@ -577,15 +577,15 @@ describe('server', function () {
         // see: https://github.com/driverdan/node-XMLHttpRequest/issues/44
         var request = require('http').request;
         var sockets = [];
-        http.request = function(opts){
+        http.request = function (opts) {
           var req = request.apply(null, arguments);
-          req.on('socket', function(socket){
+          req.on('socket', function (socket) {
             sockets.push(socket);
           });
           return req;
         };
 
-        function done(){
+        function done () {
           http.request = request;
           $done();
         }
@@ -593,13 +593,13 @@ describe('server', function () {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port))
           , serverSocket;
 
-        engine.on('connection', function(s){
+        engine.on('connection', function (s) {
           serverSocket = s;
         });
 
-        socket.transport.on('poll', function(){
+        socket.transport.on('poll', function () {
           // we set a timer to wait for the request to actually reach
-          setTimeout(function(){
+          setTimeout(function () {
             // at this time server's `connection` should have been fired
             expect(serverSocket).to.be.an('object');
 
@@ -615,7 +615,7 @@ describe('server', function () {
 
             // kill the underlying connection
             sockets[1].end();
-            serverSocket.on('close', function(reason, err){
+            serverSocket.on('close', function (reason, err) {
               expect(reason).to.be('transport error');
               expect(err.message).to.be('poll connection closed prematurely');
               done();
@@ -625,34 +625,34 @@ describe('server', function () {
       });
     });
 
-    it('should not trigger with connection: close header', function($done){
-      var engine = listen({ allowUpgrades: false }, function(port){
+    it('should not trigger with connection: close header', function ($done) {
+      var engine = listen({ allowUpgrades: false }, function (port) {
         // intercept requests to add connection: close
         var request = http.request;
-        http.request = function(){
+        http.request = function () {
           var opts = arguments[0];
           opts.headers = opts.headers || {};
           opts.headers.Connection = 'close';
           return request.apply(this, arguments);
         };
 
-        function done(){
+        function done () {
           http.request = request;
           $done();
         }
 
-        engine.on('connection', function(socket){
-          socket.on('message', function(msg){
+        engine.on('connection', function (socket) {
+          socket.on('message', function (msg) {
             expect(msg).to.equal('test');
             socket.send('woot');
           });
         });
 
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
-        socket.on('open', function(){
+        socket.on('open', function () {
           socket.send('test');
         });
-        socket.on('message', function(msg){
+        socket.on('message', function (msg) {
           expect(msg).to.be('woot');
           done();
         });
@@ -668,8 +668,8 @@ describe('server', function () {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         var clientCloseReason = null;
 
-        socket.on('handshake', function() {
-          socket.onPacket = function(){};
+        socket.on('handshake', function () {
+          socket.onPacket = function () {};
         });
         socket.on('open', function () {
           socket.on('close', function (reason) {
@@ -677,7 +677,7 @@ describe('server', function () {
           });
         });
 
-        setTimeout(function() {
+        setTimeout(function () {
           expect(clientCloseReason).to.be(null);
           done();
         }, 200);
@@ -693,9 +693,9 @@ describe('server', function () {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         var clientCloseReason = null;
 
-        engine.on('connection', function(conn){
-          conn.on('heartbeat', function() {
-            conn.onPacket = function(){};
+        engine.on('connection', function (conn) {
+          conn.on('heartbeat', function () {
+            conn.onPacket = function () {};
           });
         });
 
@@ -705,7 +705,7 @@ describe('server', function () {
           });
         });
 
-        setTimeout(function() {
+        setTimeout(function () {
           expect(clientCloseReason).to.be(null);
           done();
         }, 100);
@@ -727,12 +727,12 @@ describe('server', function () {
           });
         });
 
-        engine.on('connection', function(conn){
-          conn.on('heartbeat', function() {
-            setTimeout(function() {
+        engine.on('connection', function (conn) {
+          conn.on('heartbeat', function () {
+            setTimeout(function () {
               conn.close();
             }, 20);
-            setTimeout(function() {
+            setTimeout(function () {
               expect(clientCloseReason).to.be('transport close');
               done();
             }, 100);
@@ -754,16 +754,16 @@ describe('server', function () {
           });
         });
 
-        engine.on('connection', function(conn){
-          conn.once('heartbeat', function() {
-            setTimeout(function() {
-              socket.onPacket = function(){};
+        engine.on('connection', function (conn) {
+          conn.once('heartbeat', function () {
+            setTimeout(function () {
+              socket.onPacket = function () {};
               expect(clientCloseReason).to.be(null);
             }, 150);
-            setTimeout(function() {
+            setTimeout(function () {
               expect(clientCloseReason).to.be(null);
             }, 350);
-            setTimeout(function() {
+            setTimeout(function () {
               expect(clientCloseReason).to.be('ping timeout');
               done();
             }, 500);
@@ -795,15 +795,15 @@ describe('server', function () {
 
     // tests https://github.com/LearnBoost/engine.io-client/issues/207
     // websocket test, transport error
-    it('should trigger transport close before open for ws', function(done){
+    it('should trigger transport close before open for ws', function (done) {
       var opts = { transports: ['websocket'] };
       var engine = listen(opts, function (port) {
         var url = 'ws://%s:%d'.s('0.0.0.50', port);
         var socket = new eioc.Socket(url);
-        socket.on('open', function(){
+        socket.on('open', function () {
           done(new Error('Test invalidation'));
         });
-        socket.on('close', function(reason){
+        socket.on('close', function (reason) {
           expect(reason).to.be('transport error');
           done();
         });
@@ -812,14 +812,14 @@ describe('server', function () {
 
     // tests https://github.com/LearnBoost/engine.io-client/issues/207
     // polling test, transport error
-    it('should trigger transport close before open for xhr', function(done){
+    it('should trigger transport close before open for xhr', function (done) {
       var opts = { transports: ['polling'] };
       var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('http://invalidserver:%d'.s(port));
-        socket.on('open', function(){
+        socket.on('open', function () {
           done(new Error('Test invalidation'));
         });
-        socket.on('close', function(reason){
+        socket.on('close', function (reason) {
           expect(reason).to.be('transport error');
           done();
         });
@@ -828,14 +828,14 @@ describe('server', function () {
 
     // tests https://github.com/LearnBoost/engine.io-client/issues/207
     // websocket test, force close
-    it('should trigger force close before open for ws', function(done){
+    it('should trigger force close before open for ws', function (done) {
       var opts = { transports: ['websocket'] };
       var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
-        socket.on('open', function(){
+        socket.on('open', function () {
           done(new Error('Test invalidation'));
         });
-        socket.on('close', function(reason){
+        socket.on('close', function (reason) {
           expect(reason).to.be('forced close');
           done();
         });
@@ -845,14 +845,14 @@ describe('server', function () {
 
     // tests https://github.com/LearnBoost/engine.io-client/issues/207
     // polling test, force close
-    it('should trigger force close before open for xhr', function(done){
+    it('should trigger force close before open for xhr', function (done) {
       var opts = { transports: ['polling'] };
       var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('http://localhost:%d'.s(port));
-        socket.on('open', function(){
+        socket.on('open', function () {
           done(new Error('Test invalidation'));
         });
-        socket.on('close', function(reason){
+        socket.on('close', function (reason) {
           expect(reason).to.be('forced close');
           done();
         });
@@ -868,7 +868,7 @@ describe('server', function () {
         });
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
         // override to simulate an inactive client
-        socket.sendPacket = socket.onHeartbeat = function (){};
+        socket.sendPacket = socket.onHeartbeat = function () {};
       });
     });
 
@@ -880,7 +880,7 @@ describe('server', function () {
         });
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['polling'] });
         // override to simulate an inactive client
-        socket.sendPacket = socket.onHeartbeat = function (){};
+        socket.sendPacket = socket.onHeartbeat = function () {};
       });
     });
 
@@ -906,7 +906,7 @@ describe('server', function () {
         });
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['polling'] });
         socket.on('open', function () {
-          socket.transport.doWrite('invalid', function (){});
+          socket.transport.doWrite('invalid', function () {});
         });
       });
     });
@@ -934,18 +934,18 @@ describe('server', function () {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         socket.on('upgrading', function (transport) {
           // override not to complete upgrading
-          transport.send = function (){};
+          transport.send = function () {};
         });
       });
     });
 
-    it('should not crash when messing with Object prototype', function(done){
+    it('should not crash when messing with Object prototype', function (done) {
       Object.prototype.foo = 'bar';
       var engine = listen({ allowUpgrades: true }, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         socket.on('open', function () {
           engine.close();
-          setTimeout(function(){
+          setTimeout(function () {
             done();
           }, 100);
         });
@@ -953,20 +953,20 @@ describe('server', function () {
     });
 
     describe('graceful close', function () {
-      function fixture(filename) {
+      function fixture (filename) {
         return process.execPath + ' ' +
           path.join(__dirname, 'fixtures', filename);
       }
 
-      it('should stop socket and timers', function(done){
+      it('should stop socket and timers', function (done) {
         exec(fixture('server-close.js'), done);
       });
 
-      it('should stop upgraded socket and timers', function(done){
+      it('should stop upgraded socket and timers', function (done) {
         exec(fixture('server-close-upgraded.js'), done);
       });
 
-      it('should stop upgrading socket and timers', function(done){
+      it('should stop upgrading socket and timers', function (done) {
         exec(fixture('server-close-upgrading.js'), done);
       });
     });
@@ -1027,12 +1027,12 @@ describe('server', function () {
       });
     });
 
-    it('should not be receiving data when getting a message longer than maxHttpBufferSize when polling', function(done) {
+    it('should not be receiving data when getting a message longer than maxHttpBufferSize when polling', function (done) {
       var opts = { allowUpgrades: false, transports: ['polling'], maxHttpBufferSize: 5 };
       var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         engine.on('connection', function (conn) {
-          conn.on('message', function(msg) {
+          conn.on('message', function (msg) {
             console.log(msg);
           });
         });
@@ -1043,12 +1043,12 @@ describe('server', function () {
       setTimeout(done, 1000);
     });
 
-    it('should receive data when getting a message shorter than maxHttpBufferSize when polling', function(done) {
+    it('should receive data when getting a message shorter than maxHttpBufferSize when polling', function (done) {
       var opts = { allowUpgrades: false, transports: ['polling'], maxHttpBufferSize: 5 };
       var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         engine.on('connection', function (conn) {
-          conn.on('message', function(msg) {
+          conn.on('message', function (msg) {
             expect(msg).to.be('a');
             done();
           });
@@ -1143,7 +1143,7 @@ describe('server', function () {
       }
 
       var opts = { allowUpgrades: false, transports: ['websocket'] };
-      var engine = listen(opts, function(port) {
+      var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
 
         engine.on('connection', function (conn) {
@@ -1151,7 +1151,7 @@ describe('server', function () {
         });
 
         socket.on('open', function () {
-          socket.on('message', function(msg) {
+          socket.on('message', function (msg) {
             for (var i = 0; i < binaryData.length; i++) {
               var num = msg.readInt8(i);
               expect(num).to.be(i);
@@ -1169,7 +1169,7 @@ describe('server', function () {
       }
 
       var opts = { allowUpgrades: false, transports: ['websocket'] };
-      var engine = listen(opts, function(port) {
+      var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
 
         engine.on('connection', function (conn) {
@@ -1177,7 +1177,7 @@ describe('server', function () {
         });
 
         socket.on('open', function () {
-          socket.on('message', function(msg) {
+          socket.on('message', function (msg) {
             for (var i = 0, ii = 0; ii < binaryData.length; i += 4, ii++) {
               var num = msg.readInt32LE(i);
               expect(num).to.be((ii + 100) * 9823);
@@ -1195,7 +1195,7 @@ describe('server', function () {
       }
 
       var opts = { allowUpgrades: false, transports: ['websocket'] };
-      var engine = listen(opts, function(port) {
+      var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
 
         engine.on('connection', function (conn) {
@@ -1203,7 +1203,7 @@ describe('server', function () {
         });
 
         socket.on('open', function () {
-          socket.on('message', function(msg) {
+          socket.on('message', function (msg) {
             for (var i = 0, ii = 0; ii < binaryData.length; i += 4, ii++) {
               var num = msg.readInt32LE(i);
               expect(num).to.be((ii + 100) * 9823);
@@ -1221,7 +1221,7 @@ describe('server', function () {
       }
 
       var opts = { allowUpgrades: false, transports: ['websocket'] };
-      var engine = listen(opts, function(port) {
+      var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
 
         engine.on('connection', function (conn) {
@@ -1229,7 +1229,7 @@ describe('server', function () {
         });
 
         socket.on('open', function () {
-          socket.on('message', function(msg) {
+          socket.on('message', function (msg) {
             for (var i = 0; i < binaryData.length; i++) {
               var num = msg.readInt8(i);
               expect(num).to.be(i);
@@ -1247,15 +1247,15 @@ describe('server', function () {
       }
 
       var opts = { allowUpgrades: false, transports: ['polling'] };
-      var engine = listen(opts, function(port) {
+      var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['polling'] });
 
         engine.on('connection', function (conn) {
           conn.send(binaryData);
         });
 
-        socket.on('open', function() {
-          socket.on('message', function(msg) {
+        socket.on('open', function () {
+          socket.on('message', function (msg) {
             for (var i = 0; i < binaryData.length; i++) {
               var num = msg.readInt8(i);
               expect(num).to.be(i);
@@ -1274,7 +1274,7 @@ describe('server', function () {
       }
 
       var opts = { allowUpgrades: false, transports: ['websocket'] };
-      var engine = listen(opts, function(port) {
+      var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
         socket.binaryType = 'arraybuffer';
 
@@ -1282,8 +1282,8 @@ describe('server', function () {
           conn.send(binaryData);
         });
 
-        socket.on('open', function() {
-          socket.on('message', function(msg) {
+        socket.on('open', function () {
+          socket.on('message', function (msg) {
             expect(msg instanceof ArrayBuffer).to.be(true);
             var intArray = new Int8Array(msg);
             for (var i = 0; i < binaryData.length; i++) {
@@ -1303,7 +1303,7 @@ describe('server', function () {
       }
 
       var opts = { allowUpgrades: false, transports: ['polling'] };
-      var engine = listen(opts, function(port) {
+      var engine = listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['polling'] });
         socket.binaryType = 'arraybuffer';
 
@@ -1311,8 +1311,8 @@ describe('server', function () {
           conn.send(binaryData);
         });
 
-        socket.on('open', function() {
-          socket.on('message', function(msg) {
+        socket.on('open', function () {
+          socket.on('message', function (msg) {
             expect(msg instanceof ArrayBuffer).to.be(true);
             var intArray = new Int8Array(msg);
             for (var i = 0; i < binaryData.length; i++) {
@@ -1326,27 +1326,27 @@ describe('server', function () {
     });
 
 
-    it('should trigger a flush/drain event', function(done){
-      var engine = listen({ allowUpgrades: false }, function(port){
-        engine.on('connection', function(socket){
+    it('should trigger a flush/drain event', function (done) {
+      var engine = listen({ allowUpgrades: false }, function (port) {
+        engine.on('connection', function (socket) {
           var totalEvents = 4;
 
-          engine.on('flush', function(sock, buf){
+          engine.on('flush', function (sock, buf) {
             expect(sock).to.be(socket);
             expect(buf).to.be.an('array');
             --totalEvents || done();
           });
-          socket.on('flush', function(buf){
+          socket.on('flush', function (buf) {
             expect(buf).to.be.an('array');
             --totalEvents || done();
           });
 
-          engine.on('drain', function(sock){
+          engine.on('drain', function (sock) {
             expect(sock).to.be(socket);
             expect(socket.writeBuffer.length).to.be(0);
             --totalEvents || done();
           });
-          socket.on('drain', function(){
+          socket.on('drain', function () {
             expect(socket.writeBuffer.length).to.be(0);
             --totalEvents || done();
           });
@@ -1378,7 +1378,7 @@ describe('server', function () {
         });
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
         socket.on('open', function () {
-          for (var i=0;i<messageCount;i++) {
+          for (var i = 0;i < messageCount;i++) {
 //            connection.send('message: ' + i);   // works
             connection.send(messagePayload + '|message: ' + i);   // does not work
           }
@@ -1393,7 +1393,7 @@ describe('server', function () {
       });
     });
 
-    it('should support chinese', function(done){
+    it('should support chinese', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         var shi = '石室詩士施氏，嗜獅，誓食十獅。';
@@ -1402,23 +1402,23 @@ describe('server', function () {
           conn.send('.');
           conn.send(shi);
           conn.send(shi2);
-          conn.once('message', function(msg0){
+          conn.once('message', function (msg0) {
             expect(msg0).to.be('.');
-            conn.once('message', function(msg){
+            conn.once('message', function (msg) {
               expect(msg).to.be(shi);
-              conn.once('message', function(msg2){
+              conn.once('message', function (msg2) {
                 expect(msg2).to.be(shi2);
                 done();
               });
             });
           });
         });
-        socket.on('open', function(){
-          socket.once('message', function(msg0){
+        socket.on('open', function () {
+          socket.once('message', function (msg0) {
             expect(msg0).to.be('.');
-            socket.once('message', function(msg){
+            socket.once('message', function (msg) {
               expect(msg).to.be(shi);
-              socket.once('message', function(msg2){
+              socket.once('message', function (msg2) {
                 expect(msg2).to.be(shi2);
                 socket.send('.');
                 socket.send(shi);
@@ -1430,7 +1430,7 @@ describe('server', function () {
       });
     });
 
-    it('should send and receive data with key and cert (polling)', function(done){
+    it('should send and receive data with key and cert (polling)', function (done) {
       var srvOpts = {
         key: fs.readFileSync('test/fixtures/server.key'),
         cert: fs.readFileSync('test/fixtures/server.crt'),
@@ -1446,31 +1446,31 @@ describe('server', function () {
         transports: ['polling'],
       };
 
-      var srv = https.createServer(srvOpts, function(req, res){
+      var srv = https.createServer(srvOpts, function (req, res) {
         res.writeHead(200);
         res.end('hello world\n');
       });
 
       var engine = eio({ transports: ['polling'], allowUpgrades: false });
       engine.attach(srv);
-      srv.listen(null, function() {
+      srv.listen(null, function () {
         var port = srv.address().port;
         var socket = new eioc.Socket('https://localhost:%d'.s(port), opts);
 
         engine.on('connection', function (conn) {
-          conn.on('message', function(msg) {
+          conn.on('message', function (msg) {
             expect(msg).to.be('hello');
             done();
           });
         });
 
-        socket.on('open', function() {
+        socket.on('open', function () {
           socket.send('hello');
         });
       });
     });
 
-    it('should send and receive data with ca when not requiring auth (polling)', function(done){
+    it('should send and receive data with ca when not requiring auth (polling)', function (done) {
       var srvOpts = {
         key: fs.readFileSync('test/fixtures/server.key'),
         cert: fs.readFileSync('test/fixtures/server.crt'),
@@ -1483,31 +1483,31 @@ describe('server', function () {
         transports: ['polling']
       };
 
-      var srv = https.createServer(srvOpts, function(req, res){
+      var srv = https.createServer(srvOpts, function (req, res) {
         res.writeHead(200);
         res.end('hello world\n');
       });
 
       var engine = eio({ transports: ['polling'], allowUpgrades: false });
       engine.attach(srv);
-      srv.listen(null, function() {
+      srv.listen(null, function () {
         var port = srv.address().port;
         var socket = new eioc.Socket('https://localhost:%d'.s(port), opts);
 
         engine.on('connection', function (conn) {
-          conn.on('message', function(msg) {
+          conn.on('message', function (msg) {
             expect(msg).to.be('hello');
             done();
           });
         });
 
-        socket.on('open', function() {
+        socket.on('open', function () {
           socket.send('hello');
         });
       });
     });
 
-    it('should send and receive data with key and cert (ws)', function(done){
+    it('should send and receive data with key and cert (ws)', function (done) {
       var srvOpts = {
         key: fs.readFileSync('test/fixtures/server.key'),
         cert: fs.readFileSync('test/fixtures/server.crt'),
@@ -1523,31 +1523,31 @@ describe('server', function () {
         transports: ['websocket']
       };
 
-      var srv = https.createServer(srvOpts, function(req, res){
+      var srv = https.createServer(srvOpts, function (req, res) {
         res.writeHead(200);
         res.end('hello world\n');
       });
 
       var engine = eio({ transports: ['websocket'], allowUpgrades: false });
       engine.attach(srv);
-      srv.listen(null, function() {
+      srv.listen(null, function () {
         var port = srv.address().port;
         var socket = new eioc.Socket('https://localhost:%d'.s(port), opts);
 
         engine.on('connection', function (conn) {
-          conn.on('message', function(msg) {
+          conn.on('message', function (msg) {
             expect(msg).to.be('hello');
             done();
           });
         });
 
-        socket.on('open', function() {
+        socket.on('open', function () {
           socket.send('hello');
         });
       });
     });
 
-    it('should send and receive data with pfx (polling)', function(done){
+    it('should send and receive data with pfx (polling)', function (done) {
       var srvOpts = {
         key: fs.readFileSync('test/fixtures/server.key'),
         cert: fs.readFileSync('test/fixtures/server.crt'),
@@ -1562,31 +1562,31 @@ describe('server', function () {
         transports: ['polling']
       };
 
-      var srv = https.createServer(srvOpts, function(req, res){
+      var srv = https.createServer(srvOpts, function (req, res) {
         res.writeHead(200);
         res.end('hello world\n');
       });
 
       var engine = eio({ transports: ['polling'], allowUpgrades: false });
       engine.attach(srv);
-      srv.listen(null, function() {
+      srv.listen(null, function () {
         var port = srv.address().port;
         var socket = new eioc.Socket('https://localhost:%d'.s(port), opts);
 
         engine.on('connection', function (conn) {
-          conn.on('message', function(msg) {
+          conn.on('message', function (msg) {
             expect(msg).to.be('hello');
             done();
           });
         });
 
-        socket.on('open', function() {
+        socket.on('open', function () {
           socket.send('hello');
         });
       });
     });
 
-    it('should send and receive data with pfx (ws)', function(done){
+    it('should send and receive data with pfx (ws)', function (done) {
       var srvOpts = {
         key: fs.readFileSync('test/fixtures/server.key'),
         cert: fs.readFileSync('test/fixtures/server.crt'),
@@ -1601,44 +1601,44 @@ describe('server', function () {
         transports: ['websocket']
       };
 
-      var srv = https.createServer(srvOpts, function(req, res){
+      var srv = https.createServer(srvOpts, function (req, res) {
         res.writeHead(200);
         res.end('hello world\n');
       });
 
       var engine = eio({ transports: ['websocket'], allowUpgrades: false });
       engine.attach(srv);
-      srv.listen(null, function() {
+      srv.listen(null, function () {
         var port = srv.address().port;
         var socket = new eioc.Socket('https://localhost:%d'.s(port), opts);
 
         engine.on('connection', function (conn) {
-          conn.on('message', function(msg) {
+          conn.on('message', function (msg) {
             expect(msg).to.be('hello');
             done();
           });
         });
 
-        socket.on('open', function() {
+        socket.on('open', function () {
           socket.send('hello');
         });
       });
     });
   });
 
-  describe('send', function() {
-    describe('writeBuffer', function() {
+  describe('send', function () {
+    describe('writeBuffer', function () {
       it('should not empty until `drain` event (polling)', function (done) {
         var engine = listen({ allowUpgrades: false }, function (port) {
           var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['polling'] });
           var totalEvents = 2;
-          socket.on('open', function() {
+          socket.on('open', function () {
             socket.send('a');
             socket.send('b');
             // writeBuffer should be nonempty, with 'a' still in it
             expect(socket.writeBuffer.length).to.eql(2);
           });
-          socket.transport.on('drain', function() {
+          socket.transport.on('drain', function () {
             expect(socket.writeBuffer.length).to.eql(--totalEvents);
             totalEvents || done();
           });
@@ -1649,13 +1649,13 @@ describe('server', function () {
         var engine = listen({ allowUpgrades: false }, function (port) {
           var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
           var totalEvents = 2;
-          socket.on('open', function() {
+          socket.on('open', function () {
             socket.send('a');
             socket.send('b');
             // writeBuffer should be nonempty, with 'a' still in it
             expect(socket.writeBuffer.length).to.eql(2);
           });
-          socket.transport.on('drain', function() {
+          socket.transport.on('drain', function () {
             expect(socket.writeBuffer.length).to.eql(--totalEvents);
             totalEvents || done();
           });
@@ -1663,21 +1663,21 @@ describe('server', function () {
       });
     });
 
-    describe('callback', function() {
+    describe('callback', function () {
       it('should execute in order when message sent (client) (polling)', function (done) {
         var engine = listen({ allowUpgrades: false }, function (port) {
           var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['polling'] });
           var i = 0;
           var j = 0;
 
-          engine.on('connection', function(conn) {
-            conn.on('message', function(msg) {
+          engine.on('connection', function (conn) {
+            conn.on('message', function (msg) {
               conn.send(msg);
             });
           });
 
           socket.on('open', function () {
-            socket.on('message', function(msg) {
+            socket.on('message', function (msg) {
               // send another packet until we've sent 3 total
               if (++i < 3) {
                 expect(i).to.eql(j);
@@ -1687,8 +1687,8 @@ describe('server', function () {
               }
             });
 
-            function sendFn() {
-              socket.send(j, (function(value) {
+            function sendFn () {
+              socket.send(j, (function (value) {
                 j++;
               })(j));
             }
@@ -1704,14 +1704,14 @@ describe('server', function () {
           var i = 0;
           var j = 0;
 
-          engine.on('connection', function(conn) {
-            conn.on('message', function(msg) {
+          engine.on('connection', function (conn) {
+            conn.on('message', function (msg) {
               conn.send(msg);
             });
           });
 
           socket.on('open', function () {
-            socket.on('message', function(msg) {
+            socket.on('message', function (msg) {
               // send another packet until we've sent 3 total
               if (++i < 3) {
                 expect(i).to.eql(j);
@@ -1721,8 +1721,8 @@ describe('server', function () {
               }
             });
 
-            function sendFn() {
-              socket.send(j, (function(value) {
+            function sendFn () {
+              socket.send(j, (function (value) {
                 j++;
               })(j));
             }
@@ -1738,33 +1738,33 @@ describe('server', function () {
           var i = 0;
           var lastCbFired = 0;
 
-          engine.on('connection', function(conn) {
-            conn.on('message', function(msg) {
+          engine.on('connection', function (conn) {
+            conn.on('message', function (msg) {
               conn.send(msg);
             });
           });
 
           socket.on('open', function () {
-            socket.on('message', function(msg) {
+            socket.on('message', function (msg) {
               expect(msg).to.eql(i + 1);
               i++;
             });
 
-            function cb(value) {
+            function cb (value) {
               expect(value).to.eql(lastCbFired + 1);
               lastCbFired = value;
-              if (value == 3) {
+              if (value === 3) {
                 done();
               }
             }
 
             // 2 and 3 will be in the same payload
-            socket.once('flush', function() {
-              socket.send(2, function() { cb(2); });
-              socket.send(3, function() { cb(3); });
+            socket.once('flush', function () {
+              socket.send(2, function () { cb(2); });
+              socket.send(3, function () { cb(3); });
             });
 
-            socket.send(1, function() { cb(1); });
+            socket.send(1, function () { cb(1); });
           });
         });
       });
@@ -1775,33 +1775,33 @@ describe('server', function () {
           var i = 0;
           var lastCbFired = 0;
 
-          engine.on('connection', function(conn) {
-            conn.on('message', function(msg) {
+          engine.on('connection', function (conn) {
+            conn.on('message', function (msg) {
               conn.send(msg);
             });
           });
 
           socket.on('open', function () {
-            socket.on('message', function(msg) {
+            socket.on('message', function (msg) {
               expect(msg).to.eql(i + 1);
               i++;
             });
 
-            function cb(value) {
+            function cb (value) {
               expect(value).to.eql(lastCbFired + 1);
               lastCbFired = value;
-              if (value == 3) {
+              if (value === 3) {
                 done();
               }
             }
 
             // 2 and 3 will be in the same payload
-            socket.once('flush', function() {
-              socket.send(2, function() { cb(2); });
-              socket.send(3, function() { cb(3); });
+            socket.once('flush', function () {
+              socket.send(2, function () { cb(2); });
+              socket.send(3, function () { cb(3); });
             });
 
-            socket.send(1, function() { cb(1); });
+            socket.send(1, function () { cb(1); });
           });
         });
       });
@@ -1823,7 +1823,7 @@ describe('server', function () {
             });
           });
 
-          setTimeout(function() {
+          setTimeout(function () {
             expect(i).to.be(j);
             done();
           }, 100);
@@ -1871,11 +1871,11 @@ describe('server', function () {
 
           socket.on('open', function () {
             socket.on('message', function (msg) {
-              if (msg === 'a') a ++;
-              if (msg === 'b') b ++;
-              if (msg === 'c') c ++;
+              if (msg === 'a') a++;
+              if (msg === 'b') b++;
+              if (msg === 'c') c++;
 
-              if(++all === 3) {
+              if (++all === 3) {
                 expect(a).to.be(1);
                 expect(b).to.be(1);
                 expect(c).to.be(1);
@@ -1983,7 +1983,7 @@ describe('server', function () {
         var engine = listen({ allowUpgrades: false }, function (port) {
           var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['polling'] });
 
-          socket.transport.on('pollComplete', function(msg) {
+          socket.transport.on('pollComplete', function (msg) {
             socket.close();
           });
 
@@ -2002,7 +2002,7 @@ describe('server', function () {
     });
   });
 
-  describe('packet', function() {
+  describe('packet', function () {
     it('should emit when socket receives packet', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
@@ -2033,12 +2033,12 @@ describe('server', function () {
     });
   });
 
-  describe('packetCreate', function() {
+  describe('packetCreate', function () {
     it('should emit before socket send message', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         engine.on('connection', function (conn) {
-          conn.on('packetCreate', function(packet) {
+          conn.on('packetCreate', function (packet) {
             expect(packet.type).to.be('message');
             expect(packet.data).to.be('a');
             done();
@@ -2079,7 +2079,7 @@ describe('server', function () {
           var interval = setInterval(function () {
             lastSent++;
             conn.send(lastSent);
-            if (50 == lastSent) {
+            if (50 === lastSent) {
               clearInterval(interval);
               --ready || finish();
             }
@@ -2116,7 +2116,7 @@ describe('server', function () {
           var interval = setInterval(function () {
             lastSent++;
             socket.send(lastSent);
-            if (50 == lastSent) {
+            if (50 === lastSent) {
               clearInterval(interval);
               --ready || finish();
             }
@@ -2168,13 +2168,13 @@ describe('server', function () {
         http.get({
           port: port,
           path: '/engine.io/default/?transport=polling'
-        }, function(res) {
+        }, function (res) {
           var sid = res.headers['set-cookie'][0].split('=')[1];
           http.get({
             port: port,
             path: '/engine.io/default/?transport=polling&sid=' + sid,
             headers: { 'Accept-Encoding': 'gzip, deflate' }
-          }, function(res) {
+          }, function (res) {
             expect(res.headers['content-encoding']).to.equal('gzip');
             res.pipe(zlib.createGunzip())
               .on('error', done)
@@ -2196,13 +2196,13 @@ describe('server', function () {
         http.get({
           port: port,
           path: '/engine.io/default/?transport=polling'
-        }, function(res) {
+        }, function (res) {
           var sid = res.headers['set-cookie'][0].split('=')[1];
           http.get({
             port: port,
             path: '/engine.io/default/?transport=polling&sid=' + sid,
             headers: { 'Accept-Encoding': 'deflate' }
-          }, function(res) {
+          }, function (res) {
             expect(res.headers['content-encoding']).to.equal('deflate');
             res.pipe(zlib.createDeflate())
               .on('error', done)
@@ -2224,13 +2224,13 @@ describe('server', function () {
         http.get({
           port: port,
           path: '/engine.io/default/?transport=polling'
-        }, function(res) {
+        }, function (res) {
           var sid = res.headers['set-cookie'][0].split('=')[1];
           http.get({
             port: port,
             path: '/engine.io/default/?transport=polling&sid=' + sid,
             headers: { 'Accept-Encoding': 'gzip, deflate' }
-          }, function(res) {
+          }, function (res) {
             expect(res.headers['content-encoding']).to.equal('gzip');
             done();
           });
@@ -2249,13 +2249,13 @@ describe('server', function () {
         http.get({
           port: port,
           path: '/engine.io/default/?transport=polling'
-        }, function(res) {
+        }, function (res) {
           var sid = res.headers['set-cookie'][0].split('=')[1];
           http.get({
             port: port,
             path: '/engine.io/default/?transport=polling&sid=' + sid,
             headers: { 'Accept-Encoding': 'gzip, deflate' }
-          }, function(res) {
+          }, function (res) {
             expect(res.headers['content-encoding']).to.be(undefined);
             done();
           });
@@ -2274,13 +2274,13 @@ describe('server', function () {
         http.get({
           port: port,
           path: '/engine.io/default/?transport=polling'
-        }, function(res) {
+        }, function (res) {
           var sid = res.headers['set-cookie'][0].split('=')[1];
           http.get({
             port: port,
             path: '/engine.io/default/?transport=polling&sid=' + sid,
             headers: { 'Accept-Encoding': 'gzip, deflate' }
-          }, function(res) {
+          }, function (res) {
             expect(res.headers['content-encoding']).to.be(undefined);
             done();
           });
@@ -2299,13 +2299,13 @@ describe('server', function () {
         http.get({
           port: port,
           path: '/engine.io/default/?transport=polling'
-        }, function(res) {
+        }, function (res) {
           var sid = res.headers['set-cookie'][0].split('=')[1];
           http.get({
             port: port,
             path: '/engine.io/default/?transport=polling&sid=' + sid,
             headers: { 'Accept-Encoding': 'gzip, deflate' }
-          }, function(res) {
+          }, function (res) {
             expect(res.headers['content-encoding']).to.be(undefined);
             done();
           });
@@ -2322,7 +2322,7 @@ describe('server', function () {
         engine.on('connection', function (conn) {
           var socket = conn.transport.socket;
           var send = socket.send;
-          socket.send = function(data, opts, callback) {
+          socket.send = function (data, opts, callback) {
             socket.send = send;
             socket.send(data, opts, callback);
 
@@ -2344,7 +2344,7 @@ describe('server', function () {
         engine.on('connection', function (conn) {
           var socket = conn.transport.socket;
           var send = socket.send;
-          socket.send = function(data, opts, callback) {
+          socket.send = function (data, opts, callback) {
             socket.send = send;
             socket.send(data, opts, callback);
 
@@ -2370,7 +2370,7 @@ describe('server', function () {
       'cookie': 'user_session=NI2JlCKF90aE0sJZD9ZzujtdsUqNYSBYxzlTsvdSUe35ZzdtVRGqYFr0kdGxbfc5gUOkR9RGp20GVKza; path=/; expires=Tue, 07-Apr-2015 18:18:08 GMT; secure; HttpOnly'
     };
 
-    function testForTransport(transport, done) {
+    function testForTransport (transport, done) {
       var engine = listen(function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), {
           extraHeaders: headers,
@@ -2396,10 +2396,10 @@ describe('server', function () {
   });
 
   describe('response headers', function () {
-    function testForHeaders(headers, done) {
+    function testForHeaders (headers, done) {
       var engine = listen(function (port) {
         engine.on('connection', function (conn) {
-          conn.transport.once('headers', function(headers) {
+          conn.transport.once('headers', function (headers) {
             expect(headers['X-XSS-Protection']).to.be('0');
             conn.close();
             done();

From a6c4231c1f39a4b898ba3752d82833b78cf962b6 Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Mon, 14 Mar 2016 15:40:22 +0800
Subject: [PATCH 07/11] Eslint lib/ dir manual fix

To note:
- check err instead of !success in lib/server.js:321
- Change while loop with assignment to for loop
---
 lib/server.js                   | 32 +++++++++++++++-----------------
 lib/socket.js                   | 30 +++++++++++++++++++-----------
 lib/transport.js                |  9 +++++----
 lib/transports/polling-jsonp.js |  5 +++--
 lib/transports/polling-xhr.js   |  5 ++---
 lib/transports/polling.js       | 13 +++++++------
 lib/transports/websocket.js     |  9 +++++----
 7 files changed, 56 insertions(+), 47 deletions(-)

diff --git a/lib/server.js b/lib/server.js
index dd727662f..6463b8495 100644
--- a/lib/server.js
+++ b/lib/server.js
@@ -3,16 +3,15 @@
  * Module dependencies.
  */
 
-var qs = require('querystring')
-  , parse = require('url').parse
-  , readFileSync = require('fs').readFileSync
-  , crypto = require('crypto')
-  , base64id = require('base64id')
-  , transports = require('./transports')
-  , EventEmitter = require('events').EventEmitter
-  , Socket = require('./socket')
-  , WebSocketServer = require('ws').Server
-  , debug = require('debug')('engine');
+var qs = require('querystring');
+var parse = require('url').parse;
+var base64id = require('base64id');
+var transports = require('./transports');
+var EventEmitter = require('events').EventEmitter;
+var Socket = require('./socket');
+var WebSocketServer = require('ws').Server;
+var util = require('util');
+var debug = require('debug')('engine');
 
 /**
  * Module exports.
@@ -99,7 +98,7 @@ Server.errorMessages = {
  * Inherits from EventEmitter.
  */
 
-Server.prototype.__proto__ = EventEmitter.prototype;
+util.inherits(Server, EventEmitter);
 
 /**
  * Hash of open clients.
@@ -140,8 +139,9 @@ Server.prototype.verify = function (req, upgrade, fn) {
   // sid check
   var sid = req._query.sid;
   if (sid) {
-    if (!this.clients.hasOwnProperty(sid))
+    if (!this.clients.hasOwnProperty(sid)) {
       return fn(Server.errors.UNKNOWN_SID, false);
+    }
     if (!upgrade && this.clients[sid].transport.name !== transport) {
       debug('bad request: unexpected transport without upgrade');
       return fn(Server.errors.BAD_REQUEST, false);
@@ -277,8 +277,7 @@ Server.prototype.handshake = function (transportName, req) {
     } else {
       transport.supportsBinary = true;
     }
-  }
-  catch (e) {
+  } catch (e) {
     sendErrorMessage(req, req.res, Server.errors.BAD_REQUEST);
     return;
   }
@@ -319,7 +318,7 @@ Server.prototype.handleUpgrade = function (req, socket, upgradeHead) {
 
   var self = this;
   this.verify(req, true, function (err, success) {
-    if (!success) {
+    if (err) {
       socket.end();
       return;
     }
@@ -406,10 +405,9 @@ Server.prototype.onWebSocket = function (req, socket) {
 
 Server.prototype.attach = function (server, options) {
   var self = this;
-  var options = options || {};
+  options = options || {};
   var path = (options.path || '/engine.io').replace(/\/$/, '');
 
-  var destroyUpgrade = (options.destroyUpgrade !== undefined) ? options.destroyUpgrade : true;
   var destroyUpgradeTimeout = options.destroyUpgradeTimeout || 1000;
 
   // normalize path
diff --git a/lib/socket.js b/lib/socket.js
index cc6bc0204..be97d3d35 100644
--- a/lib/socket.js
+++ b/lib/socket.js
@@ -3,6 +3,7 @@
  */
 
 var EventEmitter = require('events').EventEmitter;
+var util = require('util');
 var debug = require('debug')('engine:socket');
 
 /**
@@ -44,7 +45,7 @@ function Socket (id, server, transport, req) {
  * Inherits from EventEmitter.
  */
 
-Socket.prototype.__proto__ = EventEmitter.prototype;
+util.inherits(Socket, EventEmitter);
 
 /**
  * Called upon transport considered open.
@@ -58,10 +59,10 @@ Socket.prototype.onOpen = function () {
   // sends an `open` packet
   this.transport.sid = this.id;
   this.sendPacket('open', JSON.stringify({
-    sid: this.id
-    , upgrades: this.getAvailableUpgrades()
-    , pingInterval: this.server.pingInterval
-    , pingTimeout: this.server.pingTimeout
+    sid: this.id,
+    upgrades: this.getAvailableUpgrades(),
+    pingInterval: this.server.pingInterval,
+    pingTimeout: this.server.pingTimeout
   }));
 
   this.emit('open');
@@ -151,7 +152,7 @@ Socket.prototype.setTransport = function (transport) {
   this.transport.on('packet', onPacket);
   this.transport.on('drain', flush);
   this.transport.once('close', onClose);
-  //this function will manage packet events (also message callbacks)
+  // this function will manage packet events (also message callbacks)
   this.setupSendCallback();
 
   this.cleanupFn.push(function () {
@@ -266,7 +267,13 @@ Socket.prototype.maybeUpgrade = function (transport) {
 
 Socket.prototype.clearTransport = function () {
   var cleanup;
-  while (cleanup = this.cleanupFn.shift()) cleanup();
+
+  var toCleanUp = this.cleanupFn.length;
+
+  for (var i = 0; i < toCleanUp; i++) {
+    cleanup = this.cleanupFn.shift();
+    cleanup();
+  }
 
   // silence further transport errors and prevent uncaught exceptions
   this.transport.on('error', function () {
@@ -319,7 +326,7 @@ Socket.prototype.setupSendCallback = function () {
     self.transport.removeListener('drain', onDrain);
   });
 
-  //the message was sent successfully, execute the callback
+  // the message was sent successfully, execute the callback
   function onDrain () {
     if (self.sentCallbackFn.length > 0) {
       var seqFn = self.sentCallbackFn.splice(0, 1)[0];
@@ -386,7 +393,7 @@ Socket.prototype.sendPacket = function (type, data, options, callback) {
 
     this.writeBuffer.push(packet);
 
-    //add send callback to object
+    // add send callback to object
     this.packetsFn.push(callback);
 
     this.flush();
@@ -400,8 +407,9 @@ Socket.prototype.sendPacket = function (type, data, options, callback) {
  */
 
 Socket.prototype.flush = function () {
-  if ('closed' !== this.readyState && this.transport.writable
-    && this.writeBuffer.length) {
+  if ('closed' !== this.readyState &&
+                this.transport.writable &&
+                this.writeBuffer.length) {
     debug('flushing buffer to transport');
     this.emit('flush', this.writeBuffer);
     this.server.emit('flush', this, this.writeBuffer);
diff --git a/lib/transport.js b/lib/transport.js
index 28848b59c..0da2716de 100644
--- a/lib/transport.js
+++ b/lib/transport.js
@@ -3,9 +3,10 @@
  * Module dependencies.
  */
 
-var EventEmitter = require('events').EventEmitter
-  , parser = require('engine.io-parser')
-  , debug = require('debug')('engine:transport');
+var EventEmitter = require('events').EventEmitter;
+var parser = require('engine.io-parser');
+var util = require('util');
+var debug = require('debug')('engine:transport');
 
 /**
  * Expose the constructor.
@@ -37,7 +38,7 @@ function Transport (req) {
  * Inherits from EventEmitter.
  */
 
-Transport.prototype.__proto__ = EventEmitter.prototype;
+util.inherits(Transport, EventEmitter);
 
 /**
  * Flags the transport as discarded.
diff --git a/lib/transports/polling-jsonp.js b/lib/transports/polling-jsonp.js
index f8cc2bba1..62e66e779 100644
--- a/lib/transports/polling-jsonp.js
+++ b/lib/transports/polling-jsonp.js
@@ -7,6 +7,7 @@ var Polling = require('./polling');
 var qs = require('querystring');
 var rDoubleSlashes = /\\\\n/g;
 var rSlashes = /(\\)?\\n/g;
+var util = require('util');
 
 /**
  * Module exports.
@@ -31,7 +32,7 @@ function JSONP (req) {
  * Inherits from Polling.
  */
 
-JSONP.prototype.__proto__ = Polling.prototype;
+util.inherits(JSONP, Polling);
 
 /**
  * Handles incoming data.
@@ -45,7 +46,7 @@ JSONP.prototype.onData = function (data) {
   // and the fast alternative to decodeURIComponent
   data = qs.parse(data).d;
   if ('string' === typeof data) {
-    //client will send already escaped newlines as \\\\n and newlines as \\n
+    // client will send already escaped newlines as \\\\n and newlines as \\n
     // \\n must be replaced with \n and \\\\n with \\n
     data = data.replace(rSlashes, function (match, slashes) {
       return slashes ? match : '\n';
diff --git a/lib/transports/polling-xhr.js b/lib/transports/polling-xhr.js
index 4038280f2..d74584692 100644
--- a/lib/transports/polling-xhr.js
+++ b/lib/transports/polling-xhr.js
@@ -4,8 +4,7 @@
  */
 
 var Polling = require('./polling');
-var Transport = require('../transport');
-var debug = require('debug')('engine:polling-xhr');
+var util = require('util');
 
 /**
  * Module exports.
@@ -27,7 +26,7 @@ function XHR (req) {
  * Inherits from Polling.
  */
 
-XHR.prototype.__proto__ = Polling.prototype;
+util.inherits(XHR, Polling);
 
 /**
  * Overrides `onRequest` to handle `OPTIONS`..
diff --git a/lib/transports/polling.js b/lib/transports/polling.js
index 26f67257d..17e84a54f 100644
--- a/lib/transports/polling.js
+++ b/lib/transports/polling.js
@@ -3,11 +3,12 @@
  * Module requirements.
  */
 
-var Transport = require('../transport')
-  , parser = require('engine.io-parser')
-  , zlib = require('zlib')
-  , accepts = require('accepts')
-  , debug = require('debug')('engine:polling');
+var Transport = require('../transport');
+var parser = require('engine.io-parser');
+var zlib = require('zlib');
+var accepts = require('accepts');
+var util = require('util');
+var debug = require('debug')('engine:polling');
 
 var compressionMethods = {
   gzip: zlib.createGzip,
@@ -40,7 +41,7 @@ function Polling (req) {
  * @api public.
  */
 
-Polling.prototype.__proto__ = Transport.prototype;
+util.inherits(Polling, Transport);
 
 /**
  * Transport name
diff --git a/lib/transports/websocket.js b/lib/transports/websocket.js
index 5c1af933d..330fd4e38 100644
--- a/lib/transports/websocket.js
+++ b/lib/transports/websocket.js
@@ -3,9 +3,10 @@
  * Module dependencies.
  */
 
-var Transport = require('../transport')
-  , parser = require('engine.io-parser')
-  , debug = require('debug')('engine:ws');
+var Transport = require('../transport');
+var parser = require('engine.io-parser');
+var util = require('util');
+var debug = require('debug')('engine:ws');
 
 /**
  * Export the constructor.
@@ -38,7 +39,7 @@ function WebSocket (req) {
  * Inherits from Transport.
  */
 
-WebSocket.prototype.__proto__ = Transport.prototype;
+util.inherits(WebSocket, Transport);
 
 /**
  * Transport name

From bfee8f1e6cd0b743839584585a81cf6b8cbeb2a6 Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Sun, 20 Mar 2016 16:45:53 +0800
Subject: [PATCH 08/11] ESLint examples/ manual fix

---
 examples/latency/index.js        | 10 +++++-----
 examples/latency/public/index.js | 13 ++++++-------
 2 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/examples/latency/index.js b/examples/latency/index.js
index cae791c3b..2622a1a13 100644
--- a/examples/latency/index.js
+++ b/examples/latency/index.js
@@ -3,11 +3,11 @@
  * Module dependencies.
  */
 
-var express = require('express')
-  , app = express()
-  , server = require('http').createServer(app)
-  , enchilada = require('enchilada')
-  , io = require('engine.io').attach(server);
+var express = require('express');
+var app = express();
+var server = require('http').createServer(app);
+var enchilada = require('enchilada');
+var io = require('engine.io').attach(server);
 
 app.use(enchilada({
   src: __dirname + '/public',
diff --git a/examples/latency/public/index.js b/examples/latency/public/index.js
index b89ba222d..d64f8efd2 100644
--- a/examples/latency/public/index.js
+++ b/examples/latency/public/index.js
@@ -3,10 +3,9 @@
  * Module dependencies.
  */
 
-var SmoothieChart = require('smoothie').SmoothieChart
-  , TimeSeries = require('smoothie').TimeSeries
-  , eio = require('engine.io-client');
-
+var SmoothieChart = require('smoothie').SmoothieChart;
+var TimeSeries = require('smoothie').TimeSeries;
+var eio = require('engine.io-client');
 
 // helper
 
@@ -34,7 +33,7 @@ function render () {
 var socket = new eio.Socket();
 var last;
 function send () {
-  last = new Date;
+  last = new Date();
   socket.send('ping');
   $('transport').innerHTML = socket.transport.name;
 }
@@ -50,8 +49,8 @@ socket.on('close', function () {
   $('transport').innerHTML = '(disconnected)';
 });
 socket.on('message', function () {
-  var latency = new Date - last;
+  var latency = new Date() - last;
   $('latency').innerHTML = latency + 'ms';
-  if (time) time.append(+new Date, latency);
+  if (time) time.append(+new Date(), latency);
   setTimeout(send, 100);
 });

From 83951035d614881b8a9ecdeee2853c0fc4f6f274 Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Tue, 22 Mar 2016 23:13:20 +0800
Subject: [PATCH 09/11] Eslint test/ manual fix

---
 test/engine.io.js |  72 +++++++++++-----------
 test/jsonp.js     |  38 ++++++------
 test/server.js    | 150 ++++++++++++++++++++++------------------------
 3 files changed, 126 insertions(+), 134 deletions(-)

diff --git a/test/engine.io.js b/test/engine.io.js
index 2dd511736..e323c92be 100644
--- a/test/engine.io.js
+++ b/test/engine.io.js
@@ -15,7 +15,6 @@ var http = require('http');
  */
 
 describe('engine', function () {
-
   it('should expose protocol number', function () {
     expect(eio.protocol).to.be.a('number');
   });
@@ -35,7 +34,7 @@ describe('engine', function () {
 
   describe('listen', function () {
     it('should open a http server that returns 501', function (done) {
-      var server = listen(function (port) {
+      listen(function (port) {
         request.get('http://localhost:%d/'.s(port), function (res) {
           expect(res.status).to.be(501);
           done();
@@ -53,15 +52,15 @@ describe('engine', function () {
     });
 
     it('should return an engine.Server', function () {
-      var server = http.createServer()
-        , engine = eio.attach(server);
+      var server = http.createServer();
+      var engine = eio.attach(server);
 
       expect(engine).to.be.an(eio.Server);
     });
 
     it('should attach engine to an http server', function (done) {
-      var server = http.createServer()
-        , engine = eio.attach(server);
+      var server = http.createServer();
+      eio.attach(server);
 
       server.listen(function () {
         var uri = 'http://localhost:%d/engine.io/default/'.s(server.address().port);
@@ -76,17 +75,17 @@ describe('engine', function () {
     });
 
     it('should destroy upgrades not handled by engine', function (done) {
-      var server = http.createServer()
-        , engine = eio.attach(server);
+      var server = http.createServer();
+      eio.attach(server);
 
       server.listen(function () {
         var client = net.createConnection(server.address().port);
         client.setEncoding('ascii');
         client.write([
-          'GET / HTTP/1.1'
-          , 'Connection: Upgrade'
-          , 'Upgrade: IRC/6.9'
-          , '', ''
+          'GET / HTTP/1.1',
+          'Connection: Upgrade',
+          'Upgrade: IRC/6.9',
+          '', ''
         ].join('\r\n'));
 
         var check = setTimeout(function () {
@@ -101,21 +100,21 @@ describe('engine', function () {
     });
 
     it('should not destroy unhandled upgrades with destroyUpgrade:false', function (done) {
-      var server = http.createServer()
-        , engine = eio.attach(server, { destroyUpgrade: false, destroyUpgradeTimeout: 50 });
+      var server = http.createServer();
+      eio.attach(server, { destroyUpgrade: false, destroyUpgradeTimeout: 50 });
 
       server.listen(function () {
         var client = net.createConnection(server.address().port);
         client.on('connect', function () {
           client.setEncoding('ascii');
           client.write([
-            'GET / HTTP/1.1'
-            , 'Connection: Upgrade'
-            , 'Upgrade: IRC/6.9'
-            , '', ''
+            'GET / HTTP/1.1',
+            'Connection: Upgrade',
+            'Upgrade: IRC/6.9',
+            '', ''
           ].join('\r\n'));
 
-          var check = setTimeout(function () {
+          setTimeout(function () {
             client.removeListener('end', onEnd);
             done();
           }, 100);
@@ -130,18 +129,18 @@ describe('engine', function () {
     });
 
     it('should destroy unhandled upgrades with after a timeout', function (done) {
-      var server = http.createServer()
-        , engine = eio.attach(server, { destroyUpgradeTimeout: 200 });
+      var server = http.createServer();
+      eio.attach(server, { destroyUpgradeTimeout: 200 });
 
       server.listen(function () {
         var client = net.createConnection(server.address().port);
         client.on('connect', function () {
           client.setEncoding('ascii');
           client.write([
-            'GET / HTTP/1.1'
-            , 'Connection: Upgrade'
-            , 'Upgrade: IRC/6.9'
-            , '', ''
+            'GET / HTTP/1.1',
+            'Connection: Upgrade',
+            'Upgrade: IRC/6.9',
+            '', ''
           ].join('\r\n'));
 
           // send from client to server
@@ -161,8 +160,8 @@ describe('engine', function () {
     });
 
     it('should not destroy handled upgrades with after a timeout', function (done) {
-      var server = http.createServer()
-        , engine = eio.attach(server, { destroyUpgradeTimeout: 100 });
+      var server = http.createServer();
+      eio.attach(server, { destroyUpgradeTimeout: 100 });
 
       // write to the socket to keep engine.io from closing it by writing before the timeout
       server.on('upgrade', function (req, socket) {
@@ -179,10 +178,10 @@ describe('engine', function () {
         client.on('connect', function () {
           client.setEncoding('ascii');
           client.write([
-            'GET / HTTP/1.1'
-            , 'Connection: Upgrade'
-            , 'Upgrade: IRC/6.9'
-            , '', ''
+            'GET / HTTP/1.1',
+            'Connection: Upgrade',
+            'Upgrade: IRC/6.9',
+            '', ''
           ].join('\r\n'));
 
           // test that socket is still open by writing after the timeout period
@@ -199,11 +198,11 @@ describe('engine', function () {
     });
 
     it('should preserve original request listeners', function (done) {
-      var listeners = 0
-        , server = http.createServer(function (req, res) {
-          expect(req && res).to.be.ok();
-          listeners++;
-        });
+      var listeners = 0;
+      var server = http.createServer(function (req, res) {
+        expect(req && res).to.be.ok();
+        listeners++;
+      });
 
       server.on('request', function (req, res) {
         expect(req && res).to.be.ok();
@@ -230,5 +229,4 @@ describe('engine', function () {
       });
     });
   });
-
 });
diff --git a/test/jsonp.js b/test/jsonp.js
index b80a5ee45..b0ca0d973 100644
--- a/test/jsonp.js
+++ b/test/jsonp.js
@@ -3,17 +3,15 @@
  * Module dependencies.
  */
 
-var http = require('http');
 var eioc = require('engine.io-client');
 var listen = require('./common').listen;
 var expect = require('expect.js');
 var request = require('superagent');
-var WebSocket = require('ws');
 
 describe('JSONP', function () {
   before(function () {
     // we have to override the browser's functionality for JSONP
-    document = {
+    document = { // eslint-disable-line no-native-reassign, no-undef
       body: {
         appendChild: function () {},
         removeChild: function () {}
@@ -32,7 +30,7 @@ describe('JSONP', function () {
 
         script.__defineSetter__('src', function (uri) {
           request.get(uri).end(function (res) {
-            eval(res.text);
+            eval(res.text); // eslint-disable-line no-eval
           });
         });
         return script;
@@ -56,7 +54,7 @@ describe('JSONP', function () {
       } else if ('textarea' === name) {
         var textarea = {};
 
-        //a hack to be able to access the area data when form is sent
+        // a hack to be able to access the area data when form is sent
         textarea.__defineSetter__('value', function (data) {
           self.areaValue = data;
         });
@@ -83,16 +81,16 @@ describe('JSONP', function () {
   });
 
   after(function () {
-    delete document.getElementsByTagName
-      , document.createElement;
+    delete document.getElementsByTagName;
+    delete document.createElement;
     delete global.document;
   });
 
   describe('handshake', function () {
     it('should open with polling JSONP when requested', function (done) {
-      var engine = listen( { allowUpgrades: false, transports: ['polling'] }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:' + port
-          , { transports: ['polling'], forceJSONP: true, upgrade: false });
+      var engine = listen({ allowUpgrades: false, transports: ['polling'] }, function (port) {
+        eioc('ws://localhost:' + port,
+          { transports: ['polling'], forceJSONP: true, upgrade: false });
         engine.on('connection', function (socket) {
           expect(socket.transport.name).to.be('polling');
           expect(socket.transport.head).to.be('___eio[0](');
@@ -106,7 +104,7 @@ describe('JSONP', function () {
     var engine, port, socket;
 
     beforeEach(function (done) {
-      engine = listen( { allowUpgrades: false, transports: ['polling'] }, function (p) {
+      engine = listen({ allowUpgrades: false, transports: ['polling'] }, function (p) {
         port = p;
 
         socket = new eioc.Socket('ws://localhost:' + port
@@ -136,12 +134,12 @@ describe('JSONP', function () {
     it('should not fail JSON.parse for stringified messages', function (done) {
       engine.on('connection', function (conn) {
         conn.on('message', function (message) {
-          expect(JSON.parse(message)).to.be.eql({test : 'a\r\nb\n\n\n\nc'});
+          expect(JSON.parse(message)).to.be.eql({test: 'a\r\nb\n\n\n\nc'});
           done();
         });
       });
       socket.on('open', function () {
-        socket.send(JSON.stringify({test : 'a\r\nb\n\n\n\nc'}));
+        socket.send(JSON.stringify({test: 'a\r\nb\n\n\n\nc'}));
       });
     });
 
@@ -178,10 +176,10 @@ describe('JSONP', function () {
 
   describe('close', function () {
     it('should trigger when server closes a client', function (done) {
-      var engine = listen( { allowUpgrades: false, transports: ['polling'] }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:' + port
-            , { transports: ['polling'], forceJSONP: true, upgrade: false })
-            , total = 2;
+      var engine = listen({ allowUpgrades: false, transports: ['polling'] }, function (port) {
+        var socket = new eioc.Socket('ws://localhost:' + port,
+            { transports: ['polling'], forceJSONP: true, upgrade: false });
+        var total = 2;
 
         engine.on('connection', function (conn) {
           conn.on('close', function (reason) {
@@ -203,10 +201,10 @@ describe('JSONP', function () {
     });
 
     it('should trigger when client closes', function (done) {
-      var engine = listen( { allowUpgrades: false, transports: ['polling'] }, function (port) {
+      var engine = listen({ allowUpgrades: false, transports: ['polling'] }, function (port) {
         var socket = new eioc.Socket('ws://localhost:' + port
-          , { transports: ['polling'], forceJSONP: true, upgrade: false })
-          , total = 2;
+          , { transports: ['polling'], forceJSONP: true, upgrade: false });
+        var total = 2;
 
         engine.on('connection', function (conn) {
           conn.on('close', function (reason) {
diff --git a/test/server.js b/test/server.js
index 5736e4a54..7b1ad70c7 100644
--- a/test/server.js
+++ b/test/server.js
@@ -14,7 +14,6 @@ var eioc = require('engine.io-client');
 var listen = require('./common').listen;
 var expect = require('expect.js');
 var request = require('superagent');
-var WebSocket = require('ws');
 
 // are we running on node 0.8?
 var NODE_0_8 = /^v0\.8\./.test(process.version);
@@ -24,10 +23,9 @@ var NODE_0_8 = /^v0\.8\./.test(process.version);
  */
 
 describe('server', function () {
-
   describe('verification', function () {
     it('should disallow non-existent transports', function (done) {
-      var engine = listen(function (port) {
+      listen(function (port) {
         request.get('http://localhost:%d/engine.io/default/'.s(port))
           .query({ transport: 'tobi' }) // no tobi transport - outrageous
           .end(function (res) {
@@ -42,7 +40,7 @@ describe('server', function () {
 
     it('should disallow `constructor` as transports', function (done) {
       // make sure we check for actual properties - not those present on every {}
-      var engine = listen(function (port) {
+      listen(function (port) {
         request.get('http://localhost:%d/engine.io/default/'.s(port))
           .set('Origin', 'http://engine.io')
           .query({ transport: 'constructor' })
@@ -58,7 +56,7 @@ describe('server', function () {
     });
 
     it('should disallow non-existent sids', function (done) {
-      var engine = listen(function (port) {
+      listen(function (port) {
         request.get('http://localhost:%d/engine.io/default/'.s(port))
           .set('Origin', 'http://engine.io')
           .query({ transport: 'polling', sid: 'test' })
@@ -76,7 +74,7 @@ describe('server', function () {
 
   describe('handshake', function () {
     it('should send the io cookie', function (done) {
-      var engine = listen(function (port) {
+      listen(function (port) {
         request.get('http://localhost:%d/engine.io/default/'.s(port))
           .query({ transport: 'polling', b64: 1 })
           .end(function (res) {
@@ -89,7 +87,7 @@ describe('server', function () {
     });
 
     it('should send the io cookie custom name', function (done) {
-      var engine = listen({ cookie: 'woot' }, function (port) {
+      listen({ cookie: 'woot' }, function (port) {
         request.get('http://localhost:%d/engine.io/default/'.s(port))
           .query({ transport: 'polling', b64: 1 })
           .end(function (res) {
@@ -101,7 +99,7 @@ describe('server', function () {
     });
 
     it('should send the cookie with custom path', function (done) {
-      var engine = listen({ cookiePath: '/' }, function (port) {
+      listen({ cookiePath: '/' }, function (port) {
         request.get('http://localhost:%d/engine.io/default/'.s(port))
           .query({ transport: 'polling', b64: 1 })
           .end(function (res) {
@@ -113,7 +111,7 @@ describe('server', function () {
     });
 
     it('should not send the io cookie', function (done) {
-      var engine = listen({ cookie: false }, function (port) {
+      listen({ cookie: false }, function (port) {
         request.get('http://localhost:%d/engine.io/default/'.s(port))
           .query({ transport: 'polling' })
           .end(function (res) {
@@ -160,7 +158,7 @@ describe('server', function () {
     });
 
     it('should exchange handshake data', function (done) {
-      var engine = listen({ allowUpgrades: false }, function (port) {
+      listen({ allowUpgrades: false }, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         socket.on('handshake', function (obj) {
           expect(obj.sid).to.be.a('string');
@@ -172,7 +170,7 @@ describe('server', function () {
     });
 
     it('should allow custom ping timeouts', function (done) {
-      var engine = listen({ allowUpgrades: false, pingTimeout: 123 }, function (port) {
+      listen({ allowUpgrades: false, pingTimeout: 123 }, function (port) {
         var socket = new eioc.Socket('http://localhost:%d'.s(port));
         socket.on('handshake', function (obj) {
           expect(obj.pingTimeout).to.be(123);
@@ -183,7 +181,7 @@ describe('server', function () {
 
     it('should trigger a connection event with a Socket', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port));
+        eioc('ws://localhost:%d'.s(port));
         engine.on('connection', function (socket) {
           expect(socket).to.be.an(eio.Socket);
           done();
@@ -193,7 +191,7 @@ describe('server', function () {
 
     it('should open with polling by default', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port));
+        eioc('ws://localhost:%d'.s(port));
         engine.on('connection', function (socket) {
           expect(socket.transport.name).to.be('polling');
           done();
@@ -203,7 +201,7 @@ describe('server', function () {
 
     it('should be able to open with ws directly', function (done) {
       var engine = listen({ transports: ['websocket'] }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
+        eioc('ws://localhost:%d'.s(port), { transports: ['websocket'] });
         engine.on('connection', function (socket) {
           expect(socket.transport.name).to.be('websocket');
           done();
@@ -212,7 +210,7 @@ describe('server', function () {
     });
 
     it('should not suggest any upgrades for websocket', function (done) {
-      var engine = listen({ transports: ['websocket'] }, function (port) {
+      listen({ transports: ['websocket'] }, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
         socket.on('handshake', function (obj) {
           expect(obj.upgrades).to.have.length(0);
@@ -222,7 +220,7 @@ describe('server', function () {
     });
 
     it('should not suggest upgrades when none are availble', function (done) {
-      var engine = listen({ transports: ['polling'] }, function (port) {
+      listen({ transports: ['polling'] }, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { });
         socket.on('handshake', function (obj) {
           expect(obj.upgrades).to.have.length(0);
@@ -232,7 +230,7 @@ describe('server', function () {
     });
 
     it('should only suggest available upgrades', function (done) {
-      var engine = listen({ transports: ['polling'] }, function (port) {
+      listen({ transports: ['polling'] }, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { });
         socket.on('handshake', function (obj) {
           expect(obj.upgrades).to.have.length(0);
@@ -242,7 +240,7 @@ describe('server', function () {
     });
 
     it('should suggest all upgrades when no transports are disabled', function (done) {
-      var engine = listen({}, function (port) {
+      listen({}, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { });
         socket.on('handshake', function (obj) {
           expect(obj.upgrades).to.have.length(1);
@@ -254,7 +252,6 @@ describe('server', function () {
 
     it('default to polling when proxy doesn\'t support websocket', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
-
         engine.on('connection', function (socket) {
           socket.on('message', function (msg) {
             if ('echo' === msg) socket.send(msg);
@@ -282,7 +279,7 @@ describe('server', function () {
 
     it('should allow arbitrary data through query string', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { query: { a: 'b' } });
+        eioc('ws://localhost:%d'.s(port), { query: { a: 'b' } });
         engine.on('connection', function (conn) {
           expect(conn.request._query).to.have.keys('transport', 'a');
           expect(conn.request._query.a).to.be('b');
@@ -293,7 +290,7 @@ describe('server', function () {
 
     it('should allow data through query string in uri', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d?a=b&c=d'.s(port));
+        eioc('ws://localhost:%d?a=b&c=d'.s(port));
         engine.on('connection', function (conn) {
           expect(conn.request._query.EIO).to.be.a('string');
           expect(conn.request._query.a).to.be('b');
@@ -303,10 +300,8 @@ describe('server', function () {
       });
     });
 
-
-
     it('should disallow bad requests', function (done) {
-      var engine = listen(function (port) {
+      listen(function (port) {
         request.get('http://localhost:%d/engine.io/default/'.s(port))
           .set('Origin', 'http://engine.io')
           .query({ transport: 'websocket' })
@@ -326,7 +321,7 @@ describe('server', function () {
     it('should be able to access non-empty writeBuffer at closing (server)', function (done) {
       var opts = {allowUpgrades: false};
       var engine = listen(opts, function (port) {
-        var socket = new eioc.Socket('http://localhost:%d'.s(port));
+        eioc('http://localhost:%d'.s(port));
         engine.on('connection', function (conn) {
           conn.on('close', function (reason) {
             expect(conn.writeBuffer.length).to.be(1);
@@ -335,7 +330,7 @@ describe('server', function () {
             }, 10);
             done();
           });
-          conn.writeBuffer.push({ type: 'message', data: 'foo'});
+          conn.writeBuffer.push({ type: 'message', data: 'foo' });
           conn.onError('');
         });
       });
@@ -343,7 +338,7 @@ describe('server', function () {
 
     it('should be able to access non-empty writeBuffer at closing (client)', function (done) {
       var opts = {allowUpgrades: false};
-      var engine = listen(opts, function (port) {
+      listen(opts, function (port) {
         var socket = new eioc.Socket('http://localhost:%d'.s(port));
         socket.on('open', function () {
           socket.on('close', function (reason) {
@@ -353,7 +348,7 @@ describe('server', function () {
             }, 10);
             done();
           });
-          socket.writeBuffer.push({ type: 'message', data: 'foo'});
+          socket.writeBuffer.push({ type: 'message', data: 'foo' });
           socket.onError('');
         });
       });
@@ -393,7 +388,7 @@ describe('server', function () {
 
     it('should trigger on client if server does not meet ping timeout', function (done) {
       var opts = { allowUpgrades: false, pingInterval: 50, pingTimeout: 30 };
-      var engine = listen(opts, function (port) {
+      listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         socket.on('open', function () {
           // override onPacket and Transport#onClose to simulate an inactive server after handshake
@@ -410,8 +405,8 @@ describe('server', function () {
     it('should trigger on both ends upon ping timeout', function (done) {
       var opts = { allowUpgrades: false, pingTimeout: 10, pingInterval: 10 };
       var engine = listen(opts, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port))
-          , total = 2;
+        var socket = new eioc.Socket('ws://localhost:%d'.s(port));
+        var total = 2;
 
         function onClose (reason, err) {
           expect(reason).to.be('ping timeout');
@@ -433,8 +428,8 @@ describe('server', function () {
 
     it('should trigger when server closes a client', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port))
-          , total = 2;
+        var socket = new eioc.Socket('ws://localhost:%d'.s(port));
+        var total = 2;
 
         engine.on('connection', function (conn) {
           conn.on('close', function (reason) {
@@ -458,8 +453,8 @@ describe('server', function () {
     it('should trigger when server closes a client (ws)', function (done) {
       var opts = { allowUpgrades: false, transports: ['websocket'] };
       var engine = listen(opts, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] })
-          , total = 2;
+        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
+        var total = 2;
 
         engine.on('connection', function (conn) {
           conn.on('close', function (reason) {
@@ -482,8 +477,8 @@ describe('server', function () {
 
     it('should trigger when client closes', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port))
-          , total = 2;
+        var socket = new eioc.Socket('ws://localhost:%d'.s(port));
+        var total = 2;
 
         engine.on('connection', function (conn) {
           conn.on('close', function (reason) {
@@ -508,8 +503,8 @@ describe('server', function () {
     it('should trigger when client closes (ws)', function (done) {
       var opts = { allowUpgrades: false, transports: ['websocket'] };
       var engine = listen(opts, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] })
-          , total = 2;
+        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
+        var total = 2;
 
         engine.on('connection', function (conn) {
           conn.on('close', function (reason) {
@@ -558,7 +553,7 @@ describe('server', function () {
     });
 
     it('should abort upgrade if socket is closed (GH-35)', function (done) {
-      var engine = listen({ allowUpgrades: true }, function (port) {
+      listen({ allowUpgrades: true }, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         socket.on('open', function () {
           socket.close();
@@ -590,8 +585,8 @@ describe('server', function () {
           $done();
         }
 
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port))
-          , serverSocket;
+        var socket = new eioc.Socket('ws://localhost:%d'.s(port));
+        var serverSocket;
 
         engine.on('connection', function (s) {
           serverSocket = s;
@@ -664,7 +659,7 @@ describe('server', function () {
       // first timeout should trigger after `pingInterval + pingTimeout`,
       // not just `pingTimeout`.
       var opts = { allowUpgrades: false, pingInterval: 300, pingTimeout: 100 };
-      var engine = listen(opts, function (port) {
+      listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         var clientCloseReason = null;
 
@@ -797,7 +792,7 @@ describe('server', function () {
     // websocket test, transport error
     it('should trigger transport close before open for ws', function (done) {
       var opts = { transports: ['websocket'] };
-      var engine = listen(opts, function (port) {
+      listen(opts, function (port) {
         var url = 'ws://%s:%d'.s('0.0.0.50', port);
         var socket = new eioc.Socket(url);
         socket.on('open', function () {
@@ -814,7 +809,7 @@ describe('server', function () {
     // polling test, transport error
     it('should trigger transport close before open for xhr', function (done) {
       var opts = { transports: ['polling'] };
-      var engine = listen(opts, function (port) {
+      listen(opts, function (port) {
         var socket = new eioc.Socket('http://invalidserver:%d'.s(port));
         socket.on('open', function () {
           done(new Error('Test invalidation'));
@@ -830,7 +825,7 @@ describe('server', function () {
     // websocket test, force close
     it('should trigger force close before open for ws', function (done) {
       var opts = { transports: ['websocket'] };
-      var engine = listen(opts, function (port) {
+      listen(opts, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         socket.on('open', function () {
           done(new Error('Test invalidation'));
@@ -847,7 +842,7 @@ describe('server', function () {
     // polling test, force close
     it('should trigger force close before open for xhr', function (done) {
       var opts = { transports: ['polling'] };
-      var engine = listen(opts, function (port) {
+      listen(opts, function (port) {
         var socket = new eioc.Socket('http://localhost:%d'.s(port));
         socket.on('open', function () {
           done(new Error('Test invalidation'));
@@ -919,7 +914,7 @@ describe('server', function () {
             conn.close();
           });
         });
-        new eioc.Socket('ws://localhost:%d'.s(port));
+        eioc('ws://localhost:%d'.s(port));
       });
     });
 
@@ -940,7 +935,7 @@ describe('server', function () {
     });
 
     it('should not crash when messing with Object prototype', function (done) {
-      Object.prototype.foo = 'bar';
+      Object.prototype.foo = 'bar'; // eslint-disable-line no-extend-native
       var engine = listen({ allowUpgrades: true }, function (port) {
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         socket.on('open', function () {
@@ -992,9 +987,9 @@ describe('server', function () {
 
     it('should arrive from server to client (multiple)', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port))
-          , expected = ['a', 'b', 'c']
-          , i = 0;
+        var socket = new eioc.Socket('ws://localhost:%d'.s(port));
+        var expected = ['a', 'b', 'c'];
+        var i = 0;
 
         engine.on('connection', function (conn) {
           conn.send('a');
@@ -1059,7 +1054,6 @@ describe('server', function () {
       });
     });
 
-
     it('should arrive from server to client (ws)', function (done) {
       var opts = { allowUpgrades: false, transports: ['websocket'] };
       var engine = listen(opts, function (port) {
@@ -1079,9 +1073,9 @@ describe('server', function () {
     it('should arrive from server to client (multiple, ws)', function (done) {
       var opts = { allowUpgrades: false, transports: ['websocket'] };
       var engine = listen(opts, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] })
-          , expected = ['a', 'b', 'c']
-          , i = 0;
+        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
+        var expected = ['a', 'b', 'c'];
+        var i = 0;
 
         engine.on('connection', function (conn) {
           conn.send('a');
@@ -1111,9 +1105,9 @@ describe('server', function () {
     it('should arrive from server to client (multiple, no delay, ws)', function (done) {
       var opts = { allowUpgrades: false, transports: ['websocket'] };
       var engine = listen(opts, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] })
-          , expected = ['a', 'b', 'c']
-          , i = 0;
+        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
+        var expected = ['a', 'b', 'c'];
+        var i = 0;
 
         engine.on('connection', function (conn) {
           conn.on('close', function () {
@@ -1325,7 +1319,6 @@ describe('server', function () {
       });
     });
 
-
     it('should trigger a flush/drain event', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
         engine.on('connection', function (socket) {
@@ -1354,7 +1347,7 @@ describe('server', function () {
           socket.send('aaaa');
         });
 
-        new eioc.Socket('ws://localhost:%d'.s(port));
+        eioc('ws://localhost:%d'.s(port));
       });
     });
 
@@ -1378,7 +1371,7 @@ describe('server', function () {
         });
         var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
         socket.on('open', function () {
-          for (var i = 0;i < messageCount;i++) {
+          for (var i = 0; i < messageCount; i++) {
 //            connection.send('message: ' + i);   // works
             connection.send(messagePayload + '|message: ' + i);   // does not work
           }
@@ -1443,7 +1436,7 @@ describe('server', function () {
         key: fs.readFileSync('test/fixtures/client.key'),
         cert: fs.readFileSync('test/fixtures/client.crt'),
         ca: fs.readFileSync('test/fixtures/ca.crt'),
-        transports: ['polling'],
+        transports: ['polling']
       };
 
       var srv = https.createServer(srvOpts, function (req, res) {
@@ -1629,7 +1622,7 @@ describe('server', function () {
   describe('send', function () {
     describe('writeBuffer', function () {
       it('should not empty until `drain` event (polling)', function (done) {
-        var engine = listen({ allowUpgrades: false }, function (port) {
+        listen({ allowUpgrades: false }, function (port) {
           var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['polling'] });
           var totalEvents = 2;
           socket.on('open', function () {
@@ -1646,7 +1639,7 @@ describe('server', function () {
       });
 
       it('should not empty until `drain` event (websocket)', function (done) {
-        var engine = listen({ allowUpgrades: false }, function (port) {
+        listen({ allowUpgrades: false }, function (port) {
           var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
           var totalEvents = 2;
           socket.on('open', function () {
@@ -1900,7 +1893,6 @@ describe('server', function () {
             conn.send('a', function (transport) {
               i++;
             });
-
           });
           socket.on('open', function () {
             socket.on('message', function (msg) {
@@ -1937,7 +1929,6 @@ describe('server', function () {
             conn.send('a', function (transport) {
               i++;
             });
-
           });
           socket.on('open', function () {
             socket.on('message', function (msg) {
@@ -2021,7 +2012,7 @@ describe('server', function () {
 
     it('should emit when receives ping', function (done) {
       var engine = listen({ allowUpgrades: false, pingInterval: 4 }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port));
+        eioc('ws://localhost:%d'.s(port));
         engine.on('connection', function (conn) {
           conn.on('packet', function (packet) {
             conn.close();
@@ -2036,7 +2027,7 @@ describe('server', function () {
   describe('packetCreate', function () {
     it('should emit before socket send message', function (done) {
       var engine = listen({ allowUpgrades: false }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port));
+        eioc('ws://localhost:%d'.s(port));
         engine.on('connection', function (conn) {
           conn.on('packetCreate', function (packet) {
             expect(packet.type).to.be('message');
@@ -2050,7 +2041,7 @@ describe('server', function () {
 
     it('should emit before send pong', function (done) {
       var engine = listen({ allowUpgrades: false, pingInterval: 4 }, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port));
+        eioc('ws://localhost:%d'.s(port));
         engine.on('connection', function (conn) {
           conn.on('packetCreate', function (packet) {
             conn.close();
@@ -2066,7 +2057,8 @@ describe('server', function () {
     it('should upgrade', function (done) {
       var engine = listen(function (port) {
         // it takes both to send 50 to verify
-        var ready = 2, closed = 2;
+        var ready = 2;
+        var closed = 2;
         function finish () {
           setTimeout(function () {
             socket.close();
@@ -2075,7 +2067,9 @@ describe('server', function () {
 
         // server
         engine.on('connection', function (conn) {
-          var lastSent = 0, lastReceived = 0, upgraded = false;
+          var lastSent = 0;
+          var lastReceived = 0;
+          var upgraded = false;
           var interval = setInterval(function () {
             lastSent++;
             conn.send(lastSent);
@@ -2112,7 +2106,9 @@ describe('server', function () {
         // client
         var socket = new eioc.Socket('ws://localhost:%d'.s(port));
         socket.on('open', function () {
-          var lastSent = 0, lastReceived = 0, upgrades = 0;
+          var lastSent = 0;
+          var lastReceived = 0;
+          var upgrades = 0;
           var interval = setInterval(function () {
             lastSent++;
             socket.send(lastSent);
@@ -2152,7 +2148,7 @@ describe('server', function () {
       });
 
       // attach another engine to make sure it doesn't break upgrades
-      var e2 = eio.attach(engine.httpServer, { path: '/foo' });
+      eio.attach(engine.httpServer, { path: '/foo' });
     });
   });
 
@@ -2335,7 +2331,7 @@ describe('server', function () {
           for (var i = 0; i < buf.length; i++) buf[i] = i % 0xff;
           conn.send(buf, { compress: true });
         });
-        new eioc.Socket('http://localhost:%d'.s(port), { transports: ['websocket'] });
+        eioc('http://localhost:%d'.s(port), { transports: ['websocket'] });
       });
     });
 
@@ -2357,7 +2353,7 @@ describe('server', function () {
           for (var i = 0; i < buf.length; i++) buf[i] = i % 0xff;
           conn.send(buf, { compress: true });
         });
-        new eioc.Socket('http://localhost:%d'.s(port), { transports: ['websocket'] });
+        eioc('http://localhost:%d'.s(port), { transports: ['websocket'] });
       });
     });
   });
@@ -2406,7 +2402,7 @@ describe('server', function () {
           });
           conn.send('hi');
         });
-        new eioc.Socket('ws://localhost:%d'.s(port), {
+        eioc('ws://localhost:%d'.s(port), {
           extraHeaders: headers,
           transports: ['polling']
         });

From ecafee55ce4a0ea49ebbb2599f261daec8ab1794 Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Wed, 23 Mar 2016 00:21:20 +0800
Subject: [PATCH 10/11] Print call stack on error

---
 gulpfile.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gulpfile.js b/gulpfile.js
index d6af33022..4fc766dfa 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -15,7 +15,8 @@ gulp.task('test', function () {
       reporter: REPORTER,
       bail: true
     }))
-    .once('error', function () {
+    .once('error', function (err) {
+      console.error(err.stack);
       process.exit(1);
     })
     .once('end', function () {

From 885dae0a041ce13317552f4d88659829b1bee575 Mon Sep 17 00:00:00 2001
From: Diga Widyaprana <digawp@gmail.com>
Date: Wed, 23 Mar 2016 00:23:13 +0800
Subject: [PATCH 11/11] Lint before test

---
 gulpfile.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gulpfile.js b/gulpfile.js
index 4fc766dfa..cfd1bb278 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -8,7 +8,7 @@ const REPORTER = 'dot';
 
 gulp.task('default', ['transpile']);
 
-gulp.task('test', function () {
+gulp.task('test', ['lint'], function () {
   return gulp.src(TESTS, {read: false})
     .pipe(mocha({
       slow: 500,