Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json main entry missing extension #608

Merged
merged 1 commit into from Nov 8, 2020
Merged

package.json main entry missing extension #608

merged 1 commit into from Nov 8, 2020

Conversation

AStoker
Copy link
Contributor

@AStoker AStoker commented Nov 4, 2020

The main entry for the package.json file is for defining the entry point. The entry is currently missing the required .js extension, this PR brings it back.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

The main entry in the package.json file requires an extension that is currently lacking. This causes issues when tools try to automatically find the main file based off the package.json (you end up with a file not found exception)

New behaviour

Added the .js extension to the entry for main.js

Other information (e.g. related issues)

Resolves #607

The `main` entry for the `package.json` file is for defining the entry point. The entry is currently missing the required `.js` extension, this PR brings it back.
@darrachequesne darrachequesne merged commit 17b8c2f into socketio:master Nov 8, 2020
1 check passed
@darrachequesne
Copy link
Member

Thanks! Out of curiosity, which tool needs the .js extension?

@darrachequesne darrachequesne added this to the 4.0.2 milestone Nov 9, 2020
@AStoker
Copy link
Contributor Author

AStoker commented Nov 9, 2020

@darrachequesne, ran into it when trying to generate import maps with this tool: https://github.com/jsenv/jsenv-node-module-import-map

@AStoker AStoker deleted the patch-1 branch November 9, 2020 16:30
darrachequesne pushed a commit that referenced this pull request Jun 6, 2022
The `main` entry for the `package.json` file is for defining the entry
point. The entry is currently missing the required `.js` extension,
this PR brings it back.

Backported from 17b8c2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix main entry in package.json
2 participants