Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CorsOptionsDelegate as cors options #641

merged 2 commits into from Feb 17, 2022


Copy link

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

Following strict typescript rules you cannot set the cors options to be a function as described here

New behaviour

You can now set the cors options to be a delegated function to determine cors options dynamically.

Other information (e.g. related issues)

@darrachequesne darrachequesne merged commit a463d26 into socketio:master Feb 17, 2022
2 checks passed
Copy link

@vandernorth thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants