Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swift warnings #1359

Merged
merged 1 commit into from Jun 19, 2021
Merged

Fix swift warnings #1359

merged 1 commit into from Jun 19, 2021

Conversation

WyattMufson
Copy link
Contributor

@WyattMufson WyattMufson commented Jun 17, 2021 •
edited

In

case let .disconnected(reason, code):

both reason and code were not being used.

In

public protocol SocketEngineSpec: class {

you should be using AnyObject instead of class

In

public protocol SocketManagerSpec : AnyObject, SocketEngineClient {

AnyObject was redundant

@WyattMufson
Copy link
Contributor Author

@nuclearace this fixed a number of warnings

@nuclearace nuclearace merged commit 07f2d08 into socketio:master Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WyattMufson @nuclearace