Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

disconnect while connecting causes traceback #557

Closed
bpytlik opened this Issue · 2 comments

3 participants

@bpytlik

If you call disconnect on a socket while it's still trying to connect, you'll get a nasty traceback because its transport is null. While this might be uncommon in typical usage, it's a large issue in test suites. It can be worked around by stalling until the socket is connect but at least in v0.10.8 that seems to be sometimes taking longer than half a second. I've even had it take longer than 2s.

The ideal fix for this is for disconnect to be able to stop the connection no matter what state the socket is in.

@rauchg rauchg closed this
@bpytlik

Any explanation why this was closed? Was it fixed? If so, in what version? If not, why is it being closed? Afaik, it remains an issue.

@3rd-Eden

It's probably closed because this issue was made for 0.9 and in 1.0 everything got rewritten so it no longer applies to the current code base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.