disconnect while connecting causes traceback #557

Closed
bpytlik opened this Issue May 30, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@bpytlik

bpytlik commented May 30, 2013

If you call disconnect on a socket while it's still trying to connect, you'll get a nasty traceback because its transport is null. While this might be uncommon in typical usage, it's a large issue in test suites. It can be worked around by stalling until the socket is connect but at least in v0.10.8 that seems to be sometimes taking longer than half a second. I've even had it take longer than 2s.

The ideal fix for this is for disconnect to be able to stop the connection no matter what state the socket is in.

@rauchg rauchg closed this Nov 25, 2014

@bpytlik

This comment has been minimized.

Show comment Hide comment
@bpytlik

bpytlik Nov 25, 2014

Any explanation why this was closed? Was it fixed? If so, in what version? If not, why is it being closed? Afaik, it remains an issue.

bpytlik commented Nov 25, 2014

Any explanation why this was closed? Was it fixed? If so, in what version? If not, why is it being closed? Afaik, it remains an issue.

@3rd-Eden

This comment has been minimized.

Show comment Hide comment
@3rd-Eden

3rd-Eden Nov 25, 2014

Contributor

It's probably closed because this issue was made for 0.9 and in 1.0 everything got rewritten so it no longer applies to the current code base

Contributor

3rd-Eden commented Nov 25, 2014

It's probably closed because this issue was made for 0.9 and in 1.0 everything got rewritten so it no longer applies to the current code base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment