New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nsp prefix to socket.id #1058

Merged
merged 2 commits into from Jan 13, 2017

Conversation

Projects
None yet
2 participants
@darrachequesne
Copy link
Member

darrachequesne commented Jan 10, 2017

Following #959

Currently, the socket.id for a non-default namespace is different on the server / on the client (e9232kh on the client, no matter which namespace, but /<nsp>#e9232kh on the server). That commit fixes that.

Related: https://github.com/socketio/socket.io/pull/2509/files

@darrachequesne darrachequesne referenced this pull request Jan 13, 2017

Closed

Make Socket.IO great again #2823

12 of 15 tasks complete

@darrachequesne darrachequesne merged commit fcb5c43 into socketio:master Jan 13, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@darrachequesne darrachequesne deleted the darrachequesne:fix/socket-id branch Jan 13, 2017

@darrachequesne darrachequesne added this to the 2.0.0 milestone Jun 1, 2017

@niallel niallel referenced this pull request Jul 15, 2017

Closed

2.x and 1.x compatibility #3007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment