Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Adding types for some emitter functions. #1502

Merged

Conversation

@AbdUlHamedMaree
Copy link
Contributor

@AbdUlHamedMaree AbdUlHamedMaree commented Oct 13, 2021

Note: the socket.io.js file is the generated output of make socket.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

socket.off and other socket functions don't have the proper types.

New behaviour

socket.off and other socket functions have the proper types.

Abd UlHameed Maree added 2 commits Oct 13, 2021
to comunicate with the super class (Emitter),
but with some types.
@darrachequesne darrachequesne merged commit a9e5b85 into socketio:master Oct 14, 2021
3 of 4 checks passed
@darrachequesne
Copy link
Member

@darrachequesne darrachequesne commented Oct 14, 2021

@AbdUlHamedMaree thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants