Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Calling socket.disconnect() on a reconnecting socket should end reconnection attempts #308

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

byrion commented Sep 26, 2011

If the client disconnects from the server (eg. server falls over) and reconnect = true, the client starts attempting to reconnect to the server. However when you call socket.disconnect() on that client the client continues to reconnect until successful (or reconnect limits reached).

I think the expected behaviour of calling disconnect should be to cease reconnection attempts.

The following few changes fixes this.

Jimflip commented Jan 10, 2012

+1 yeah that makes much more sense, please pull this if it works

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment