don't position the jsonp form off the screen #412

Merged
merged 1 commit into from Apr 6, 2012

Conversation

Projects
None yet
2 participants
Contributor

mreinsch commented Apr 6, 2012

I had issues with android handsets using jsonp. When using this method and delivering a page optimized for smartphones, the android stock browser would increase the width of the page when starting socket.io. It turns out that positioning the form for transmitting data with negative left/top position caused this.

@mreinsch mreinsch don't position the jsonp form off the screen, this causes the default…
… browser on some androids to actually extend the width of the document
5712754
Contributor

rauchg commented Apr 6, 2012

Does display: none cause any side effect on the non-android scenarios ?
We should also remove the positioning properties if we're gonna hide it.

Contributor

rauchg commented Apr 6, 2012

Thanks a lot Michael

Contributor

mreinsch commented Apr 6, 2012

Thanks for the fast reply!

We are using this code on http://qlive.co/ and I haven't seen any issues with Android / iPhone - but please test on more browsers :-) - Feel free to use http://qlive.co/events/fxrRy for tests if you like ...

Contributor

rauchg commented Apr 6, 2012

Nice, really cool app btw!

rauchg merged commit 2c50aae into socketio:master Apr 6, 2012

Contributor

mreinsch commented Apr 6, 2012

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment