Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

socket should be disconnected when using namespace #664

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

socket.onDisconnect() was not called on client side when socket.disconnect() was called with using namespace on server side.

Therefore, transports were not closed and kept waiting for incoming packets.

This could cause a trouble when server is restarted or connection disrupted.
Browser consoles will show "Failed to load resources", for example, even after socket.disconnect() was called on server.

Related issue I found is: LearnBoost/socket.io#795

This fix is very simple and it just call socket.onDisconnect() when using namespace.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment