Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add autoConnect option #680

Merged
merged 2 commits into from Jun 22, 2014

Conversation

Projects
None yet
2 participants
Contributor

FredyC commented Jun 1, 2014

I am wondering why this has been removed in 1.0. I found it very handy in 0.9. I would like to just grab the instance of Manager, attach even listeners and then open the connection.

I know that in docs you are suggesting the following approach:

var manager = io.Manager('url', { /* options */ });
var socket = manager.socket('/namespace');
manager.on('event_name_like_reconnect_attempt', function() {
}); 

That seems rather silly, because this way it is skipping whole lookup mechanics and the manager is not cached. I would have to pass around manager instances in my application on my own. Having autoConnect option could be safer and easier way. Am I missing something here ?

@rauchg rauchg added a commit that referenced this pull request Jun 22, 2014

@rauchg rauchg Merge pull request #680 from FredyC/add-auto-connect
Add autoConnect option
f8afcce

@rauchg rauchg merged commit f8afcce into socketio:master Jun 22, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment