Remove disconnected field #727

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@nkzawa
Collaborator
nkzawa commented Jul 12, 2014

Socket has both connected and disconnected fields which conflict with one another.
I think we can remove unused disconnected field.

@rauchg
Collaborator
rauchg commented Jul 14, 2014

This was more for BC, since we used to maintain it on Socket.IO 0.9. Maybe add a comment ?

@nkzawa
Collaborator
nkzawa commented Jul 15, 2014

Ah got it. A comment would be nice.
Additionally, It's better to make clear which fields are public. I thought disconnected is a private field.

@rase-
Collaborator
rase- commented Sep 22, 2014

Closing this PR in favor of adding the comment.

@rase- rase- closed this Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment