Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint #951

Merged
merged 8 commits into from Mar 2, 2016
Merged

Add ESLint #951

merged 8 commits into from Mar 2, 2016

Conversation

digawp
Copy link
Contributor

@digawp digawp commented Feb 27, 2016

  • Added linting (ESLint)
  • Made the code conform to the linter recommendation
  • Currently I made the default gulp task to run lint and build test sequentially; so we don't build test if the code does not pass linting

I will point out the places with important changes as it is hard to see with all the whitespace changes

"no-extra-semi": 2,
"semi-spacing": [2, { "before": false, "after": true }]
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eslint root config file. It supports comments inside json

rauchg added a commit that referenced this pull request Mar 2, 2016
@rauchg rauchg merged commit 78f61c3 into socketio:master Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants