Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of a custom replacer and reviver #112

Merged
merged 1 commit into from Apr 17, 2022

Conversation

bytenik
Copy link
Contributor

@bytenik bytenik commented Jan 21, 2022

We have a need for a custom replacer and reviver, but because tryParse is outside of the class, a reviver cannot be inserted. We'd have to copy/paste duplicate the entire parser to make this small modification on our end instead of just inheriting from it. Hence this PR, to allow for this functionality for everyone.

@cmocanu cmocanu force-pushed the custom-reviver-replacer branch from 822816b to ebf2bc4 Compare Feb 18, 2022
@cmocanu
Copy link
Contributor

cmocanu commented Feb 18, 2022

Updated to fix missing line that made prettier unhappy.

I hadn't run the CI locally since I can't npm install because I'm running on an ARM M1 Macbook.

@darrachequesne darrachequesne merged commit b08bc1a into socketio:master Apr 17, 2022
@darrachequesne
Copy link
Member

@bytenik @cmocanu thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants