Skip to content

docs: fix allSockets example #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

docs: fix allSockets example #381

merged 1 commit into from
Jan 21, 2021

Conversation

@yatki
Copy link
Contributor

@yatki yatki commented Jan 21, 2021

allSockets was missing the await keyword. See: https://socket.io/docs/v3/server-api/#namespace-allSockets

@darrachequesne darrachequesne merged commit 72fe98e into socketio:master Jan 21, 2021
@darrachequesne
Copy link
Member

darrachequesne commented Jan 21, 2021

@yatki good catch, thanks!

@yatki yatki deleted the patch-1 branch January 21, 2021 22:39
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yatki @darrachequesne